Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814821/?format=api
{ "id": 814821, "url": "http://patchwork.ozlabs.org/api/patches/814821/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170918082706.6485-5-npiggin@gmail.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170918082706.6485-5-npiggin@gmail.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170918082706.6485-5-npiggin@gmail.com/", "date": "2017-09-18T08:27:05", "name": "[4/5] powerpc/xmon: avoid tripping SMP hardlockup watchdog", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9907e3a40bad5efc676978cc0a46654eb5ee7f6e", "submitter": { "id": 69518, "url": "http://patchwork.ozlabs.org/api/people/69518/?format=api", "name": "Nicholas Piggin", "email": "npiggin@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170918082706.6485-5-npiggin@gmail.com/mbox/", "series": [ { "id": 3584, "url": "http://patchwork.ozlabs.org/api/series/3584/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=3584", "date": "2017-09-18T08:27:01", "name": "More NMI IPI enablement work", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3584/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814821/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814821/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwfVb3pT6z9rxm\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 18 Sep 2017 18:36:23 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xwfVb2gbmzDqGs\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 18 Sep 2017 18:36:23 +1000 (AEST)", "from mail-pf0-x244.google.com (mail-pf0-x244.google.com\n\t[IPv6:2607:f8b0:400e:c00::244])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xwfJN0J2LzDrWk\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tMon, 18 Sep 2017 18:27:32 +1000 (AEST)", "by mail-pf0-x244.google.com with SMTP id h4so4311992pfk.0\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tMon, 18 Sep 2017 01:27:31 -0700 (PDT)", "from roar.au.ibm.com ([210.185.119.235])\n\tby smtp.gmail.com with ESMTPSA id\n\td18sm14293750pfk.11.2017.09.18.01.27.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 01:27:28 -0700 (PDT)" ], "Authentication-Results": [ "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Zpn2US3H\"; dkim-atps=neutral", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Zpn2US3H\"; dkim-atps=neutral", "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c00::244; helo=mail-pf0-x244.google.com;\n\tenvelope-from=npiggin@gmail.com; receiver=<UNKNOWN>)", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Zpn2US3H\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=3qkX38bBdDtI1NNNQZ9YOle5nNrzchrgQ2Jn52j/VgI=;\n\tb=Zpn2US3HRD8QPKYO60YNr0uR2jav5rcG4zVlRk6XJB/s1tAZ5rzJSOeOELaPUd+B7D\n\to6vlovYOaNthaVK2shxCE6ph1Sw8R4j4l+s+HExjhrPl5U3LS69/xd+CBMTl7E719fx+\n\tNoKpI9f3v4NWl3HnkHf4SZuBh0OhaIUp18QwH9kiKgzn8+/1xp95o13xplvCjkfKm37g\n\t2xXxHPUp1uhZUNsnEYpTqL/o/tQchY1DZ2DzpVnASHzgpPr+jXiu5iH3/asURr/He8ab\n\tJvB5EJ4NT2GtKJvS5iCTWSWVhJR1lk1yAPPmWbpnam+o3QBu3ZduCwhiNf/YZIFB3rKk\n\t2hjw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=3qkX38bBdDtI1NNNQZ9YOle5nNrzchrgQ2Jn52j/VgI=;\n\tb=qRuNGz0c+OYwkkHOFP1zLldpfW5c9NQVr3oCUvGs605ku9bV1+9GkLSl07XkituHgl\n\t2Qbx6fL5iC4tDL6xoZor3i257b75jPZtoR6f7iqenOvumciu541i+qb4XsHl8hWHSBrn\n\tER0f1SJu5knqu3hiHF2mPV9RajMbeDa/1OtQENvP4tkZQrOPE+V9avm4WnWf7/Tr9eyi\n\th7Il4gGPDhAdQSDv6jw8T877KWRbXYqhMzkKYayiWOkrcYBDKAoXksu51sC0FGGbpd2c\n\tmFrcl3Ltv7FdAjHALP/SJhX0dr/xizspnxc08OlNZfK390weyNnt5SQTFBNflSybLS7a\n\tmuNQ==", "X-Gm-Message-State": "AHPjjUgKXatHts42xU69NXnu7sTnXW6g2QIPXNnVSABCl0sqHB+jvekj\n\tigCrLc2kIXgycmAT", "X-Google-Smtp-Source": "AOwi7QB6a9ychldKJYkTVwcEov14FZFEQ3IGzSivWJ0l+k0jkqbRnLnjvYgl658ZhFANhMHhLwtCKg==", "X-Received": "by 10.84.235.65 with SMTP id g1mr19176813plt.353.1505723249824; \n\tMon, 18 Sep 2017 01:27:29 -0700 (PDT)", "From": "Nicholas Piggin <npiggin@gmail.com>", "To": "linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH 4/5] powerpc/xmon: avoid tripping SMP hardlockup watchdog", "Date": "Mon, 18 Sep 2017 18:27:05 +1000", "Message-Id": "<20170918082706.6485-5-npiggin@gmail.com>", "X-Mailer": "git-send-email 2.13.3", "In-Reply-To": "<20170918082706.6485-1-npiggin@gmail.com>", "References": "<20170918082706.6485-1-npiggin@gmail.com>", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Nicholas Piggin <npiggin@gmail.com>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "The SMP hardlockup watchdog cross-checks other CPUs for lockups,\nwhich causes xmon headaches because it's assuming interrupts\nhard disabled means no watchdog troubles. Try to improve that by\ncalling touch_nmi_watchdog() in obvious places where secondaries\nare spinning.\n\nAlso annotate these spin loops with spin_begin/end calls.\n\nSigned-off-by: Nicholas Piggin <npiggin@gmail.com>\n---\n arch/powerpc/xmon/xmon.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c\nindex 33351c6704b1..d9a12102b111 100644\n--- a/arch/powerpc/xmon/xmon.c\n+++ b/arch/powerpc/xmon/xmon.c\n@@ -530,14 +530,19 @@ static int xmon_core(struct pt_regs *regs, int fromipi)\n \n waiting:\n \tsecondary = 1;\n+\tspin_begin();\n \twhile (secondary && !xmon_gate) {\n \t\tif (in_xmon == 0) {\n-\t\t\tif (fromipi)\n+\t\t\tif (fromipi) {\n+\t\t\t\tspin_end();\n \t\t\t\tgoto leave;\n+\t\t\t}\n \t\t\tsecondary = test_and_set_bit(0, &in_xmon);\n \t\t}\n-\t\tbarrier();\n+\t\tspin_cpu_relax();\n+\t\ttouch_nmi_watchdog();\n \t}\n+\tspin_end();\n \n \tif (!secondary && !xmon_gate) {\n \t\t/* we are the first cpu to come in */\n@@ -568,21 +573,25 @@ static int xmon_core(struct pt_regs *regs, int fromipi)\n \t\tmb();\n \t\txmon_gate = 1;\n \t\tbarrier();\n+\t\ttouch_nmi_watchdog();\n \t}\n \n cmdloop:\n \twhile (in_xmon) {\n \t\tif (secondary) {\n+\t\t\tspin_begin();\n \t\t\tif (cpu == xmon_owner) {\n \t\t\t\tif (!test_and_set_bit(0, &xmon_taken)) {\n \t\t\t\t\tsecondary = 0;\n+\t\t\t\t\tspin_end();\n \t\t\t\t\tcontinue;\n \t\t\t\t}\n \t\t\t\t/* missed it */\n \t\t\t\twhile (cpu == xmon_owner)\n-\t\t\t\t\tbarrier();\n+\t\t\t\t\tspin_cpu_relax();\n \t\t\t}\n-\t\t\tbarrier();\n+\t\t\tspin_cpu_relax();\n+\t\t\ttouch_nmi_watchdog();\n \t\t} else {\n \t\t\tcmd = cmds(regs);\n \t\t\tif (cmd != 0) {\n", "prefixes": [ "4/5" ] }