Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814592/?format=api
{ "id": 814592, "url": "http://patchwork.ozlabs.org/api/patches/814592/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505621128-23877-9-git-send-email-sukadev@linux.vnet.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<1505621128-23877-9-git-send-email-sukadev@linux.vnet.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/1505621128-23877-9-git-send-email-sukadev@linux.vnet.ibm.com/", "date": "2017-09-17T04:05:26", "name": "[08/10] powerpc/vas: poll for return of window credits", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "abc227cd0423e8ab6316d8f2ad4dd468e13d4d0b", "submitter": { "id": 984, "url": "http://patchwork.ozlabs.org/api/people/984/?format=api", "name": "Sukadev Bhattiprolu", "email": "sukadev@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505621128-23877-9-git-send-email-sukadev@linux.vnet.ibm.com/mbox/", "series": [ { "id": 3482, "url": "http://patchwork.ozlabs.org/api/series/3482/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=3482", "date": "2017-09-17T04:05:19", "name": "powerpc/vas: cleanup and optimizations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3482/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814592/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814592/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org", "linuxppc-dev@ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvwrR4DYnz9sBZ\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 17 Sep 2017 14:19:19 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xvwrR35nczDsnY\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 17 Sep 2017 14:19:19 +1000 (AEST)", "from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xvwY06vJxzDrnq\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSun, 17 Sep 2017 14:05:56 +1000 (AEST)", "from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\tby bilbo.ozlabs.org (Postfix) with ESMTP id 3xvwY05dllz8vmk\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSun, 17 Sep 2017 14:05:56 +1000 (AEST)", "by ozlabs.org (Postfix)\n\tid 3xvwY04vC7z9t2f; Sun, 17 Sep 2017 14:05:56 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvwXz6vnFz9t5P\n\tfor <linuxppc-dev@ozlabs.org>; Sun, 17 Sep 2017 14:05:55 +1000 (AEST)", "from pps.filterd (m0098419.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8H44ZOq014081\n\tfor <linuxppc-dev@ozlabs.org>; Sun, 17 Sep 2017 00:05:51 -0400", "from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d0vwg4ktq-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <linuxppc-dev@ozlabs.org>; Sun, 17 Sep 2017 00:05:51 -0400", "from localhost\n\tby e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@ozlabs.org> from <sukadev@linux.vnet.ibm.com>;\n\tSat, 16 Sep 2017 22:05:51 -0600", "from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20)\n\tby e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tSat, 16 Sep 2017 22:05:47 -0600", "from b03ledav005.gho.boulder.ibm.com\n\t(b03ledav005.gho.boulder.ibm.com [9.17.130.236])\n\tby b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8H45kL624576244; Sat, 16 Sep 2017 21:05:46 -0700", "from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 97204BE039;\n\tSat, 16 Sep 2017 22:05:46 -0600 (MDT)", "from suka-w540.usor.ibm.com (unknown [9.70.94.25])\n\tby b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP id 32E80BE040;\n\tSat, 16 Sep 2017 22:05:46 -0600 (MDT)" ], "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=sukadev@linux.vnet.ibm.com; receiver=<UNKNOWN>)", "From": "Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>", "To": "Michael Ellerman <mpe@ellerman.id.au>", "Subject": "[PATCH 08/10] powerpc/vas: poll for return of window credits", "Date": "Sat, 16 Sep 2017 21:05:26 -0700", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1505621128-23877-1-git-send-email-sukadev@linux.vnet.ibm.com>", "References": "<1505621128-23877-1-git-send-email-sukadev@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17091704-0008-0000-0000-000008951209", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007754; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000229; SDB=6.00918138; UDB=6.00461174;\n\tIPR=6.00698364; \n\tBA=6.00005592; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017185;\n\tXFM=3.00000015; UTC=2017-09-17 04:05:49", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17091704-0009-0000-0000-00004400E39D", "Message-Id": "<1505621128-23877-9-git-send-email-sukadev@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-17_03:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709170058", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "linuxppc-dev@ozlabs.org, mikey@neuling.org, linux-kernel@vger.kernel.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "Normally, the NX driver waits for the CRBs to be processed before closing\nthe window. But it is better to ensure that the credits are returned before\nthe window gets reassigned later.\n\nSigned-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>\n---\n arch/powerpc/platforms/powernv/vas-window.c | 45 +++++++++++++++++++++++++++++\n 1 file changed, 45 insertions(+)", "diff": "diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c\nindex a59a187..8e14ce1 100644\n--- a/arch/powerpc/platforms/powernv/vas-window.c\n+++ b/arch/powerpc/platforms/powernv/vas-window.c\n@@ -1063,6 +1063,49 @@ int vas_paste_crb(struct vas_window *txwin, int offset, bool re)\n EXPORT_SYMBOL_GPL(vas_paste_crb);\n \n /*\n+ * If credit checking is enabled for this window, poll for the return\n+ * of window credits (i.e for NX engines to process any outstanding CRBs).\n+ * Since NX-842 waits for the CRBs to be processed before closing the\n+ * window, we should not have to wait for too long.\n+ *\n+ * TODO: We retry in 10ms intervals now. We could/should probably peek at\n+ * \tthe VAS_LRFIFO_PUSH_OFFSET register to get an estimate of pending\n+ * \tCRBs on the FIFO and compute the delay dynamically on each retry.\n+ * \tBut that is not really needed until we support NX-GZIP access from\n+ * \tuser space. (NX-842 driver waits for CSB and Fast thread-wakeup\n+ * \tdoesn't use credit checking).\n+ */\n+static void poll_window_credits(struct vas_window *window)\n+{\n+\tu64 val;\n+\tint creds, mode;\n+\n+\tval = read_hvwc_reg(window, VREG(WINCTL));\n+\tif (window->tx_win)\n+\t\tmode = GET_FIELD(VAS_WINCTL_TX_WCRED_MODE, val);\n+\telse\n+\t\tmode = GET_FIELD(VAS_WINCTL_RX_WCRED_MODE, val);\n+\n+\tif (!mode)\n+\t\treturn;\n+retry:\n+\tif (window->tx_win) {\n+\t\tval = read_hvwc_reg(window, VREG(TX_WCRED));\n+\t\tcreds = GET_FIELD(VAS_TX_WCRED, val);\n+\t} else {\n+\t\tval = read_hvwc_reg(window, VREG(LRX_WCRED));\n+\t\tcreds = GET_FIELD(VAS_LRX_WCRED, val);\n+\t}\n+\n+\tif (creds < window->wcreds_max) {\n+\t\tval = 0;\n+\t\tset_current_state(TASK_UNINTERRUPTIBLE);\n+\t\tschedule_timeout(msecs_to_jiffies(10));\n+\t\tgoto retry;\n+\t}\n+}\n+\n+/*\n * Wait for the window to go to \"not-busy\" state. It should only take a\n * short time to queue a CRB, so window should not be busy for too long.\n * Trying 5ms intervals.\n@@ -1149,6 +1192,8 @@ int vas_win_close(struct vas_window *window)\n \n \tunpin_close_window(window);\n \n+\tpoll_window_credits(window);\n+\n \tpoll_window_castout(window);\n \n \t/* if send window, drop reference to matching receive window */\n", "prefixes": [ "08/10" ] }