Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814587/?format=api
{ "id": 814587, "url": "http://patchwork.ozlabs.org/api/patches/814587/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505621128-23877-4-git-send-email-sukadev@linux.vnet.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<1505621128-23877-4-git-send-email-sukadev@linux.vnet.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/1505621128-23877-4-git-send-email-sukadev@linux.vnet.ibm.com/", "date": "2017-09-17T04:05:21", "name": "[03/10] powerpc/vas: Cleanup some debug code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b0786eae0bf826a88b526fa9223e9f16f3feba74", "submitter": { "id": 984, "url": "http://patchwork.ozlabs.org/api/people/984/?format=api", "name": "Sukadev Bhattiprolu", "email": "sukadev@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505621128-23877-4-git-send-email-sukadev@linux.vnet.ibm.com/mbox/", "series": [ { "id": 3482, "url": "http://patchwork.ozlabs.org/api/series/3482/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=3482", "date": "2017-09-17T04:05:19", "name": "powerpc/vas: cleanup and optimizations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3482/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814587/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814587/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org", "linuxppc-dev@ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvwhw3Y50z9s7h\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 17 Sep 2017 14:12:48 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xvwhw2fchzDsQb\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 17 Sep 2017 14:12:48 +1000 (AEST)", "from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xvwXp6BWCzDrn7\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSun, 17 Sep 2017 14:05:46 +1000 (AEST)", "from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\tby bilbo.ozlabs.org (Postfix) with ESMTP id 3xvwXp5S0wz8t3H\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSun, 17 Sep 2017 14:05:46 +1000 (AEST)", "by ozlabs.org (Postfix)\n\tid 3xvwXp5C7hz9t2V; Sun, 17 Sep 2017 14:05:46 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvwXp1Bv0z9s7p\n\tfor <linuxppc-dev@ozlabs.org>; Sun, 17 Sep 2017 14:05:45 +1000 (AEST)", "from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8H44Pbj049153\n\tfor <linuxppc-dev@ozlabs.org>; Sun, 17 Sep 2017 00:05:44 -0400", "from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d10ggga40-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <linuxppc-dev@ozlabs.org>; Sun, 17 Sep 2017 00:05:44 -0400", "from localhost\n\tby e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@ozlabs.org> from <sukadev@linux.vnet.ibm.com>;\n\tSat, 16 Sep 2017 22:05:43 -0600", "from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19)\n\tby e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tSat, 16 Sep 2017 22:05:39 -0600", "from b03ledav005.gho.boulder.ibm.com\n\t(b03ledav005.gho.boulder.ibm.com [9.17.130.236])\n\tby b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8H45dmC65208430; Sat, 16 Sep 2017 21:05:39 -0700", "from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 39205BE03E;\n\tSat, 16 Sep 2017 22:05:39 -0600 (MDT)", "from suka-w540.usor.ibm.com (unknown [9.70.94.25])\n\tby b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP id D259DBE040;\n\tSat, 16 Sep 2017 22:05:38 -0600 (MDT)" ], "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=sukadev@linux.vnet.ibm.com; receiver=<UNKNOWN>)", "From": "Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>", "To": "Michael Ellerman <mpe@ellerman.id.au>", "Subject": "[PATCH 03/10] powerpc/vas: Cleanup some debug code", "Date": "Sat, 16 Sep 2017 21:05:21 -0700", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1505621128-23877-1-git-send-email-sukadev@linux.vnet.ibm.com>", "References": "<1505621128-23877-1-git-send-email-sukadev@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17091704-0020-0000-0000-00000CB87752", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007754; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000229; SDB=6.00918138; UDB=6.00461173;\n\tIPR=6.00698363; \n\tBA=6.00005592; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017185;\n\tXFM=3.00000015; UTC=2017-09-17 04:05:41", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17091704-0021-0000-0000-00005E291245", "Message-Id": "<1505621128-23877-4-git-send-email-sukadev@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-17_03:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709170058", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "linuxppc-dev@ozlabs.org, mikey@neuling.org, linux-kernel@vger.kernel.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "Cleanuup vas.h and the debug code around ifdef vas_debug.\n\nSigned-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>\n---\n arch/powerpc/platforms/powernv/vas-window.c | 8 +++--\n arch/powerpc/platforms/powernv/vas.h | 56 +++++++----------------------\n 2 files changed, 18 insertions(+), 46 deletions(-)", "diff": "diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c\nindex a2fe120..67ffc5d 100644\n--- a/arch/powerpc/platforms/powernv/vas-window.c\n+++ b/arch/powerpc/platforms/powernv/vas-window.c\n@@ -726,7 +726,10 @@ static void init_winctx_for_rxwin(struct vas_window *rxwin,\n static bool rx_win_args_valid(enum vas_cop_type cop,\n \t\t\tstruct vas_rx_win_attr *attr)\n {\n-\tdump_rx_win_attr(attr);\n+\tpr_debug(\"Rxattr: fault %d, notify %d, intr %d, early %d, fifo %d\\n\",\n+\t\t\tattr->fault_win, attr->notify_disable,\n+\t\t\tattr->intr_disable, attr->notify_early,\n+\t\t\tattr->rx_fifo_size);\n \n \tif (cop >= VAS_COP_TYPE_MAX)\n \t\treturn false;\n@@ -1050,7 +1053,8 @@ int vas_paste_crb(struct vas_window *txwin, int offset, bool re)\n \telse\n \t\trc = -EINVAL;\n \n-\tprint_fifo_msg_count(txwin);\n+\tpr_debug(\"Txwin #%d: Msg count %llu\\n\", txwin->winid,\n+\t\t\tread_hvwc_reg(txwin, VREG(LRFIFO_PUSH)));\n \n \treturn rc;\n }\ndiff --git a/arch/powerpc/platforms/powernv/vas.h b/arch/powerpc/platforms/powernv/vas.h\nindex fea0de4..15d2dfa 100644\n--- a/arch/powerpc/platforms/powernv/vas.h\n+++ b/arch/powerpc/platforms/powernv/vas.h\n@@ -259,6 +259,16 @@\n #define VAS_NX_UTIL_ADDER\t\tPPC_BITMASK(32, 63)\n \n /*\n+ * VREG(x):\n+ * Expand a register's short name (eg: LPID) into two parameters:\n+ *\t- the register's short name in string form (\"LPID\"), and\n+ *\t- the name of the macro (eg: VAS_LPID_OFFSET), defining the\n+ *\t register's offset in the window context\n+ */\n+#define VREG_SFX(n, s)\t__stringify(n), VAS_##n##s\n+#define VREG(r)\t\tVREG_SFX(r, _OFFSET)\n+\n+/*\n * Local Notify Scope Control Register. (Receive windows only).\n */\n enum vas_notify_scope {\n@@ -385,43 +395,15 @@ struct vas_winctx {\n \n extern struct vas_instance *find_vas_instance(int vasid);\n \n-/*\n- * VREG(x):\n- * Expand a register's short name (eg: LPID) into two parameters:\n- *\t- the register's short name in string form (\"LPID\"), and\n- *\t- the name of the macro (eg: VAS_LPID_OFFSET), defining the\n- *\t register's offset in the window context\n- */\n-#define VREG_SFX(n, s)\t__stringify(n), VAS_##n##s\n-#define VREG(r)\t\tVREG_SFX(r, _OFFSET)\n-\n-#ifdef vas_debug\n-static inline void dump_rx_win_attr(struct vas_rx_win_attr *attr)\n-{\n-\tpr_err(\"fault %d, notify %d, intr %d early %d\\n\",\n-\t\t\tattr->fault_win, attr->notify_disable,\n-\t\t\tattr->intr_disable, attr->notify_early);\n-\n-\tpr_err(\"rx_fifo_size %d, max value %d\\n\",\n-\t\t\t\tattr->rx_fifo_size, VAS_RX_FIFO_SIZE_MAX);\n-}\n-\n static inline void vas_log_write(struct vas_window *win, char *name,\n \t\t\tvoid *regptr, u64 val)\n {\n-\tif (val)\n-\t\tpr_err(\"%swin #%d: %s reg %p, val 0x%016llx\\n\",\n+\tif (!val)\n+\t\tpr_debug(\"%swin #%d: %s reg %p, val 0x%016llx\\n\",\n \t\t\t\twin->tx_win ? \"Tx\" : \"Rx\", win->winid, name,\n \t\t\t\tregptr, val);\n }\n \n-#else\t/* vas_debug */\n-\n-#define vas_log_write(win, name, reg, val)\n-#define dump_rx_win_attr(attr)\n-\n-#endif\t/* vas_debug */\n-\n static inline void write_uwc_reg(struct vas_window *win, char *name,\n \t\t\ts32 reg, u64 val)\n {\n@@ -450,18 +432,4 @@ static inline u64 read_hvwc_reg(struct vas_window *win,\n \treturn in_be64(win->hvwc_map+reg);\n }\n \n-#ifdef vas_debug\n-\n-static void print_fifo_msg_count(struct vas_window *txwin)\n-{\n-\tuint64_t read_hvwc_reg(struct vas_window *w, char *n, uint64_t o);\n-\tpr_devel(\"Winid %d, Msg count %llu\\n\", txwin->winid,\n-\t\t\t(uint64_t)read_hvwc_reg(txwin, VREG(LRFIFO_PUSH)));\n-}\n-#else\t/* vas_debug */\n-\n-#define print_fifo_msg_count(window)\n-\n-#endif\t/* vas_debug */\n-\n #endif /* _VAS_H */\n", "prefixes": [ "03/10" ] }