Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814530/?format=api
{ "id": 814530, "url": "http://patchwork.ozlabs.org/api/patches/814530/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1505580378-9044-3-git-send-email-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505580378-9044-3-git-send-email-peter.maydell@linaro.org>", "list_archive_url": null, "date": "2017-09-16T16:46:14", "name": "[2/6] hw/gpio/omap_gpio.c: Don't use old_mmio", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "23e07ad860cc495535a9f4323f44939b088a9575", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1505580378-9044-3-git-send-email-peter.maydell@linaro.org/mbox/", "series": [ { "id": 3457, "url": "http://patchwork.ozlabs.org/api/series/3457/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3457", "date": "2017-09-16T16:46:12", "name": "convert some omap/palm devices from using old_mmio", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3457/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814530/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814530/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvdZ16VKVz9s78\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 17 Sep 2017 02:50:49 +1000 (AEST)", "from localhost ([::1]:57992 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dtGIq-0003Hl-0w\n\tfor incoming@patchwork.ozlabs.org; Sat, 16 Sep 2017 12:50:48 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:52625)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pm215@archaic.org.uk>) id 1dtGEG-0008Fv-RB\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 12:46:06 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pm215@archaic.org.uk>) id 1dtGEF-0007AW-Ua\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 12:46:04 -0400", "from orth.archaic.org.uk ([2001:8b0:1d0::2]:37412)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <pm215@archaic.org.uk>)\n\tid 1dtGED-00075o-J9; Sat, 16 Sep 2017 12:46:01 -0400", "from pm215 by orth.archaic.org.uk with local (Exim 4.89)\n\t(envelope-from <pm215@archaic.org.uk>)\n\tid 1dtGE0-00015k-5B; Sat, 16 Sep 2017 17:45:48 +0100" ], "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org", "Date": "Sat, 16 Sep 2017 17:46:14 +0100", "Message-Id": "<1505580378-9044-3-git-send-email-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1505580378-9044-1-git-send-email-peter.maydell@linaro.org>", "References": "<1505580378-9044-1-git-send-email-peter.maydell@linaro.org>", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2001:8b0:1d0::2", "Subject": "[Qemu-devel] [PATCH 2/6] hw/gpio/omap_gpio.c: Don't use old_mmio", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "patches@linaro.org", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Drop the use of old_mmio in the omap2_gpio memory ops.\n\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\n hw/gpio/omap_gpio.c | 26 ++++++++++++--------------\n 1 file changed, 12 insertions(+), 14 deletions(-)", "diff": "diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_gpio.c\nindex 1df394e..17891e2 100644\n--- a/hw/gpio/omap_gpio.c\n+++ b/hw/gpio/omap_gpio.c\n@@ -525,17 +525,23 @@ static void omap2_gpio_module_write(void *opaque, hwaddr addr,\n }\n }\n \n-static uint32_t omap2_gpio_module_readp(void *opaque, hwaddr addr)\n+static uint64_t omap2_gpio_module_readp(void *opaque, hwaddr addr,\n+ unsigned size)\n {\n return omap2_gpio_module_read(opaque, addr & ~3) >> ((addr & 3) << 3);\n }\n \n static void omap2_gpio_module_writep(void *opaque, hwaddr addr,\n- uint32_t value)\n+ uint64_t value, unsigned size)\n {\n uint32_t cur = 0;\n uint32_t mask = 0xffff;\n \n+ if (size == 4) {\n+ omap2_gpio_module_write(opaque, addr, value);\n+ return;\n+ }\n+\n switch (addr & ~3) {\n case 0x00:\t/* GPIO_REVISION */\n case 0x14:\t/* GPIO_SYSSTATUS */\n@@ -581,18 +587,10 @@ static void omap2_gpio_module_writep(void *opaque, hwaddr addr,\n }\n \n static const MemoryRegionOps omap2_gpio_module_ops = {\n- .old_mmio = {\n- .read = {\n- omap2_gpio_module_readp,\n- omap2_gpio_module_readp,\n- omap2_gpio_module_read,\n- },\n- .write = {\n- omap2_gpio_module_writep,\n- omap2_gpio_module_writep,\n- omap2_gpio_module_write,\n- },\n- },\n+ .read = omap2_gpio_module_readp,\n+ .write = omap2_gpio_module_writep,\n+ .valid.min_access_size = 1,\n+ .valid.max_access_size = 4,\n .endianness = DEVICE_NATIVE_ENDIAN,\n };\n \n", "prefixes": [ "2/6" ] }