Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814514/?format=api
{ "id": 814514, "url": "http://patchwork.ozlabs.org/api/patches/814514/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170916141833.28344-1-vincent@bernat.im/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170916141833.28344-1-vincent@bernat.im>", "list_archive_url": null, "date": "2017-09-16T14:18:33", "name": "[net-next,v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "395d2d46849589aa81be035463f01ec413e8beab", "submitter": { "id": 64027, "url": "http://patchwork.ozlabs.org/api/people/64027/?format=api", "name": "Vincent Bernat", "email": "vincent@bernat.im" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170916141833.28344-1-vincent@bernat.im/mbox/", "series": [ { "id": 3446, "url": "http://patchwork.ozlabs.org/api/series/3446/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3446", "date": "2017-09-16T14:18:33", "name": "[net-next,v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/3446/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814514/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814514/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=bernat.im header.i=@bernat.im\n\theader.b=\"J8qpBCCv\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvZBk0DTcz9sPk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 17 Sep 2017 00:18:54 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751290AbdIPOSt (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSat, 16 Sep 2017 10:18:49 -0400", "from bart.luffy.cx ([78.47.78.131]:57388 \"EHLO bart.luffy.cx\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751256AbdIPOSs (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tSat, 16 Sep 2017 10:18:48 -0400", "from bart.luffy.cx (localhost [127.0.0.1])\n\tby bart.luffy.cx (Postfix) with ESMTP id 35C4F1419C;\n\tSat, 16 Sep 2017 16:18:46 +0200 (CEST)", "from neo.luffy.cx (184.36.105.92.dynamic.wline.res.cust.swisscom.ch\n\t[92.105.36.184])\n\tby bart.luffy.cx (Postfix) with ESMTPS id 0CDFA1413C;\n\tSat, 16 Sep 2017 16:18:46 +0200 (CEST)", "by neo.luffy.cx (Postfix, from userid 500)\n\tid 8ED31129F; Sat, 16 Sep 2017 16:18:45 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=bernat.im; h=from:to:cc\n\t:subject:date:message-id:in-reply-to:references; s=postfix; bh=4\n\teJTWSvnK1XPNcDJnqWeU7RVVGg=; b=J8qpBCCvgZcqIP/FHrdGD3XVE5m22hJ+M\n\tOkjhnTKknUFOTthnkOC71AXDiAFlymZ+VQ6EnKoxZmxNlo1cVw7vsFQkR9mm38K4\n\tFjBqzUCAtvEtqropi9a0tSKoJa8AFMXWMf9UnWPnIYoSEmkNLN2sGGXFxI5KKsQ/\n\tUpI9ryVrF4=", "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=bernat.im; h=from:to:cc\n\t:subject:date:message-id:in-reply-to:references; q=dns; s=\n\tpostfix; b=p+ra3I5N02ChIyLavT+FfkgIffuEzxBBJ5q8EK8PlGKtV1WgG36dS\n\tEAU9w7ccoAEV+IgBlDC9RpR363GFuWdr+I9xigFkGu3BEixL2jMRyGNYSisFj9t1\n\tstErrLbGeYA719om6D0n2F5BvU/zUy7sXPTEwy/sXqduZRgih8Og30=", "From": "Vincent Bernat <vincent@bernat.im>", "To": "Stephen Hemminger <stephen@networkplumber.org>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tbridge@lists.linux-foundation.org, netdev@vger.kernel.org", "Cc": "Vincent Bernat <vincent@bernat.im>", "Subject": "[PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface\n\tis released from bridge", "Date": "Sat, 16 Sep 2017 16:18:33 +0200", "Message-Id": "<20170916141833.28344-1-vincent@bernat.im>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<m3zi9vbrfp.fsf@luffy.cx>", "References": "<m3zi9vbrfp.fsf@luffy.cx>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Currently, when an interface is released from a bridge via\nioctl(), we get a RTM_DELLINK event through netlink:\n\nDeleted 2: dummy0: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 master bridge0 state UNKNOWN\n link/ether 6e:23:c2:54:3a:b3\n\nUserspace has to interpret that as a removal from the bridge, not as a\ncomplete removal of the interface. When an bridged interface is\ncompletely removed, we get two events:\n\nDeleted 2: dummy0: <BROADCAST,NOARP> mtu 1500 master bridge0 state DOWN\n link/ether 6e:23:c2:54:3a:b3\nDeleted 2: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN group default\n link/ether 6e:23:c2:54:3a:b3 brd ff:ff:ff:ff:ff:ff\n\nIn constrast, when an interface is released from a bond, we get a\nRTM_NEWLINK with only the new characteristics (no master):\n\n3: dummy1: <BROADCAST,NOARP,SLAVE,UP,LOWER_UP> mtu 1500 qdisc noqueue master bond0 state UNKNOWN group default\n link/ether ae:dc:7a:8c:9a:3c brd ff:ff:ff:ff:ff:ff\n3: dummy1: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN group default\n link/ether ae:dc:7a:8c:9a:3c brd ff:ff:ff:ff:ff:ff\n4: bond0: <BROADCAST,MULTICAST,MASTER,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default\n link/ether ae:dc:7a:8c:9a:3c brd ff:ff:ff:ff:ff:ff\n3: dummy1: <BROADCAST,NOARP> mtu 1500 qdisc noqueue state DOWN group default\n link/ether ae:dc:7a:8c:9a:3c brd ff:ff:ff:ff:ff:ff\n3: dummy1: <BROADCAST,NOARP> mtu 1500 qdisc noqueue state DOWN group default\n link/ether ca:c8:7b:66:f8:25 brd ff:ff:ff:ff:ff:ff\n4: bond0: <BROADCAST,MULTICAST,MASTER,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default\n link/ether ae:dc:7a:8c:9a:3c brd ff:ff:ff:ff:ff:ff\n\nUserland may be confused by the fact we say a link is deleted while\nits characteristics are only modified. A first solution would have\nbeen to turn the RTM_DELLINK event in del_nbp() into a RTM_NEWLINK\nevent. However, maybe some piece of userland is relying on this\nRTM_DELLINK to detect when a bridged interface is released. Instead,\nwe also emit a RTM_NEWLINK event once the interface is\nreleased (without master info).\n\nDeleted 2: dummy0: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 master bridge0 state UNKNOWN\n link/ether 8a:bb:e7:94:b1:f8\n2: dummy0: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN group default\n link/ether 8a:bb:e7:94:b1:f8 brd ff:ff:ff:ff:ff:ff\n\nThis is done only when using ioctl(). When using Netlink, such an\nevent is already automatically emitted in do_setlink().\n\nSigned-off-by: Vincent Bernat <vincent@bernat.im>\n---\n net/bridge/br_ioctl.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/net/bridge/br_ioctl.c b/net/bridge/br_ioctl.c\nindex 7970f8540cbb..3148cb3a8e82 100644\n--- a/net/bridge/br_ioctl.c\n+++ b/net/bridge/br_ioctl.c\n@@ -99,8 +99,10 @@ static int add_del_if(struct net_bridge *br, int ifindex, int isadd)\n \n \tif (isadd)\n \t\tret = br_add_if(br, dev);\n-\telse\n+\telse {\n \t\tret = br_del_if(br, dev);\n+\t\trtmsg_ifinfo(RTM_NEWLINK, dev, IFF_MASTER, GFP_KERNEL);\n+\t}\n \n \treturn ret;\n }\n", "prefixes": [ "net-next", "v2" ] }