Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814487/?format=api
{ "id": 814487, "url": "http://patchwork.ozlabs.org/api/patches/814487/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/1505556666-3043-3-git-send-email-siddhesh@sourceware.org/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505556666-3043-3-git-send-email-siddhesh@sourceware.org>", "list_archive_url": null, "date": "2017-09-16T10:11:06", "name": "[COMMITTED,3/3] benchtests: New -g option to generate graphs in compare_strings.py", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bb1274cdb1465af0da9652860b46738008efc622", "submitter": { "id": 69197, "url": "http://patchwork.ozlabs.org/api/people/69197/?format=api", "name": "Siddhesh Poyarekar", "email": "siddhesh@sourceware.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/1505556666-3043-3-git-send-email-siddhesh@sourceware.org/mbox/", "series": [ { "id": 3428, "url": "http://patchwork.ozlabs.org/api/series/3428/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=3428", "date": "2017-09-16T10:11:04", "name": "[COMMITTED,1/3] benchtests: Use argparse to parse arguments", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3428/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814487/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814487/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-return-84664-incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list libc-alpha@sourceware.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84664-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"KSd0PsM4\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvSjT3yl4z9t2l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 16 Sep 2017 20:11:41 +1000 (AEST)", "(qmail 14404 invoked by alias); 16 Sep 2017 10:11:24 -0000", "(qmail 14299 invoked by uid 89); 16 Sep 2017 10:11:24 -0000" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=p+Ji7LF682l9JOghkJj2BAySlS1A85m\n\t77ZX7rUfzcGF2WtX9bYvVIxjNUN9WY7ETx1dV76c2P8wSNExA+yfxnmQ4jiquKEk\n\tuti6U7mofmahHs2R/UlszgkfvD0cxLqsH4IN2ibMZ5gfgPbX7wVAL2Pd74AQorCa\n\tWYx8vbczfERk=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=3IC9IFZ/6cBR1HwrUbfESMgTy0o=; b=KSd0P\n\tsM4IXhGui08JgHW5hwaHiIs+FWvOazZ+Qj2bXy6gLWTVQqW74kE8A89YnSeZP4se\n\tGI55TE6s6FseFmNfdTW9qIChOhgDv/+90WItE74e3rXxIP8SBn7hEu3Iqik3CgAA\n\tbMBrCEb5FDnmfwmk5LyTIb6Vi/ZoMxyt203X3c=", "Mailing-List": "contact libc-alpha-help@sourceware.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<libc-alpha.sourceware.org>", "List-Unsubscribe": "<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>", "List-Subscribe": "<mailto:libc-alpha-subscribe@sourceware.org>", "List-Archive": "<http://sourceware.org/ml/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>", "Sender": "libc-alpha-owner@sourceware.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-25.6 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM,\n\tSPF_NEUTRAL autolearn=ham version=3.3.2\n\tspammy=Hx-languages-length:2586", "X-HELO": "homiemail-a114.g.dreamhost.com", "From": "Siddhesh Poyarekar <siddhesh@sourceware.org>", "To": "libc-alpha@sourceware.org", "Subject": "[COMMITTED 3/3] benchtests: New -g option to generate graphs in\n\tcompare_strings.py", "Date": "Sat, 16 Sep 2017 15:41:06 +0530", "Message-Id": "<1505556666-3043-3-git-send-email-siddhesh@sourceware.org>", "In-Reply-To": "<1505556666-3043-1-git-send-email-siddhesh@sourceware.org>", "References": "<1505556666-3043-1-git-send-email-siddhesh@sourceware.org>" }, "content": "The compare_strings.py option unconditionally generates a graph PNG\nimage of the input data, which can be unnecessary and slow. Put this\nbehind an optional flag -g.\n\n\t* benchtests/scripts/compare_strings.py: New option -g.\n\t(draw_graph): Print a message that a graph is being generated.\n\t(process_results): Generate graph only if -g is passed.\n\t(main): Process option -g.\n---\n ChangeLog | 5 +++++\n benchtests/scripts/compare_strings.py | 11 ++++++++---\n 2 files changed, 13 insertions(+), 3 deletions(-)", "diff": "diff --git a/ChangeLog b/ChangeLog\nindex 20746e6..ea0b671 100644\n--- a/ChangeLog\n+++ b/ChangeLog\n@@ -1,5 +1,10 @@\n 2017-09-16 Siddhesh Poyarekar <siddhesh@sourceware.org>\n \n+\t* benchtests/scripts/compare_strings.py: New option -g.\n+\t(draw_graph): Print a message that a graph is being generated.\n+\t(process_results): Generate graph only if -g is passed.\n+\t(main): Process option -g.\n+\n \t* benchtests/scripts/compare_strings.py (process_results):\n \tBetter spacing for output.\n \ndiff --git a/benchtests/scripts/compare_strings.py b/benchtests/scripts/compare_strings.py\nindex 1f0be3b..65119ed 100755\n--- a/benchtests/scripts/compare_strings.py\n+++ b/benchtests/scripts/compare_strings.py\n@@ -57,6 +57,7 @@ def draw_graph(f, v, ifuncs, results):\n ifuncs: List of ifunc names\n results: Dictionary of results for each test criterion\n \"\"\"\n+ print('Generating graph for %s, variant \\'%s\\'' % (f, v))\n xkeys = results.keys()\n \n pylab.clf()\n@@ -78,7 +79,7 @@ def draw_graph(f, v, ifuncs, results):\n pylab.savefig('%s-%s.png' % (f, v), bbox_inches='tight')\n \n \n-def process_results(results, attrs, base_func):\n+def process_results(results, attrs, base_func, graph):\n \"\"\" Process results and print them\n \n Args:\n@@ -113,7 +114,9 @@ def process_results(results, attrs, base_func):\n sys.stdout.write('\\t')\n i = i + 1\n print('')\n- draw_graph(f, v, results['functions'][f]['ifuncs'], graph_res)\n+\n+ if graph:\n+ draw_graph(f, v, results['functions'][f]['ifuncs'], graph_res)\n \n \n def main(args):\n@@ -129,7 +132,7 @@ def main(args):\n attrs = args.attributes.split(',')\n \n results = parse_file(args.input, args.schema)\n- process_results(results, attrs, base_func)\n+ process_results(results, attrs, base_func, args.graph)\n \n \n if __name__ == '__main__':\n@@ -147,6 +150,8 @@ if __name__ == '__main__':\n # Optional arguments.\n parser.add_argument('-b', '--base',\n help='IFUNC variant to set as baseline.')\n+ parser.add_argument('-g', '--graph', action='store_true',\n+ help='Generate a graph from results.')\n \n args = parser.parse_args()\n main(args)\n", "prefixes": [ "COMMITTED", "3/3" ] }