Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814485/?format=api
{ "id": 814485, "url": "http://patchwork.ozlabs.org/api/patches/814485/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/1505556666-3043-1-git-send-email-siddhesh@sourceware.org/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505556666-3043-1-git-send-email-siddhesh@sourceware.org>", "list_archive_url": null, "date": "2017-09-16T10:11:04", "name": "[COMMITTED,1/3] benchtests: Use argparse to parse arguments", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "92cb6ee6503276190862e9db8ffd6aaa5f223a75", "submitter": { "id": 69197, "url": "http://patchwork.ozlabs.org/api/people/69197/?format=api", "name": "Siddhesh Poyarekar", "email": "siddhesh@sourceware.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/1505556666-3043-1-git-send-email-siddhesh@sourceware.org/mbox/", "series": [ { "id": 3428, "url": "http://patchwork.ozlabs.org/api/series/3428/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=3428", "date": "2017-09-16T10:11:04", "name": "[COMMITTED,1/3] benchtests: Use argparse to parse arguments", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3428/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814485/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814485/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-return-84662-incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list libc-alpha@sourceware.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84662-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"Eq+HClrd\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvSjC27dcz9t2l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 16 Sep 2017 20:11:25 +1000 (AEST)", "(qmail 13612 invoked by alias); 16 Sep 2017 10:11:19 -0000", "(qmail 13602 invoked by uid 89); 16 Sep 2017 10:11:18 -0000" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id; q=dns; s=\n\tdefault; b=byNlZ7XNScMRtPBUD+MEwRONQJgwtSR/zLvSfS29BOG8nxzVcizMZ\n\ttbzc+VucCCBAXJ4QUhFN7wYnAakXmwvyFQlm7zTc7wXjoaygrSGFV3cypo64pNFX\n\tWVyw5VVlia/qX+ru6i+NttcjUNrhvBkIIxiCgNdggu0BaLh+fPmG/I=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id; s=default;\n\tbh=Zrhc85Iu+VnXXIRStB39P3Y7EwA=; b=Eq+HClrdo47aDGyS5RZCeOSnUF4S\n\tKspmywPGPcPtDLs2i+BgjT2DlhWQDxwQOJ231IX+MJQGk2ZwW49omUi5yGd1Exzp\n\tzVpd2NXFN6ycALhGBs4Wf46u3Og+5NhNTn7GkseXzxwCuc4dYift7t2nz1rhVfCL\n\tPNgsq4pXVlnxjuc=", "Mailing-List": "contact libc-alpha-help@sourceware.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<libc-alpha.sourceware.org>", "List-Unsubscribe": "<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>", "List-Subscribe": "<mailto:libc-alpha-subscribe@sourceware.org>", "List-Archive": "<http://sourceware.org/ml/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>", "Sender": "libc-alpha-owner@sourceware.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-25.6 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM, SPF_NEUTRAL,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=", "X-HELO": "homiemail-a114.g.dreamhost.com", "From": "Siddhesh Poyarekar <siddhesh@sourceware.org>", "To": "libc-alpha@sourceware.org", "Subject": "[COMMITTED 1/3] benchtests: Use argparse to parse arguments", "Date": "Sat, 16 Sep 2017 15:41:04 +0530", "Message-Id": "<1505556666-3043-1-git-send-email-siddhesh@sourceware.org>" }, "content": "Make the script more usable by adding proper command line options\nalong with a way to query the options. The script is capable of doing\na bunch of things right now like choosing a base for comparison,\nchoosing to generate graphs, etc. and they should be accessible via\ncommand line switches.\n\n\t* benchtests/scripts/compare_strings.py: Use argparse.\n\t* benchtests/README: Document existence of compare_strings.py.\n---\n ChangeLog | 5 +++++\n benchtests/README | 11 +++++++++++\n benchtests/scripts/compare_strings.py | 35 +++++++++++++++++++++++------------\n 3 files changed, 39 insertions(+), 12 deletions(-)", "diff": "diff --git a/ChangeLog b/ChangeLog\nindex 58acb54..fd9cc0c 100644\n--- a/ChangeLog\n+++ b/ChangeLog\n@@ -1,3 +1,8 @@\n+2017-09-16 Siddhesh Poyarekar <siddhesh@sourceware.org>\n+\n+\t* benchtests/scripts/compare_strings.py: Use argparse.\n+\t* benchtests/README: Document existence of compare_strings.py.\n+\n 2017-09-15 Joseph Myers <joseph@codesourcery.com>\n \n \t* math/s_fma.c: Include <libm-alias-double.h>.\ndiff --git a/benchtests/README b/benchtests/README\nindex b015acf..9aa750a 100644\n--- a/benchtests/README\n+++ b/benchtests/README\n@@ -122,3 +122,14 @@ To add a benchset for `foo':\n - Write your bench-foo.c that prints out the measurements to stdout.\n - On execution, a bench-foo.out is created in $(objpfx) with the contents of\n stdout.\n+\n+Reading String Benchmark Results:\n+================================\n+\n+Some of the string benchmark results are now in JSON to make it easier to read\n+in scripts. Use the benchtests/compare_strings.py script to show the results\n+in a tabular format, generate graphs and more. Run\n+\n+ benchtests/scripts/compare_strings.py -h\n+\n+for usage information.\ndiff --git a/benchtests/scripts/compare_strings.py b/benchtests/scripts/compare_strings.py\nindex b3c57e2..3ca9429 100755\n--- a/benchtests/scripts/compare_strings.py\n+++ b/benchtests/scripts/compare_strings.py\n@@ -28,6 +28,7 @@ import sys\n import os\n import json\n import pylab\n+import argparse\n \n try:\n import jsonschema as validator\n@@ -118,22 +119,32 @@ def main(args):\n \n Take a string benchmark output file and compare timings.\n \"\"\"\n- if len(args) < 3:\n- print('Usage: %s <input file> <schema file> [-base=ifunc_name] attr1 [attr2 ...]' % sys.argv[0])\n- sys.exit(os.EX_USAGE)\n \n base_func = None\n- filename = args[0]\n- schema_filename = args[1]\n- if args[2].find('-base=') == 0:\n- base_func = args[2][6:]\n- attrs = args[3:]\n- else:\n- attrs = args[2:]\n+ filename = args.input\n+ schema_filename = args.schema\n+ base_func = args.base\n+ attrs = args.attributes.split(',')\n \n- results = parse_file(filename, schema_filename)\n+ results = parse_file(args.input, args.schema)\n process_results(results, attrs, base_func)\n \n \n if __name__ == '__main__':\n- main(sys.argv[1:])\n+ parser = argparse.ArgumentParser()\n+\n+ # The required arguments.\n+ req = parser.add_argument_group(title='required arguments')\n+ req.add_argument('-a', '--attributes', required=True,\n+ help='Comma separated list of benchmark attributes.')\n+ req.add_argument('-i', '--input', required=True,\n+ help='Input JSON benchmark result file.')\n+ req.add_argument('-s', '--schema', required=True,\n+ help='Schema file to validate the result file.')\n+\n+ # Optional arguments.\n+ parser.add_argument('-b', '--base',\n+ help='IFUNC variant to set as baseline.')\n+\n+ args = parser.parse_args()\n+ main(args)\n", "prefixes": [ "COMMITTED", "1/3" ] }