Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814440/?format=api
{ "id": 814440, "url": "http://patchwork.ozlabs.org/api/patches/814440/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-16-ehabkost@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170915233739.26860-16-ehabkost@redhat.com>", "list_archive_url": null, "date": "2017-09-15T23:37:39", "name": "[PULL,15/15] qemu.py: include debug information on launch error", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "026e543589989e1e0f45f4571578154d1be890c5", "submitter": { "id": 195, "url": "http://patchwork.ozlabs.org/api/people/195/?format=api", "name": "Eduardo Habkost", "email": "ehabkost@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-16-ehabkost@redhat.com/mbox/", "series": [ { "id": 3400, "url": "http://patchwork.ozlabs.org/api/series/3400/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3400", "date": "2017-09-15T23:37:24", "name": "[PULL,01/15] qemu.py: Pylint/style fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3400/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814440/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814440/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvBxv6Xmfz9sNc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 16 Sep 2017 09:51:31 +1000 (AEST)", "from localhost ([::1]:55409 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dt0OQ-0006lq-23\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 19:51:30 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:56786)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <ehabkost@redhat.com>) id 1dt0CN-0005tE-Bq\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:39:04 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <ehabkost@redhat.com>) id 1dt0CK-0003jn-9z\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:39:03 -0400", "from mx1.redhat.com ([209.132.183.28]:53702)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <ehabkost@redhat.com>) id 1dt0CK-0003gA-4T\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:39:00 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3883C356E3;\n\tFri, 15 Sep 2017 23:38:59 +0000 (UTC)", "from localhost (ovpn-116-24.gru2.redhat.com [10.97.116.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 50CE9675C0;\n\tFri, 15 Sep 2017 23:38:54 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 3883C356E3", "From": "Eduardo Habkost <ehabkost@redhat.com>", "To": "Peter Maydell <peter.maydell@linaro.org>,\n\tqemu-devel@nongnu.org", "Date": "Fri, 15 Sep 2017 20:37:39 -0300", "Message-Id": "<20170915233739.26860-16-ehabkost@redhat.com>", "In-Reply-To": "<20170915233739.26860-1-ehabkost@redhat.com>", "References": "<20170915233739.26860-1-ehabkost@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 15 Sep 2017 23:38:59 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 15/15] qemu.py: include debug information on\n\tlaunch error", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= <ldoktor@redhat.com>,\n\tAmador Pahim <apahim@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Amador Pahim <apahim@redhat.com>\n\nWhen launching a VM, if an exception happens and the VM is not\ninitiated, it might be useful to see the qemu command line and\nthe qemu command output.\n\nThis patch creates that message. Notice that self._iolog needs to be\ncleaned up in the beginning of the launch() to make sure we will not\nexpose the qemu log from a previous launch if the current one fails.\n\nSigned-off-by: Amador Pahim <apahim@redhat.com>\nMessage-Id: <20170901112829.2571-6-apahim@redhat.com>\nReviewed-by: Fam Zheng <famz@redhat.com>\nSigned-off-by: Eduardo Habkost <ehabkost@redhat.com>\n---\n scripts/qemu.py | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/scripts/qemu.py b/scripts/qemu.py\nindex 9440261ac3..8c67595ec8 100644\n--- a/scripts/qemu.py\n+++ b/scripts/qemu.py\n@@ -187,6 +187,7 @@ class QEMUMachine(object):\n \n def launch(self):\n '''Launch the VM and establish a QMP connection'''\n+ self._iolog = None\n self._qemu_full_args = None\n devnull = open(os.path.devnull, 'rb')\n qemulog = open(self._qemu_log_path, 'wb')\n@@ -206,6 +207,12 @@ class QEMUMachine(object):\n self._popen.wait()\n self._load_io_log()\n self._post_shutdown()\n+\n+ LOG.debug('Error launching VM')\n+ if self._qemu_full_args:\n+ LOG.debug('Command: %r', ' '.join(self._qemu_full_args))\n+ if self._iolog:\n+ LOG.debug('Output: %r', self._iolog)\n raise\n \n def shutdown(self):\n", "prefixes": [ "PULL", "15/15" ] }