Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814427/?format=api
{ "id": 814427, "url": "http://patchwork.ozlabs.org/api/patches/814427/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-3-ehabkost@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170915233739.26860-3-ehabkost@redhat.com>", "list_archive_url": null, "date": "2017-09-15T23:37:26", "name": "[PULL,02/15] qemu|qtest: Avoid dangerous arguments", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "afcc1e34de7e3b7f18c8e72d7326b10ee1c7217c", "submitter": { "id": 195, "url": "http://patchwork.ozlabs.org/api/people/195/?format=api", "name": "Eduardo Habkost", "email": "ehabkost@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915233739.26860-3-ehabkost@redhat.com/mbox/", "series": [ { "id": 3400, "url": "http://patchwork.ozlabs.org/api/series/3400/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3400", "date": "2017-09-15T23:37:24", "name": "[PULL,01/15] qemu.py: Pylint/style fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3400/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814427/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814427/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvBhM0Dw4z9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 16 Sep 2017 09:39:47 +1000 (AEST)", "from localhost ([::1]:55353 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dt0D3-0005pp-3M\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 19:39:45 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:56158)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <ehabkost@redhat.com>) id 1dt0BI-0004t0-Lu\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:37:59 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <ehabkost@redhat.com>) id 1dt0BH-0001CB-LY\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:37:56 -0400", "from mx1.redhat.com ([209.132.183.28]:57274)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <ehabkost@redhat.com>) id 1dt0BH-0001Bu-G8\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 19:37:55 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7242B5F7B1;\n\tFri, 15 Sep 2017 23:37:54 +0000 (UTC)", "from localhost (ovpn-116-24.gru2.redhat.com [10.97.116.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 055C3614C5;\n\tFri, 15 Sep 2017 23:37:53 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 7242B5F7B1", "From": "Eduardo Habkost <ehabkost@redhat.com>", "To": "Peter Maydell <peter.maydell@linaro.org>,\n\tqemu-devel@nongnu.org", "Date": "Fri, 15 Sep 2017 20:37:26 -0300", "Message-Id": "<20170915233739.26860-3-ehabkost@redhat.com>", "In-Reply-To": "<20170915233739.26860-1-ehabkost@redhat.com>", "References": "<20170915233739.26860-1-ehabkost@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 15 Sep 2017 23:37:54 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 02/15] qemu|qtest: Avoid dangerous arguments", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= <ldoktor@redhat.com>,\n\tAmador Pahim <apahim@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Lukáš Doktor <ldoktor@redhat.com>\n\nThe list object is mutable in python and potentially might modify other\nobject's arguments when used as default argument. Reproducer:\n\n >>> vm1 = QEMUMachine(\"qemu\")\n >>> vm2 = QEMUMachine(\"qemu\")\n >>> vm1._wrapper.append(\"foo\")\n >>> print vm2._wrapper\n ['foo']\n\nIn this case the `args` is actually copied so it would be safe to keep\nit, but it's not a good practice to keep it. The same issue applies in\ninherited qtest module.\n\nSigned-off-by: Lukáš Doktor <ldoktor@redhat.com>\nReviewed-by: Eduardo Habkost <ehabkost@redhat.com>\nReviewed-by: John Snow <jsnow@redhat.com>\nMessage-Id: <20170818142613.32394-3-ldoktor@redhat.com>\nReviewed-by: Cleber Rosa <crosa@redhat.com>\nSigned-off-by: Eduardo Habkost <ehabkost@redhat.com>\n---\n scripts/qemu.py | 6 +++++-\n scripts/qtest.py | 2 +-\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/scripts/qemu.py b/scripts/qemu.py\nindex b45e691538..afd98a290e 100644\n--- a/scripts/qemu.py\n+++ b/scripts/qemu.py\n@@ -30,7 +30,7 @@ class QEMUMachine(object):\n # vm is guaranteed to be shut down here\n '''\n \n- def __init__(self, binary, args=[], wrapper=[], name=None,\n+ def __init__(self, binary, args=None, wrapper=None, name=None,\n test_dir=\"/var/tmp\", monitor_address=None,\n socket_scm_helper=None, debug=False):\n '''\n@@ -46,6 +46,10 @@ class QEMUMachine(object):\n @param debug: enable debug mode\n @note: Qemu process is not started until launch() is used.\n '''\n+ if args is None:\n+ args = []\n+ if wrapper is None:\n+ wrapper = []\n if name is None:\n name = \"qemu-%d\" % os.getpid()\n if monitor_address is None:\ndiff --git a/scripts/qtest.py b/scripts/qtest.py\nindex d5aecb5f49..ab183c0635 100644\n--- a/scripts/qtest.py\n+++ b/scripts/qtest.py\n@@ -79,7 +79,7 @@ class QEMUQtestProtocol(object):\n class QEMUQtestMachine(qemu.QEMUMachine):\n '''A QEMU VM'''\n \n- def __init__(self, binary, args=[], name=None, test_dir=\"/var/tmp\",\n+ def __init__(self, binary, args=None, name=None, test_dir=\"/var/tmp\",\n socket_scm_helper=None):\n if name is None:\n name = \"qemu-%d\" % os.getpid()\n", "prefixes": [ "PULL", "02/15" ] }