Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814401/?format=api
{ "id": 814401, "url": "http://patchwork.ozlabs.org/api/patches/814401/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/8e370fcae8a6b2dd476f089ddfe2945ffb1f7490.1505508423.git.srishtishar@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<8e370fcae8a6b2dd476f089ddfe2945ffb1f7490.1505508423.git.srishtishar@gmail.com>", "list_archive_url": null, "date": "2017-09-15T21:05:47", "name": "[1/2] Staging: irda: Don't use assignment inside if statement", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": true, "hash": "2de44309031ca7c520f9df5761a9265043a16b46", "submitter": { "id": 72376, "url": "http://patchwork.ozlabs.org/api/people/72376/?format=api", "name": "Srishti Sharma", "email": "srishtishar@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/8e370fcae8a6b2dd476f089ddfe2945ffb1f7490.1505508423.git.srishtishar@gmail.com/mbox/", "series": [ { "id": 3385, "url": "http://patchwork.ozlabs.org/api/series/3385/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3385", "date": "2017-09-15T21:05:24", "name": "Assign outside if", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3385/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814401/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814401/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"j9rFB+mY\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv7H16zFRz9s3w\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 16 Sep 2017 07:06:05 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751881AbdIOVFy (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 15 Sep 2017 17:05:54 -0400", "from mail-pg0-f68.google.com ([74.125.83.68]:34742 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751568AbdIOVFx (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 15 Sep 2017 17:05:53 -0400", "by mail-pg0-f68.google.com with SMTP id v82so1882624pgb.1;\n\tFri, 15 Sep 2017 14:05:53 -0700 (PDT)", "from srishti-PRODiiGY-945G ([122.168.202.126])\n\tby smtp.gmail.com with ESMTPSA id\n\tt65sm3774234pfk.59.2017.09.15.14.05.51\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 15 Sep 2017 14:05:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=vQJL2Luijpx0nVGlvcr5jdqOrtFX1Gurj2p2efq11pw=;\n\tb=j9rFB+mYqJ4BDo9jHV/DPQK8pIa3qKW+SqOK4yLhEJ7VPnWk/CTtp2NPEgVCwVHhb4\n\thDwePSn9+bY8pjN7bl3A+5uvHlowPGQAhCHNCWsR3eZH8xDCMJ+mmXuCJgl7YFPTDcca\n\tim37E95x/KFoGh2TyW3Ylesv8QyD+mSao3vn2buweml5y5JHVcOBxemDP9BrbDzQ18Cm\n\t1X/ov43SjdbnJuB+fDkhMW66/19wIh+elHsxOIpiFPuKF3YHiLs6ZinDOy53QFuKY2Ny\n\t9kjt7BNNONb6pC7G+pg2J1RlOuTk7MXe4mYNknrxT38qci0uYR8Uy52AfOpxb+ddSn/X\n\tCtwA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=vQJL2Luijpx0nVGlvcr5jdqOrtFX1Gurj2p2efq11pw=;\n\tb=T60qGd4gOOJC/yMianJkAQ+hhHlrNx8QvyV1FHudLEq2U8j75QCyl8Wn2xZ01g5gh5\n\taidC+xM6RqvUHhTVWeINhG7JW72oH0IoRYzsW/A76Dt8Pll5WDPbvZk8AMVj2Ir8sMIz\n\thFNjn2Wh6GcAGFuC0iKmpLfVfQCw2lYSbjoQ/uXDXYWkPMHY43YfZqk8tuGUrfKAs7tm\n\t4vjpEYgrGEWU0ClwS0aZy++ODpiqOtQdHNWF1eNTl/Odjdbs0cH6/fzksYwT2yQK8Xev\n\tkoURr5+0nJkdklT+6VQSVmECjpoLnFCmyXu/lToD2t6BhJH1bj3w4tOn151TgwRwa5n6\n\tMx8A==", "X-Gm-Message-State": "AHPjjUiBSy16XwFwZCjbDxYUoFTh1W2uW+btVN2wN4zZnZk9vzd8feOR\n\tY6jcI97gnUDkig==", "X-Google-Smtp-Source": "ADKCNb7ObT06HNWvkbFwFo/Qzxmezw5lOYBfdwRkZd80vVxIJl27RSfvnOHyDIhNjWN8/cnVAZ5+vA==", "X-Received": "by 10.84.225.130 with SMTP id u2mr29615785plj.44.1505509553144; \n\tFri, 15 Sep 2017 14:05:53 -0700 (PDT)", "From": "Srishti Sharma <srishtishar@gmail.com>", "To": "samuel@sortiz.org", "Cc": "gregkh@linuxfoundation.org, netdev@vger.kernel.org,\n\tdevel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,\n\toutreachy-kernel@googlegroups.com, Srishti Sharma <srishtishar@gmail.com>", "Subject": "[PATCH 1/2] Staging: irda: Don't use assignment inside if statement", "Date": "Sat, 16 Sep 2017 02:35:47 +0530", "Message-Id": "<8e370fcae8a6b2dd476f089ddfe2945ffb1f7490.1505508423.git.srishtishar@gmail.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<cover.1505508423.git.srishtishar@gmail.com>", "References": "<cover.1505508423.git.srishtishar@gmail.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Write assignment statement outside of the if statement. Done\nusing the following semantic patch by coccinelle.\n\n@@\nidentifier E;\nexpression F;\nstatement S;\n@@\n\n-if((E = F))\n+E = F;\n+if(E)\n S\n\nSigned-off-by: Srishti Sharma <srishtishar@gmail.com>\n---\n drivers/staging/irda/drivers/irda-usb.c | 4 ++--\n drivers/staging/irda/drivers/mcs7780.c | 9 ++++++---\n drivers/staging/irda/net/irqueue.c | 3 ++-\n 3 files changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/staging/irda/drivers/irda-usb.c b/drivers/staging/irda/drivers/irda-usb.c\nindex 723e49b..82bfc05 100644\n--- a/drivers/staging/irda/drivers/irda-usb.c\n+++ b/drivers/staging/irda/drivers/irda-usb.c\n@@ -334,9 +334,9 @@ static void irda_usb_change_speed_xbofs(struct irda_usb_cb *self)\n \turb->transfer_flags = 0;\n \n \t/* Irq disabled -> GFP_ATOMIC */\n-\tif ((ret = usb_submit_urb(urb, GFP_ATOMIC))) {\n+\tret = usb_submit_urb(urb, GFP_ATOMIC);\n+\tif (ret)\n \t\tnet_warn_ratelimited(\"%s(), failed Speed URB\\n\", __func__);\n-\t}\n }\n \n /*------------------------------------------------------------------*/\ndiff --git a/drivers/staging/irda/drivers/mcs7780.c b/drivers/staging/irda/drivers/mcs7780.c\nindex c3f0b25..2b674d5 100644\n--- a/drivers/staging/irda/drivers/mcs7780.c\n+++ b/drivers/staging/irda/drivers/mcs7780.c\n@@ -605,19 +605,22 @@ static int mcs_speed_change(struct mcs_cb *mcs)\n \tif (mcs->new_speed <= 115200) {\n \t\trval &= ~MCS_FIR;\n \n-\t\tif ((rst = (mcs->speed > 115200)))\n+\t\trst = (mcs->speed > 115200);\n+\t\tif (rst)\n \t\t\tmcs_set_reg(mcs, MCS_MINRXPW_REG, 0);\n \n \t} else if (mcs->new_speed <= 1152000) {\n \t\trval &= ~MCS_FIR;\n \n-\t\tif ((rst = !(mcs->speed == 576000 || mcs->speed == 1152000)))\n+\t\trst = !(mcs->speed == 576000 || mcs->speed == 1152000);\n+\t\tif (rst)\n \t\t\tmcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n \n \t} else {\n \t\trval |= MCS_FIR;\n \n-\t\tif ((rst = (mcs->speed != 4000000)))\n+\t\trst = (mcs->speed != 4000000);\n+\t\tif (rst)\n \t\t\tmcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n \n \t}\ndiff --git a/drivers/staging/irda/net/irqueue.c b/drivers/staging/irda/net/irqueue.c\nindex 160dc89..5aab072 100644\n--- a/drivers/staging/irda/net/irqueue.c\n+++ b/drivers/staging/irda/net/irqueue.c\n@@ -217,7 +217,8 @@ static __u32 hash( const char* name)\n \n \twhile(*name) {\n \t\th = (h<<4) + *name++;\n-\t\tif ((g = (h & 0xf0000000)))\n+\t\tg = (h & 0xf0000000);\n+\t\tif (g)\n \t\t\th ^=g>>24;\n \t\th &=~g;\n \t}\n", "prefixes": [ "1/2" ] }