Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814201/?format=api
{ "id": 814201, "url": "http://patchwork.ozlabs.org/api/patches/814201/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915101406.27823-2-cohuck@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170915101406.27823-2-cohuck@redhat.com>", "list_archive_url": null, "date": "2017-09-15T10:14:06", "name": "[RFC,1/1] s390x/ccw: create s390 phb for compat reasons as well", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a7b22df7e48678bf8c60172b743135a7bf3623e3", "submitter": { "id": 71914, "url": "http://patchwork.ozlabs.org/api/people/71914/?format=api", "name": "Cornelia Huck", "email": "cohuck@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915101406.27823-2-cohuck@redhat.com/mbox/", "series": [ { "id": 3265, "url": "http://patchwork.ozlabs.org/api/series/3265/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3265", "date": "2017-09-15T10:14:05", "name": "s390x: pci compat handling", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3265/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814201/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814201/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtrwb14KVz9sxR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 20:19:11 +1000 (AEST)", "from localhost ([::1]:52374 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dsniH-0001dS-7k\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 06:19:09 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:38524)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dsndc-0006LE-ML\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 06:14:25 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dsndb-0008Tx-Mv\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 06:14:20 -0400", "from mx1.redhat.com ([209.132.183.28]:42276)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cohuck@redhat.com>) id 1dsndb-0008T7-Es\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 06:14:19 -0400", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 82DAE821C1;\n\tFri, 15 Sep 2017 10:14:18 +0000 (UTC)", "from localhost (ovpn-117-60.ams2.redhat.com [10.36.117.60])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 676DF6375D;\n\tFri, 15 Sep 2017 10:14:15 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 82DAE821C1", "From": "Cornelia Huck <cohuck@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 15 Sep 2017 12:14:06 +0200", "Message-Id": "<20170915101406.27823-2-cohuck@redhat.com>", "In-Reply-To": "<20170915101406.27823-1-cohuck@redhat.com>", "References": "<20170915101406.27823-1-cohuck@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tFri, 15 Sep 2017 10:14:18 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat\n\treasons as well", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "thuth@redhat.com, zyimin@linux.vnet.ibm.com, david@redhat.com,\n\tCornelia Huck <cohuck@redhat.com>, pmorel@linux.vnet.ibm.com,\n\tagraf@suse.de, borntraeger@de.ibm.com, pasic@linux.vnet.ibm.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "d32bd032d8 (\"s390x/ccw: create s390 phb conditionally\") made\nregistering the s390 pci host bridge conditional on presense\nof the zpci facility bit. Sadly, that breaks migration from\nsome old machines.\n\nCreate the s390 phb if we need it for compat reasons, even if\nwe don't provide the zpci facility.\n\nFixes: d32bd032d8 (\"s390x/ccw: create s390 phb conditionally\")\nSigned-off-by: Cornelia Huck <cohuck@redhat.com>\n---\n hw/s390x/s390-virtio-ccw.c | 6 +++++-\n include/hw/s390x/s390-virtio-ccw.h | 1 +\n 2 files changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\nindex 0471407187..7e3148eb4a 100644\n--- a/hw/s390x/s390-virtio-ccw.c\n+++ b/hw/s390x/s390-virtio-ccw.c\n@@ -269,6 +269,8 @@ static void s390_create_virtio_net(BusState *bus, const char *name)\n }\n }\n \n+static S390CcwMachineClass *get_machine_class(void);\n+\n static void ccw_init(MachineState *machine)\n {\n int ret;\n@@ -288,7 +290,7 @@ static void ccw_init(MachineState *machine)\n machine->initrd_filename, \"s390-ccw.img\",\n \"s390-netboot.img\", true);\n \n- if (s390_has_feat(S390_FEAT_ZPCI)) {\n+ if (s390_has_feat(S390_FEAT_ZPCI) || get_machine_class()->pci_compat) {\n DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);\n object_property_add_child(qdev_get_machine(),\n TYPE_S390_PCI_HOST_BRIDGE,\n@@ -429,6 +431,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)\n s390mc->cpu_model_allowed = true;\n s390mc->css_migration_enabled = true;\n s390mc->gs_allowed = true;\n+ s390mc->pci_compat = false;\n mc->init = ccw_init;\n mc->reset = s390_machine_reset;\n mc->hot_add_cpu = s390_hot_add_cpu;\n@@ -784,6 +787,7 @@ static void ccw_machine_2_7_class_options(MachineClass *mc)\n S390CcwMachineClass *s390mc = S390_MACHINE_CLASS(mc);\n \n s390mc->cpu_model_allowed = false;\n+ s390mc->pci_compat = pci_available;\n ccw_machine_2_8_class_options(mc);\n SET_MACHINE_COMPAT(mc, CCW_COMPAT_2_7);\n }\ndiff --git a/include/hw/s390x/s390-virtio-ccw.h b/include/hw/s390x/s390-virtio-ccw.h\nindex a9a90c2022..9978c89e90 100644\n--- a/include/hw/s390x/s390-virtio-ccw.h\n+++ b/include/hw/s390x/s390-virtio-ccw.h\n@@ -41,6 +41,7 @@ typedef struct S390CcwMachineClass {\n bool cpu_model_allowed;\n bool css_migration_enabled;\n bool gs_allowed;\n+ bool pci_compat;\n } S390CcwMachineClass;\n \n /* runtime-instrumentation allowed by the machine */\n", "prefixes": [ "RFC", "1/1" ] }