Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814194/?format=api
{ "id": 814194, "url": "http://patchwork.ozlabs.org/api/patches/814194/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915101008.16646-2-kwolf@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170915101008.16646-2-kwolf@redhat.com>", "list_archive_url": null, "date": "2017-09-15T10:10:03", "name": "[1/6] qemu-io: Reset qemuio_blk permissions before each command", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "32902835d8b6079e04f3ab16f91199e226872949", "submitter": { "id": 2714, "url": "http://patchwork.ozlabs.org/api/people/2714/?format=api", "name": "Kevin Wolf", "email": "kwolf@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915101008.16646-2-kwolf@redhat.com/mbox/", "series": [ { "id": 3264, "url": "http://patchwork.ozlabs.org/api/series/3264/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3264", "date": "2017-09-15T10:10:02", "name": "block: Fix permissions after ro/rw reopen", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3264/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814194/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814194/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtrlc2TLRz9t2V\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 20:11:22 +1000 (AEST)", "from localhost ([::1]:52341 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dsnah-0002Ki-Ih\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 06:11:19 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:37253)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <kwolf@redhat.com>) id 1dsnZo-00026L-Ib\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 06:10:25 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <kwolf@redhat.com>) id 1dsnZn-0004I8-By\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 06:10:24 -0400", "from mx1.redhat.com ([209.132.183.28]:38644)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <kwolf@redhat.com>)\n\tid 1dsnZh-0004Au-KY; Fri, 15 Sep 2017 06:10:17 -0400", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id AAB2281E02;\n\tFri, 15 Sep 2017 10:10:16 +0000 (UTC)", "from localhost.localdomain.com (ovpn-117-157.ams2.redhat.com\n\t[10.36.117.157])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6EC4966D5F;\n\tFri, 15 Sep 2017 10:10:15 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com AAB2281E02", "From": "Kevin Wolf <kwolf@redhat.com>", "To": "qemu-block@nongnu.org", "Date": "Fri, 15 Sep 2017 12:10:03 +0200", "Message-Id": "<20170915101008.16646-2-kwolf@redhat.com>", "In-Reply-To": "<20170915101008.16646-1-kwolf@redhat.com>", "References": "<20170915101008.16646-1-kwolf@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 15 Sep 2017 10:10:16 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH 1/6] qemu-io: Reset qemuio_blk permissions\n\tbefore each command", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,\n\tmreitz@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "qemu-io provides a 'reopen' command that allows switching from writable\nto read-only access. We need to make sure that we don't try to keep\nwrite permissions to a BlockBackend that becomes read-only, otherwise\nthings are going to fail.\n\ncommand() already makes sure to request any additional permissions that\na qemu-io command requires, so just resetting the permissions to values\nthat are safe for read-only images is enough to fix this.\n\nAs a side effect, this makes the output of qemu-iotests case 187 more\nconsistent.\n\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>\n---\n qemu-io.c | 13 +++++++++++++\n tests/qemu-iotests/187.out | 2 +-\n 2 files changed, 14 insertions(+), 1 deletion(-)", "diff": "diff --git a/qemu-io.c b/qemu-io.c\nindex 265445ad89..9e031f0f8e 100644\n--- a/qemu-io.c\n+++ b/qemu-io.c\n@@ -366,6 +366,12 @@ static void command_loop(void)\n char *input;\n \n for (i = 0; !done && i < ncmdline; i++) {\n+ /* Make sure that we start each command with clean permissions and only\n+ * add whatever the specific cmdinfo_t describes */\n+ if (qemuio_blk) {\n+ blk_set_perm(qemuio_blk, BLK_PERM_CONSISTENT_READ, BLK_PERM_ALL,\n+ &error_abort);\n+ }\n done = qemuio_command(qemuio_blk, cmdline[i]);\n }\n if (cmdline) {\n@@ -391,6 +397,13 @@ static void command_loop(void)\n if (input == NULL) {\n break;\n }\n+\n+ /* Make sure that we start each command with clean permissions and only\n+ * add whatever the specific cmdinfo_t describes */\n+ if (qemuio_blk) {\n+ blk_set_perm(qemuio_blk, BLK_PERM_CONSISTENT_READ, BLK_PERM_ALL,\n+ &error_abort);\n+ }\n done = qemuio_command(qemuio_blk, input);\n g_free(input);\n \ndiff --git a/tests/qemu-iotests/187.out b/tests/qemu-iotests/187.out\nindex 68fb944cd5..30b987f71f 100644\n--- a/tests/qemu-iotests/187.out\n+++ b/tests/qemu-iotests/187.out\n@@ -12,7 +12,7 @@ Start from read-write\n \n wrote 65536/65536 bytes at offset 0\n 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n-write failed: Operation not permitted\n+Block node is read-only\n wrote 65536/65536 bytes at offset 0\n 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n *** done\n", "prefixes": [ "1/6" ] }