Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814156/?format=api
{ "id": 814156, "url": "http://patchwork.ozlabs.org/api/patches/814156/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915084030.40988-3-aik@ozlabs.ru/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170915084030.40988-3-aik@ozlabs.ru>", "list_archive_url": null, "date": "2017-09-15T08:40:19", "name": "[qemu,v2,02/13] exec: Explicitely export target AS from address_space_translate_internal", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5bba44e7820739ec2cc28a405663289ea8a1bb70", "submitter": { "id": 7621, "url": "http://patchwork.ozlabs.org/api/people/7621/?format=api", "name": "Alexey Kardashevskiy", "email": "aik@ozlabs.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170915084030.40988-3-aik@ozlabs.ru/mbox/", "series": [ { "id": 3250, "url": "http://patchwork.ozlabs.org/api/series/3250/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3250", "date": "2017-09-15T08:40:21", "name": "memory: Reduce memory use", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/3250/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814156/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814156/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtpsn3wRqz9sPr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 18:46:37 +1000 (AEST)", "from localhost ([::1]:51978 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dsmGh-0004Hb-II\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 04:46:35 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:38391)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aik@ozlabs.ru>) id 1dsmBQ-0007Gf-PV\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:41:09 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <aik@ozlabs.ru>) id 1dsmBP-0002e3-MV\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:41:08 -0400", "from ozlabs.ru ([107.173.13.209]:45004)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aik@ozlabs.ru>) id 1dsmBP-0002dp-F9\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:41:07 -0400", "from vpl1.ozlabs.ibm.com (localhost [IPv6:::1])\n\tby ozlabs.ru (Postfix) with ESMTP id 839873A60042;\n\tFri, 15 Sep 2017 04:41:50 -0400 (EDT)" ], "From": "Alexey Kardashevskiy <aik@ozlabs.ru>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 15 Sep 2017 18:40:19 +1000", "Message-Id": "<20170915084030.40988-3-aik@ozlabs.ru>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170915084030.40988-1-aik@ozlabs.ru>", "References": "<20170915084030.40988-1-aik@ozlabs.ru>", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "107.173.13.209", "Subject": "[Qemu-devel] [PATCH qemu v2 02/13] exec: Explicitely export target\n\tAS from address_space_translate_internal", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Alexey Kardashevskiy <aik@ozlabs.ru>, Paolo Bonzini <pbonzini@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "This is not so mechanical change in order to move to shared FlatViews\nso make it a separate patch. The first argument of\naddress_space_do_translate() will become a FlatView, however since\naddress_space_get_iotlb_entry() still wants AS, hence this change.\n\nSigned-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>\n---\n exec.c | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/exec.c b/exec.c\nindex d20c34ca83..bd94248390 100644\n--- a/exec.c\n+++ b/exec.c\n@@ -477,7 +477,8 @@ static MemoryRegionSection address_space_do_translate(AddressSpace *as,\n hwaddr *xlat,\n hwaddr *plen,\n bool is_write,\n- bool is_mmio)\n+ bool is_mmio,\n+ AddressSpace **target_as)\n {\n IOMMUTLBEntry iotlb;\n MemoryRegionSection *section;\n@@ -504,6 +505,7 @@ static MemoryRegionSection address_space_do_translate(AddressSpace *as,\n }\n \n as = iotlb.target_as;\n+ *target_as = iotlb.target_as;\n }\n \n *xlat = addr;\n@@ -526,7 +528,7 @@ IOMMUTLBEntry address_space_get_iotlb_entry(AddressSpace *as, hwaddr addr,\n \n /* This can never be MMIO. */\n section = address_space_do_translate(as, addr, &xlat, &plen,\n- is_write, false);\n+ is_write, false, &as);\n \n /* Illegal translation */\n if (section.mr == &io_mem_unassigned) {\n@@ -549,7 +551,7 @@ IOMMUTLBEntry address_space_get_iotlb_entry(AddressSpace *as, hwaddr addr,\n plen -= 1;\n \n return (IOMMUTLBEntry) {\n- .target_as = section.address_space,\n+ .target_as = as,\n .iova = addr & ~plen,\n .translated_addr = xlat & ~plen,\n .addr_mask = plen,\n@@ -570,7 +572,8 @@ MemoryRegion *address_space_translate(AddressSpace *as, hwaddr addr,\n MemoryRegionSection section;\n \n /* This can be MMIO, so setup MMIO bit. */\n- section = address_space_do_translate(as, addr, xlat, plen, is_write, true);\n+ section = address_space_do_translate(as, addr, xlat, plen, is_write, true,\n+ &as);\n mr = section.mr;\n \n if (xen_enabled() && memory_access_is_direct(mr, is_write)) {\n", "prefixes": [ "qemu", "v2", "02/13" ] }