Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814112/?format=api
{ "id": 814112, "url": "http://patchwork.ozlabs.org/api/patches/814112/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/1505460876-7303-7-git-send-email-akshay.adiga@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505460876-7303-7-git-send-email-akshay.adiga@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-09-15T07:34:34", "name": "[v4,6/8] SLW: Allow deep states if homer address is known", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "911b08c9717f530d7d0d9021e332f17568dfd398", "submitter": { "id": 68766, "url": "http://patchwork.ozlabs.org/api/people/68766/?format=api", "name": "Akshay Adiga", "email": "akshay.adiga@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/1505460876-7303-7-git-send-email-akshay.adiga@linux.vnet.ibm.com/mbox/", "series": [ { "id": 3238, "url": "http://patchwork.ozlabs.org/api/series/3238/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/list/?series=3238", "date": "2017-09-15T07:34:28", "name": "Enable stop4 idle state", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/3238/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814112/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814112/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtnJn18h4z9sPs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 17:36:25 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xtnJn0GhDzDrvR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 17:36:25 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xtnHX3HRXzDrZx\n\tfor <skiboot@lists.ozlabs.org>; Fri, 15 Sep 2017 17:35:20 +1000 (AEST)", "from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8F7Xjt7012728\n\tfor <skiboot@lists.ozlabs.org>; Fri, 15 Sep 2017 03:35:17 -0400", "from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d05x1c4hu-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Fri, 15 Sep 2017 03:35:17 -0400", "from localhost\n\tby e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <akshay.adiga@linux.vnet.ibm.com>;\n\tFri, 15 Sep 2017 17:35:14 +1000", "from d23relay08.au.ibm.com (202.81.31.227)\n\tby e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 15 Sep 2017 17:35:12 +1000", "from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])\n\tby d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8F7ZBJY39059668\n\tfor <skiboot@lists.ozlabs.org>; Fri, 15 Sep 2017 17:35:11 +1000", "from d23av03.au.ibm.com (localhost [127.0.0.1])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8F7Z45Y027529\n\tfor <skiboot@lists.ozlabs.org>; Fri, 15 Sep 2017 17:35:04 +1000", "from aksadiga.ibm ([9.79.223.131])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8F7YZ5J026751; Fri, 15 Sep 2017 17:35:00 +1000" ], "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=akshay.adiga@linux.vnet.ibm.com; receiver=<UNKNOWN>)", "From": "Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Fri, 15 Sep 2017 13:04:34 +0530", "X-Mailer": "git-send-email 2.5.5", "In-Reply-To": "<1505460876-7303-1-git-send-email-akshay.adiga@linux.vnet.ibm.com>", "References": "<1505460876-7303-1-git-send-email-akshay.adiga@linux.vnet.ibm.com>", "X-TM-AS-MML": "disable", "x-cbid": "17091507-0048-0000-0000-0000025D1859", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17091507-0049-0000-0000-000048138565", "Message-Id": "<1505460876-7303-7-git-send-email-akshay.adiga@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-15_02:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709150113", "Subject": "[Skiboot] [PATCH v4 6/8] SLW: Allow deep states if homer address is\n\tknown", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "Cc": "ego@linux.vnet.ibm.com, shriyak@linux.vnet.ibm.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Use a common variable has_wakeup_engine instead of has_slw to tell if\nthe\na) SLW image is populated in case of power8\nb) CME image is populated in case of power9\n\nCurrently we expect CME to be loaded if homer address is known ( except\nfor simulators)\n\nSigned-off-by: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>\n---\n hw/slw.c | 23 +++++++++++++++++------\n 1 file changed, 17 insertions(+), 6 deletions(-)", "diff": "diff --git a/hw/slw.c b/hw/slw.c\nindex 39aa4d0..1ce7608 100644\n--- a/hw/slw.c\n+++ b/hw/slw.c\n@@ -813,7 +813,7 @@ void add_cpu_idle_state_properties(void)\n \tint nr_states;\n \n \tbool can_sleep = true;\n-\tbool has_slw = true;\n+\tbool has_wakeup_engine = true;\n \tbool has_stop_inst = false;\n \tu8 i;\n \n@@ -906,9 +906,20 @@ void add_cpu_idle_state_properties(void)\n \t\tnr_states = ARRAY_SIZE(power7_cpu_idle_states);\n \t}\n \n-\t/* Enable deep idle states only if slw image is intact */\n-\thas_slw = (chip->slw_base && chip->slw_bar_size &&\n-\t\t\tchip->slw_image_size);\n+\t/*\n+\t * Enable deep idle states only if :\n+\t * P8 : slw image is intact\n+\t * P9 : homer_base is set\n+\t */\n+\tif (!(proc_chip_quirks & QUIRK_MAMBO_CALLOUTS)) {\n+\t\tif (proc_gen == proc_gen_p9)\n+\t\t\thas_wakeup_engine = !!(chip->homer_base);\n+\t\telse /* (proc_gen == proc_gen_p8) */\n+\t\t\thas_wakeup_engine = (chip->slw_base && chip->slw_bar_size &&\n+\t\t\t\t\tchip->slw_image_size);\n+\t} else {\n+\t\thas_wakeup_engine = false;\n+\t}\n \n \t/*\n \t * Currently we can't append strings and cells to dt properties.\n@@ -936,7 +947,7 @@ void add_cpu_idle_state_properties(void)\n \tif (has_stop_inst) {\n \t\t/* Power 9 / POWER ISA 3.0 */\n \t\tsupported_states_mask = OPAL_PM_STOP_INST_FAST;\n-\t\tif (has_slw)\n+\t\tif (has_wakeup_engine)\n \t\t\tsupported_states_mask |= OPAL_PM_STOP_INST_DEEP;\n \t} else {\n \t\t/* Power 7 and Power 8 */\n@@ -944,7 +955,7 @@ void add_cpu_idle_state_properties(void)\n \t\tif (can_sleep)\n \t\t\tsupported_states_mask |= OPAL_PM_SLEEP_ENABLED |\n \t\t\t\t\t\tOPAL_PM_SLEEP_ENABLED_ER1;\n-\t\tif (has_slw)\n+\t\tif (has_wakeup_engine)\n \t\t\tsupported_states_mask |= OPAL_PM_WINKLE_ENABLED;\n \t}\n \tfor (i = 0; i < nr_states; i++) {\n", "prefixes": [ "v4", "6/8" ] }