Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814000/?format=api
{ "id": 814000, "url": "http://patchwork.ozlabs.org/api/patches/814000/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170914223517.8242-3-pasha.tatashin@oracle.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170914223517.8242-3-pasha.tatashin@oracle.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170914223517.8242-3-pasha.tatashin@oracle.com/", "date": "2017-09-14T22:35:08", "name": "[v8,02/11] sparc64/mm: setting fields in deferred pages", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "c41caeb023d58a5b51a7dfd84842eee3a93c21cd", "submitter": { "id": 71010, "url": "http://patchwork.ozlabs.org/api/people/71010/?format=api", "name": "Pavel Tatashin", "email": "pasha.tatashin@oracle.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170914223517.8242-3-pasha.tatashin@oracle.com/mbox/", "series": [ { "id": 3173, "url": "http://patchwork.ozlabs.org/api/series/3173/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=3173", "date": "2017-09-14T22:35:12", "name": "complete deferred page initialization", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/3173/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814000/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814000/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtYh73WTWz9sPs\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 15 Sep 2017 08:52:23 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xtYh72gDkzDsS1\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 15 Sep 2017 08:52:23 +1000 (AEST)", "from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xtYPC2hcHzDrYr\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 15 Sep 2017 08:39:27 +1000 (AEST)", "from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v8EMZQOv029413\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 14 Sep 2017 22:35:26 GMT", "from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv8EMZQ6E022976\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 14 Sep 2017 22:35:26 GMT", "from ubhmp0003.oracle.com (ubhmp0003.oracle.com [156.151.24.56])\n\tby aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v8EMZN9Z024742; \n\tThu, 14 Sep 2017 22:35:23 GMT", "from cmex.localdomain (/12.145.98.253)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 14 Sep 2017 22:35:23 +0000" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=oracle.com\n\t(client-ip=141.146.126.69; helo=aserp1040.oracle.com;\n\tenvelope-from=pasha.tatashin@oracle.com; receiver=<UNKNOWN>)", "From": "Pavel Tatashin <pasha.tatashin@oracle.com>", "To": "linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,\n\tlinux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tx86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com,\n\theiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, \n\tmhocko@kernel.org, ard.biesheuvel@linaro.org, will.deacon@arm.com,\n\tcatalin.marinas@arm.com, sam@ravnborg.org, mgorman@techsingularity.net,\n\tSteven.Sistare@oracle.com, daniel.m.jordan@oracle.com,\n\tbob.picco@oracle.com", "Subject": "[PATCH v8 02/11] sparc64/mm: setting fields in deferred pages", "Date": "Thu, 14 Sep 2017 18:35:08 -0400", "Message-Id": "<20170914223517.8242-3-pasha.tatashin@oracle.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170914223517.8242-1-pasha.tatashin@oracle.com>", "References": "<20170914223517.8242-1-pasha.tatashin@oracle.com>", "X-Source-IP": "aserv0022.oracle.com [141.146.126.234]", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "Without deferred struct page feature (CONFIG_DEFERRED_STRUCT_PAGE_INIT),\nflags and other fields in \"struct page\"es are never changed prior to first\ninitializing struct pages by going through __init_single_page().\n\nWith deferred struct page feature enabled there is a case where we set some\nfields prior to initializing:\n\nmem_init() {\n register_page_bootmem_info();\n free_all_bootmem();\n ...\n}\n\nWhen register_page_bootmem_info() is called only non-deferred struct pages\nare initialized. But, this function goes through some reserved pages which\nmight be part of the deferred, and thus are not yet initialized.\n\nmem_init\nregister_page_bootmem_info\nregister_page_bootmem_info_node\n get_page_bootmem\n .. setting fields here ..\n such as: page->freelist = (void *)type;\n\nfree_all_bootmem()\nfree_low_memory_core_early()\n for_each_reserved_mem_region()\n reserve_bootmem_region()\n init_reserved_page() <- Only if this is deferred reserved page\n __init_single_pfn()\n __init_single_page()\n memset(0) <-- Loose the set fields here\n\nWe end-up with similar issue as in the previous patch, where currently we\ndo not observe problem as memory is zeroed. But, if flag asserts are\nchanged we can start hitting issues.\n\nAlso, because in this patch series we will stop zeroing struct page memory\nduring allocation, we must make sure that struct pages are properly\ninitialized prior to using them.\n\nThe deferred-reserved pages are initialized in free_all_bootmem().\nTherefore, the fix is to switch the above calls.\n\nSigned-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>\nReviewed-by: Steven Sistare <steven.sistare@oracle.com>\nReviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>\nReviewed-by: Bob Picco <bob.picco@oracle.com>\nAcked-by: David S. Miller <davem@davemloft.net>\n---\n arch/sparc/mm/init_64.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c\nindex b2ba410b26f4..078f1352736e 100644\n--- a/arch/sparc/mm/init_64.c\n+++ b/arch/sparc/mm/init_64.c\n@@ -2539,9 +2539,15 @@ void __init mem_init(void)\n {\n \thigh_memory = __va(last_valid_pfn << PAGE_SHIFT);\n \n-\tregister_page_bootmem_info();\n \tfree_all_bootmem();\n \n+\t/* Must be done after boot memory is put on freelist, because here we\n+\t * might set fields in deferred struct pages that have not yet been\n+\t * initialized, and free_all_bootmem() initializes all the reserved\n+\t * deferred pages for us.\n+\t */\n+\tregister_page_bootmem_info();\n+\n \t/*\n \t * Set up the zero page, mark it reserved, so that page count\n \t * is not manipulated when freeing the page from user ptes.\n", "prefixes": [ "v8", "02/11" ] }