Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813977/?format=api
{ "id": 813977, "url": "http://patchwork.ozlabs.org/api/patches/813977/?format=api", "web_url": "http://patchwork.ozlabs.org/project/sparclinux/patch/20170914223517.8242-12-pasha.tatashin@oracle.com/", "project": { "id": 10, "url": "http://patchwork.ozlabs.org/api/projects/10/?format=api", "name": "Linux SPARC Development ", "link_name": "sparclinux", "list_id": "sparclinux.vger.kernel.org", "list_email": "sparclinux@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170914223517.8242-12-pasha.tatashin@oracle.com>", "list_archive_url": null, "date": "2017-09-14T22:35:17", "name": "[v8,11/11] mm: stop zeroing memory during allocation in vmemmap", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "2dd7a1cff4cd24d083f1d921de423cf4813ccb26", "submitter": { "id": 71010, "url": "http://patchwork.ozlabs.org/api/people/71010/?format=api", "name": "Pavel Tatashin", "email": "pasha.tatashin@oracle.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/sparclinux/patch/20170914223517.8242-12-pasha.tatashin@oracle.com/mbox/", "series": [ { "id": 3172, "url": "http://patchwork.ozlabs.org/api/series/3172/?format=api", "web_url": "http://patchwork.ozlabs.org/project/sparclinux/list/?series=3172", "date": "2017-09-14T22:35:07", "name": "complete deferred page initialization", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/3172/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813977/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813977/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<sparclinux-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=sparclinux-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtYLb6h3Lz9sPr\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 15 Sep 2017 08:37:11 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751737AbdINWhK (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 14 Sep 2017 18:37:10 -0400", "from userp1040.oracle.com ([156.151.31.81]:43460 \"EHLO\n\tuserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751733AbdINWhI (ORCPT\n\t<rfc822; sparclinux@vger.kernel.org>); Thu, 14 Sep 2017 18:37:08 -0400", "from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v8EMZhJ5030191\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 14 Sep 2017 22:35:43 GMT", "from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v8EMZh8Z030174\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 14 Sep 2017 22:35:43 GMT", "from ubhmp0003.oracle.com (ubhmp0003.oracle.com [156.151.24.56])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v8EMZhcO004033; \n\tThu, 14 Sep 2017 22:35:43 GMT", "from cmex.localdomain (/12.145.98.253)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 14 Sep 2017 22:35:42 +0000" ], "From": "Pavel Tatashin <pasha.tatashin@oracle.com>", "To": "linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,\n\tlinux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tx86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com,\n\theiko.carstens@de.ibm.com, davem@davemloft.net,\n\twilly@infradead.org, mhocko@kernel.org, ard.biesheuvel@linaro.org,\n\twill.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org,\n\tmgorman@techsingularity.net, Steven.Sistare@oracle.com,\n\tdaniel.m.jordan@oracle.com, bob.picco@oracle.com", "Subject": "[PATCH v8 11/11] mm: stop zeroing memory during allocation in\n\tvmemmap", "Date": "Thu, 14 Sep 2017 18:35:17 -0400", "Message-Id": "<20170914223517.8242-12-pasha.tatashin@oracle.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170914223517.8242-1-pasha.tatashin@oracle.com>", "References": "<20170914223517.8242-1-pasha.tatashin@oracle.com>", "X-Source-IP": "userv0021.oracle.com [156.151.31.71]", "Sender": "sparclinux-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<sparclinux.vger.kernel.org>", "X-Mailing-List": "sparclinux@vger.kernel.org" }, "content": "vmemmap_alloc_block() will no longer zero the block, so zero memory\nat its call sites for everything except struct pages. Struct page memory\nis zero'd by struct page initialization.\n\nReplace allocators in sprase-vmemmap to use the non-zeroing version. So,\nwe will get the performance improvement by zeroing the memory in parallel\nwhen struct pages are zeroed.\n\nSigned-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>\nReviewed-by: Steven Sistare <steven.sistare@oracle.com>\nReviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>\nReviewed-by: Bob Picco <bob.picco@oracle.com>\n---\n include/linux/mm.h | 11 +++++++++++\n mm/sparse-vmemmap.c | 15 +++++++--------\n mm/sparse.c | 6 +++---\n 3 files changed, 21 insertions(+), 11 deletions(-)", "diff": "diff --git a/include/linux/mm.h b/include/linux/mm.h\nindex a7bba4ce79ba..25848764570f 100644\n--- a/include/linux/mm.h\n+++ b/include/linux/mm.h\n@@ -2501,6 +2501,17 @@ static inline void *vmemmap_alloc_block_buf(unsigned long size, int node)\n \treturn __vmemmap_alloc_block_buf(size, node, NULL);\n }\n \n+static inline void *vmemmap_alloc_block_zero(unsigned long size, int node)\n+{\n+\tvoid *p = vmemmap_alloc_block(size, node);\n+\n+\tif (!p)\n+\t\treturn NULL;\n+\tmemset(p, 0, size);\n+\n+\treturn p;\n+}\n+\n void vmemmap_verify(pte_t *, int, unsigned long, unsigned long);\n int vmemmap_populate_basepages(unsigned long start, unsigned long end,\n \t\t\t int node);\ndiff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c\nindex d1a39b8051e0..c2f5654e7c9d 100644\n--- a/mm/sparse-vmemmap.c\n+++ b/mm/sparse-vmemmap.c\n@@ -41,7 +41,7 @@ static void * __ref __earlyonly_bootmem_alloc(int node,\n \t\t\t\tunsigned long align,\n \t\t\t\tunsigned long goal)\n {\n-\treturn memblock_virt_alloc_try_nid(size, align, goal,\n+\treturn memblock_virt_alloc_try_nid_raw(size, align, goal,\n \t\t\t\t\t BOOTMEM_ALLOC_ACCESSIBLE, node);\n }\n \n@@ -54,9 +54,8 @@ void * __meminit vmemmap_alloc_block(unsigned long size, int node)\n \tif (slab_is_available()) {\n \t\tstruct page *page;\n \n-\t\tpage = alloc_pages_node(node,\n-\t\t\tGFP_KERNEL | __GFP_ZERO | __GFP_RETRY_MAYFAIL,\n-\t\t\tget_order(size));\n+\t\tpage = alloc_pages_node(node, GFP_KERNEL | __GFP_RETRY_MAYFAIL,\n+\t\t\t\t\tget_order(size));\n \t\tif (page)\n \t\t\treturn page_address(page);\n \t\treturn NULL;\n@@ -183,7 +182,7 @@ pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long addr, int node)\n {\n \tpmd_t *pmd = pmd_offset(pud, addr);\n \tif (pmd_none(*pmd)) {\n-\t\tvoid *p = vmemmap_alloc_block(PAGE_SIZE, node);\n+\t\tvoid *p = vmemmap_alloc_block_zero(PAGE_SIZE, node);\n \t\tif (!p)\n \t\t\treturn NULL;\n \t\tpmd_populate_kernel(&init_mm, pmd, p);\n@@ -195,7 +194,7 @@ pud_t * __meminit vmemmap_pud_populate(p4d_t *p4d, unsigned long addr, int node)\n {\n \tpud_t *pud = pud_offset(p4d, addr);\n \tif (pud_none(*pud)) {\n-\t\tvoid *p = vmemmap_alloc_block(PAGE_SIZE, node);\n+\t\tvoid *p = vmemmap_alloc_block_zero(PAGE_SIZE, node);\n \t\tif (!p)\n \t\t\treturn NULL;\n \t\tpud_populate(&init_mm, pud, p);\n@@ -207,7 +206,7 @@ p4d_t * __meminit vmemmap_p4d_populate(pgd_t *pgd, unsigned long addr, int node)\n {\n \tp4d_t *p4d = p4d_offset(pgd, addr);\n \tif (p4d_none(*p4d)) {\n-\t\tvoid *p = vmemmap_alloc_block(PAGE_SIZE, node);\n+\t\tvoid *p = vmemmap_alloc_block_zero(PAGE_SIZE, node);\n \t\tif (!p)\n \t\t\treturn NULL;\n \t\tp4d_populate(&init_mm, p4d, p);\n@@ -219,7 +218,7 @@ pgd_t * __meminit vmemmap_pgd_populate(unsigned long addr, int node)\n {\n \tpgd_t *pgd = pgd_offset_k(addr);\n \tif (pgd_none(*pgd)) {\n-\t\tvoid *p = vmemmap_alloc_block(PAGE_SIZE, node);\n+\t\tvoid *p = vmemmap_alloc_block_zero(PAGE_SIZE, node);\n \t\tif (!p)\n \t\t\treturn NULL;\n \t\tpgd_populate(&init_mm, pgd, p);\ndiff --git a/mm/sparse.c b/mm/sparse.c\nindex 83b3bf6461af..d22f51bb7c79 100644\n--- a/mm/sparse.c\n+++ b/mm/sparse.c\n@@ -437,9 +437,9 @@ void __init sparse_mem_maps_populate_node(struct page **map_map,\n \t}\n \n \tsize = PAGE_ALIGN(size);\n-\tmap = memblock_virt_alloc_try_nid(size * map_count,\n-\t\t\t\t\t PAGE_SIZE, __pa(MAX_DMA_ADDRESS),\n-\t\t\t\t\t BOOTMEM_ALLOC_ACCESSIBLE, nodeid);\n+\tmap = memblock_virt_alloc_try_nid_raw(size * map_count,\n+\t\t\t\t\t PAGE_SIZE, __pa(MAX_DMA_ADDRESS),\n+\t\t\t\t\t BOOTMEM_ALLOC_ACCESSIBLE, nodeid);\n \tif (map) {\n \t\tfor (pnum = pnum_begin; pnum < pnum_end; pnum++) {\n \t\t\tif (!present_section_nr(pnum))\n", "prefixes": [ "v8", "11/11" ] }