Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813936/?format=api
{ "id": 813936, "url": "http://patchwork.ozlabs.org/api/patches/813936/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20170914200634.17818-7-paul.burton@imgtec.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170914200634.17818-7-paul.burton@imgtec.com>", "list_archive_url": null, "date": "2017-09-14T20:06:32", "name": "[U-Boot,6/8] test/py: fit: Open files as binary files", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d8750279fc2e419070381a9384b457e957284ad3", "submitter": { "id": 33698, "url": "http://patchwork.ozlabs.org/api/people/33698/?format=api", "name": "Paul Burton", "email": "paul.burton@imgtec.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20170914200634.17818-7-paul.burton@imgtec.com/mbox/", "series": [ { "id": 3156, "url": "http://patchwork.ozlabs.org/api/series/3156/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=3156", "date": "2017-09-14T20:06:26", "name": "test/py: Fixes for python 3.x", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3156/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813936/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813936/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtV7l1l1Bz9s82\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 06:12:33 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid B8167C21EA5; Thu, 14 Sep 2017 20:10:50 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E8632C21EBA;\n\tThu, 14 Sep 2017 20:10:48 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 66520C21E26; Thu, 14 Sep 2017 20:08:46 +0000 (UTC)", "from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196])\n\tby lists.denx.de (Postfix) with ESMTP id D8DB2C21DBC\n\tfor <u-boot@lists.denx.de>; Thu, 14 Sep 2017 20:08:45 +0000 (UTC)", "from hhmail02.hh.imgtec.org (unknown [10.100.10.20])\n\tby Forcepoint Email with ESMTPS id 7C9B120FB066E;\n\tThu, 14 Sep 2017 21:08:40 +0100 (IST)", "from localhost (10.20.1.88) by hhmail02.hh.imgtec.org\n\t(10.100.10.21) with Microsoft SMTP Server (TLS) id 14.3.294.0;\n\tThu, 14 Sep 2017 21:08:44 +0100" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE\n\tautolearn=unavailable autolearn_force=no version=3.4.0", "From": "Paul Burton <paul.burton@imgtec.com>", "To": "<u-boot@lists.denx.de>", "Date": "Thu, 14 Sep 2017 13:06:32 -0700", "Message-ID": "<20170914200634.17818-7-paul.burton@imgtec.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170914200634.17818-1-paul.burton@imgtec.com>", "References": "<20170914200634.17818-1-paul.burton@imgtec.com>", "MIME-Version": "1.0", "X-Originating-IP": "[10.20.1.88]", "Cc": "Stephen Warren <swarren@nvidia.com>", "Subject": "[U-Boot] [PATCH 6/8] test/py: fit: Open files as binary files", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "The read_file() function in test_fit is used with files that are not\ntext files, as well as some that are. It is never used in a way that\nrequires it to decode text files to characters, so open all files in\nbinary mode such that read() doesn't attempt to decode characters for\nfiles which are not text files.\n\nWithout this test_fit fails on python 3.x when reading an FDT in\nrun_fit_test() with:\n\n UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd0 in position\n 0: invalid continuation byte\n\nSigned-off-by: Paul Burton <paul.burton@imgtec.com>\n---\n\n test/py/tests/test_fit.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/test/py/tests/test_fit.py b/test/py/tests/test_fit.py\nindex 29b2491f89..01ecde27d5 100755\n--- a/test/py/tests/test_fit.py\n+++ b/test/py/tests/test_fit.py\n@@ -143,7 +143,7 @@ def test_fit(u_boot_console):\n Returns:\n Contents of file as a string\n \"\"\"\n- with open(fname, 'r') as fd:\n+ with open(fname, 'rb') as fd:\n return fd.read()\n \n def make_dtb():\n", "prefixes": [ "U-Boot", "6/8" ] }