Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813935/?format=api
{ "id": 813935, "url": "http://patchwork.ozlabs.org/api/patches/813935/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20170914200634.17818-9-paul.burton@imgtec.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170914200634.17818-9-paul.burton@imgtec.com>", "list_archive_url": null, "date": "2017-09-14T20:06:34", "name": "[U-Boot,8/8] test/py: vboot: Remove stderr redirect from openssl command", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "54cad98851b8c381589d4f26d3381db30b851523", "submitter": { "id": 33698, "url": "http://patchwork.ozlabs.org/api/people/33698/?format=api", "name": "Paul Burton", "email": "paul.burton@imgtec.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20170914200634.17818-9-paul.burton@imgtec.com/mbox/", "series": [ { "id": 3156, "url": "http://patchwork.ozlabs.org/api/series/3156/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=3156", "date": "2017-09-14T20:06:26", "name": "test/py: Fixes for python 3.x", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3156/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813935/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813935/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtV6z15qYz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 06:11:55 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid D9E5FC21E8E; Thu, 14 Sep 2017 20:11:08 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 36942C21E79;\n\tThu, 14 Sep 2017 20:11:06 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid D55ABC21DDE; Thu, 14 Sep 2017 20:09:22 +0000 (UTC)", "from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196])\n\tby lists.denx.de (Postfix) with ESMTP id BF652C21D90\n\tfor <u-boot@lists.denx.de>; Thu, 14 Sep 2017 20:09:21 +0000 (UTC)", "from hhmail02.hh.imgtec.org (unknown [10.100.10.20])\n\tby Forcepoint Email with ESMTPS id 4CD99A1373F90;\n\tThu, 14 Sep 2017 21:09:16 +0100 (IST)", "from localhost (10.20.1.88) by hhmail02.hh.imgtec.org\n\t(10.100.10.21) with Microsoft SMTP Server (TLS) id 14.3.294.0;\n\tThu, 14 Sep 2017 21:09:20 +0100" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE\n\tautolearn=unavailable autolearn_force=no version=3.4.0", "From": "Paul Burton <paul.burton@imgtec.com>", "To": "<u-boot@lists.denx.de>", "Date": "Thu, 14 Sep 2017 13:06:34 -0700", "Message-ID": "<20170914200634.17818-9-paul.burton@imgtec.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170914200634.17818-1-paul.burton@imgtec.com>", "References": "<20170914200634.17818-1-paul.burton@imgtec.com>", "MIME-Version": "1.0", "X-Originating-IP": "[10.20.1.88]", "Cc": "Stephen Warren <swarren@nvidia.com>", "Subject": "[U-Boot] [PATCH 8/8] test/py: vboot: Remove stderr redirect from\n\topenssl command", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "The openssl command specified in test_with_algo() ultimately ends up\nbeing run by RunAndLog::run(), which uses it to construct a Popen object\nwith the default shell=False. The stderr redirect in the command is\ntherefore simply passed to openssl as an argument. With at least openssl\n1.1.0f this causes openssl, and therefore test_vboot, to fail with:\n\n genpkey: Use -help for summary.\n Exit code: 1\n\nAny stderr output ought to be captured & stored in the RunAndLog\nobject's output field and returned from run() via run_and_log() to\ntest_with_algo() which then ignores it anyway, so we can drop the\nshell-like redirection with no ill effects. With this fix test_vboot now\npasses for me.\n\nSigned-off-by: Paul Burton <paul.burton@imgtec.com>\n\n---\n\n test/py/tests/test_vboot.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py\nindex 6e62820743..ba86a08e2e 100644\n--- a/test/py/tests/test_vboot.py\n+++ b/test/py/tests/test_vboot.py\n@@ -174,8 +174,8 @@ def test_vboot(u_boot_console):\n public_exponent = 65537\n util.run_and_log(cons, 'openssl genpkey -algorithm RSA -out %sdev.key '\n '-pkeyopt rsa_keygen_bits:2048 '\n- '-pkeyopt rsa_keygen_pubexp:%d '\n- '2>/dev/null' % (tmpdir, public_exponent))\n+ '-pkeyopt rsa_keygen_pubexp:%d'\n+ % (tmpdir, public_exponent))\n \n # Create a certificate containing the public key\n util.run_and_log(cons, 'openssl req -batch -new -x509 -key %sdev.key -out '\n", "prefixes": [ "U-Boot", "8/8" ] }