Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813856/?format=api
{ "id": 813856, "url": "http://patchwork.ozlabs.org/api/patches/813856/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170914144032.14945-20-eblake@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170914144032.14945-20-eblake@redhat.com>", "list_archive_url": null, "date": "2017-09-14T14:40:31", "name": "[v3,19/20] vvfat: Switch to .bdrv_co_block_status()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "036305bc5efdf83cb9570de8a182e8ca37a1d292", "submitter": { "id": 6591, "url": "http://patchwork.ozlabs.org/api/people/6591/?format=api", "name": "Eric Blake", "email": "eblake@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170914144032.14945-20-eblake@redhat.com/mbox/", "series": [ { "id": 3114, "url": "http://patchwork.ozlabs.org/api/series/3114/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3114", "date": "2017-09-14T14:40:12", "name": "add byte-based block_status driver callbacks", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/3114/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813856/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813856/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtM0M0Bwlz9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 00:50:43 +1000 (AEST)", "from localhost ([::1]:48218 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dsVTV-00070S-39\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 10:50:41 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:47029)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dsVKp-0006Ou-7G\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:41:44 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dsVKo-00034t-Co\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:41:43 -0400", "from mx1.redhat.com ([209.132.183.28]:47092)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <eblake@redhat.com>)\n\tid 1dsVKl-00032I-Bj; Thu, 14 Sep 2017 10:41:39 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5EA9480C05;\n\tThu, 14 Sep 2017 14:41:38 +0000 (UTC)", "from red.redhat.com (ovpn-123-70.rdu2.redhat.com [10.10.123.70])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2821F60841;\n\tThu, 14 Sep 2017 14:41:37 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 5EA9480C05", "From": "Eric Blake <eblake@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Thu, 14 Sep 2017 09:40:31 -0500", "Message-Id": "<20170914144032.14945-20-eblake@redhat.com>", "In-Reply-To": "<20170914144032.14945-1-eblake@redhat.com>", "References": "<20170914144032.14945-1-eblake@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 14 Sep 2017 14:41:38 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v3 19/20] vvfat: Switch to\n\t.bdrv_co_block_status()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "kwolf@redhat.com, famz@redhat.com, jsnow@redhat.com,\n\tqemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "We are gradually moving away from sector-based interfaces, towards\nbyte-based. Update the vvfat driver accordingly. Note that we\ncan rely on the block driver having already clamped limits to our\nblock size, and simplify accordingly.\n\nSigned-off-by: Eric Blake <eblake@redhat.com>\n\n---\nv2: rebase to earlier changes, simplify\n---\n block/vvfat.c | 16 +++++++---------\n 1 file changed, 7 insertions(+), 9 deletions(-)", "diff": "diff --git a/block/vvfat.c b/block/vvfat.c\nindex c54fa94651..6a08d68ae3 100644\n--- a/block/vvfat.c\n+++ b/block/vvfat.c\n@@ -3090,15 +3090,13 @@ vvfat_co_pwritev(BlockDriverState *bs, uint64_t offset, uint64_t bytes,\n return ret;\n }\n\n-static int64_t coroutine_fn vvfat_co_get_block_status(BlockDriverState *bs,\n- int64_t sector_num, int nb_sectors, int *n, BlockDriverState **file)\n+static int64_t coroutine_fn vvfat_co_block_status(BlockDriverState *bs,\n+ bool mapping,\n+ int64_t offset,\n+ int64_t bytes, int64_t *n,\n+ BlockDriverState **file)\n {\n- *n = bs->total_sectors - sector_num;\n- if (*n > nb_sectors) {\n- *n = nb_sectors;\n- } else if (*n < 0) {\n- return 0;\n- }\n+ *n = bytes;\n return BDRV_BLOCK_DATA;\n }\n\n@@ -3258,7 +3256,7 @@ static BlockDriver bdrv_vvfat = {\n\n .bdrv_co_preadv = vvfat_co_preadv,\n .bdrv_co_pwritev = vvfat_co_pwritev,\n- .bdrv_co_get_block_status = vvfat_co_get_block_status,\n+ .bdrv_co_block_status = vvfat_co_block_status,\n };\n\n static void bdrv_vvfat_init(void)\n", "prefixes": [ "v3", "19/20" ] }