Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813738/?format=api
{ "id": 813738, "url": "http://patchwork.ozlabs.org/api/patches/813738/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1505375436-28439-11-git-send-email-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505375436-28439-11-git-send-email-peterx@redhat.com>", "list_archive_url": null, "date": "2017-09-14T07:50:31", "name": "[RFC,10/15] monitor: introduce monitor_qmp_respond()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ae5235a6dc35250fee9a0a654e6740c8334af084", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1505375436-28439-11-git-send-email-peterx@redhat.com/mbox/", "series": [ { "id": 3043, "url": "http://patchwork.ozlabs.org/api/series/3043/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3043", "date": "2017-09-14T07:50:21", "name": "QMP: out-of-band (OOB) execution support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3043/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813738/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813738/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt9xg1BXtz9sRm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 18:02:47 +1000 (AEST)", "from localhost ([::1]:46239 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dsP6j-0000YK-6Z\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 04:02:45 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:52492)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dsOwL-0007BD-Nm\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:52:08 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dsOwJ-0007fC-UN\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:52:01 -0400", "from mx1.redhat.com ([209.132.183.28]:43284)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <peterx@redhat.com>) id 1dsOwJ-0007d8-LC\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:51:59 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8DB4785546;\n\tThu, 14 Sep 2017 07:51:58 +0000 (UTC)", "from pxdev.xzpeter.org.com (dhcp-15-224.nay.redhat.com\n\t[10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0836260F9F;\n\tThu, 14 Sep 2017 07:51:51 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 8DB4785546", "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Thu, 14 Sep 2017 15:50:31 +0800", "Message-Id": "<1505375436-28439-11-git-send-email-peterx@redhat.com>", "In-Reply-To": "<1505375436-28439-1-git-send-email-peterx@redhat.com>", "References": "<1505375436-28439-1-git-send-email-peterx@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 14 Sep 2017 07:51:58 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [RFC 10/15] monitor: introduce monitor_qmp_respond()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Laurent Vivier <lvivier@redhat.com>, Fam Zheng <famz@redhat.com>, Juan\n\tQuintela <quintela@redhat.com>, Markus Armbruster <armbru@redhat.com>,\n\tpeterx@redhat.com, mdroth@linux.vnet.ibm.com,\n\tStefan Hajnoczi <shajnocz@redhat.com>, =?utf-8?q?Marc-Andr=C3=A9_Lure?=\n\t=?utf-8?q?au?= <marcandre.lureau@gmail.com>,\n\tPaolo Bonzini <pbonzini@redhat.com>, \"Dr . David Alan Gilbert\"\n\t<dgilbert@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "A tiny refactoring, preparing to split the QMP dispatcher away.\n\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n monitor.c | 48 +++++++++++++++++++++++++++++++-----------------\n 1 file changed, 31 insertions(+), 17 deletions(-)", "diff": "diff --git a/monitor.c b/monitor.c\nindex 83f5e87..aa0c384 100644\n--- a/monitor.c\n+++ b/monitor.c\n@@ -3828,6 +3828,36 @@ static int monitor_can_read(void *opaque)\n return (mon->suspend_cnt == 0) ? 1 : 0;\n }\n \n+/*\n+ * When rsp/err/id is passed in, the function will be responsible for\n+ * the cleanup.\n+ */\n+static void monitor_qmp_respond(Monitor *mon, QObject *rsp,\n+ Error *err, QObject *id)\n+{\n+ QDict *qdict = NULL;\n+\n+ if (err) {\n+ qdict = qdict_new();\n+ qdict_put_obj(qdict, \"error\", qmp_build_error_object(err));\n+ error_free(err);\n+ rsp = QOBJECT(qdict);\n+ }\n+\n+ if (rsp) {\n+ if (id) {\n+ /* This is for the qdict below. */\n+ qobject_incref(id);\n+ qdict_put_obj(qobject_to_qdict(rsp), \"id\", id);\n+ }\n+\n+ monitor_json_emitter(mon, rsp);\n+ }\n+\n+ qobject_decref(id);\n+ qobject_decref(rsp);\n+}\n+\n static void handle_qmp_command(JSONMessageParser *parser, GQueue *tokens,\n void *opaque)\n {\n@@ -3878,24 +3908,8 @@ static void handle_qmp_command(JSONMessageParser *parser, GQueue *tokens,\n }\n \n err_out:\n- if (err) {\n- qdict = qdict_new();\n- qdict_put_obj(qdict, \"error\", qmp_build_error_object(err));\n- error_free(err);\n- rsp = QOBJECT(qdict);\n- }\n+ monitor_qmp_respond(mon, rsp, err, id);\n \n- if (rsp) {\n- if (id) {\n- qdict_put_obj(qobject_to_qdict(rsp), \"id\", id);\n- id = NULL;\n- }\n-\n- monitor_json_emitter(mon, rsp);\n- }\n-\n- qobject_decref(id);\n- qobject_decref(rsp);\n qobject_decref(req);\n }\n \n", "prefixes": [ "RFC", "10/15" ] }