Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813737/?format=api
{ "id": 813737, "url": "http://patchwork.ozlabs.org/api/patches/813737/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1505375436-28439-10-git-send-email-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505375436-28439-10-git-send-email-peterx@redhat.com>", "list_archive_url": null, "date": "2017-09-14T07:50:30", "name": "[RFC,09/15] monitor: allow to use IO thread for parsing", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "30f6e4e384f8ffa22fa4a0e81f4c8296c17c5675", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1505375436-28439-10-git-send-email-peterx@redhat.com/mbox/", "series": [ { "id": 3043, "url": "http://patchwork.ozlabs.org/api/series/3043/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3043", "date": "2017-09-14T07:50:21", "name": "QMP: out-of-band (OOB) execution support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3043/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813737/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813737/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt9tS0D3Jz9sRm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 18:00:00 +1000 (AEST)", "from localhost ([::1]:46219 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dsP42-0006GC-3l\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 03:59:58 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:52318)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dsOwF-00072W-7w\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:51:56 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dsOwC-0007RF-3T\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:51:55 -0400", "from mx1.redhat.com ([209.132.183.28]:57800)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <peterx@redhat.com>) id 1dsOwB-0007PF-JJ\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:51:51 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8B1F881DF1;\n\tThu, 14 Sep 2017 07:51:50 +0000 (UTC)", "from pxdev.xzpeter.org.com (dhcp-15-224.nay.redhat.com\n\t[10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B6806619BE;\n\tThu, 14 Sep 2017 07:51:42 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 8B1F881DF1", "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Thu, 14 Sep 2017 15:50:30 +0800", "Message-Id": "<1505375436-28439-10-git-send-email-peterx@redhat.com>", "In-Reply-To": "<1505375436-28439-1-git-send-email-peterx@redhat.com>", "References": "<1505375436-28439-1-git-send-email-peterx@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tThu, 14 Sep 2017 07:51:50 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [RFC 09/15] monitor: allow to use IO thread for parsing", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Laurent Vivier <lvivier@redhat.com>, Fam Zheng <famz@redhat.com>, Juan\n\tQuintela <quintela@redhat.com>, Markus Armbruster <armbru@redhat.com>,\n\tpeterx@redhat.com, mdroth@linux.vnet.ibm.com,\n\tStefan Hajnoczi <shajnocz@redhat.com>, =?utf-8?q?Marc-Andr=C3=A9_Lure?=\n\t=?utf-8?q?au?= <marcandre.lureau@gmail.com>,\n\tPaolo Bonzini <pbonzini@redhat.com>, \"Dr . David Alan Gilbert\"\n\t<dgilbert@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "For each Monitor, add one field \"use_io_thr\" to show whether it will be\nusing the dedicated monitor IO thread to handle input/output. When set,\nmonitor IO parsing work will be offloaded to dedicated monitor IO\nthread, rather than the original main loop thread.\n\nThis only works for QMP. HMP will always be run on main loop thread.\n\nCurrently we're still keeping use_io_thr to off always. Will turn it on\nlater at some point.\n\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n monitor.c | 25 +++++++++++++++++++++----\n 1 file changed, 21 insertions(+), 4 deletions(-)", "diff": "diff --git a/monitor.c b/monitor.c\nindex 9e9a32e..83f5e87 100644\n--- a/monitor.c\n+++ b/monitor.c\n@@ -190,6 +190,7 @@ struct Monitor {\n int flags;\n int suspend_cnt;\n bool skip_flush;\n+ bool use_io_thr;\n \n QemuMutex out_lock;\n QString *outbuf;\n@@ -576,7 +577,8 @@ static void monitor_qapi_event_init(void)\n \n static void handle_hmp_command(Monitor *mon, const char *cmdline);\n \n-static void monitor_data_init(Monitor *mon, bool skip_flush)\n+static void monitor_data_init(Monitor *mon, bool skip_flush,\n+ bool use_io_thr)\n {\n memset(mon, 0, sizeof(Monitor));\n qemu_mutex_init(&mon->out_lock);\n@@ -584,6 +586,7 @@ static void monitor_data_init(Monitor *mon, bool skip_flush)\n /* Use *mon_cmds by default. */\n mon->cmd_table = mon_cmds;\n mon->skip_flush = skip_flush;\n+ mon->use_io_thr = use_io_thr;\n }\n \n static void monitor_data_destroy(Monitor *mon)\n@@ -603,7 +606,7 @@ char *qmp_human_monitor_command(const char *command_line, bool has_cpu_index,\n char *output = NULL;\n Monitor *old_mon, hmp;\n \n- monitor_data_init(&hmp, true);\n+ monitor_data_init(&hmp, true, false);\n \n old_mon = cur_mon;\n cur_mon = &hmp;\n@@ -4122,8 +4125,9 @@ void error_vprintf_unless_qmp(const char *fmt, va_list ap)\n void monitor_init(Chardev *chr, int flags)\n {\n Monitor *mon = g_malloc(sizeof(*mon));\n+ GMainContext *context;\n \n- monitor_data_init(mon, false);\n+ monitor_data_init(mon, false, false);\n \n qemu_chr_fe_init(&mon->chr, chr, &error_abort);\n mon->flags = flags;\n@@ -4135,9 +4139,22 @@ void monitor_init(Chardev *chr, int flags)\n monitor_read_command(mon, 0);\n }\n \n+ if (mon->use_io_thr) {\n+ /*\n+ * When use_io_thr is set, we use the global shared dedicated\n+ * IO thread for this monitor to handle input/output.\n+ */\n+ context = mon_global.mon_context;\n+ /* We should have inited globals before reaching here. */\n+ assert(context);\n+ } else {\n+ /* The default main loop, which is the main thread */\n+ context = NULL;\n+ }\n+\n if (monitor_is_qmp(mon)) {\n qemu_chr_fe_set_handlers(&mon->chr, monitor_can_read, monitor_qmp_read,\n- monitor_qmp_event, NULL, mon, NULL, true);\n+ monitor_qmp_event, NULL, mon, context, true);\n qemu_chr_fe_set_echo(&mon->chr, true);\n json_message_parser_init(&mon->qmp.parser, handle_qmp_command, mon);\n } else {\n", "prefixes": [ "RFC", "09/15" ] }