Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813361/?format=api
{ "id": 813361, "url": "http://patchwork.ozlabs.org/api/patches/813361/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913105953.13760-15-quintela@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170913105953.13760-15-quintela@redhat.com>", "list_archive_url": null, "date": "2017-09-13T10:59:47", "name": "[v8,14/20] migration: Really use multiple pages at a time", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4ea115f408c750aa043a815e1f8ad67b0e9b483e", "submitter": { "id": 2643, "url": "http://patchwork.ozlabs.org/api/people/2643/?format=api", "name": "Juan Quintela", "email": "quintela@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913105953.13760-15-quintela@redhat.com/mbox/", "series": [ { "id": 2885, "url": "http://patchwork.ozlabs.org/api/series/2885/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2885", "date": "2017-09-13T10:59:33", "name": "Multifd", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/2885/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813361/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813361/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=quintela@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsf7p27Gqz9sBW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 21:09:42 +1000 (AEST)", "from localhost ([::1]:41589 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds5Y4-0005gQ-9m\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 07:09:40 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:42350)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1ds5PN-0006UK-BO\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:00:42 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1ds5PM-0006yY-4o\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:00:41 -0400", "from mx1.redhat.com ([209.132.183.28]:46248)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <quintela@redhat.com>) id 1ds5PL-0006xr-PK\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:00:40 -0400", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C56137EBDC\n\tfor <qemu-devel@nongnu.org>; Wed, 13 Sep 2017 11:00:38 +0000 (UTC)", "from secure.mitica (ovpn-117-188.ams2.redhat.com [10.36.117.188])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AA68D5191D;\n\tWed, 13 Sep 2017 11:00:35 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com C56137EBDC", "From": "Juan Quintela <quintela@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 13 Sep 2017 12:59:47 +0200", "Message-Id": "<20170913105953.13760-15-quintela@redhat.com>", "In-Reply-To": "<20170913105953.13760-1-quintela@redhat.com>", "References": "<20170913105953.13760-1-quintela@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 13 Sep 2017 11:00:38 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v8 14/20] migration: Really use multiple pages\n\tat a time", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "We now send several pages at a time each time that we wakeup a thread.\n\nSigned-off-by: Juan Quintela <quintela@redhat.com>\n\n--\n\nUse iovec's instead of creating the equivalent.\nClear memory used by pages (dave)\nUse g_new0(danp)\ndefine MULTIFD_CONTINUE\n---\n migration/ram.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++---------\n 1 file changed, 48 insertions(+), 9 deletions(-)", "diff": "diff --git a/migration/ram.c b/migration/ram.c\nindex 1381bfaf8a..179b45eea7 100644\n--- a/migration/ram.c\n+++ b/migration/ram.c\n@@ -49,6 +49,7 @@\n #include \"migration/colo.h\"\n #include \"sysemu/sysemu.h\"\n #include \"qemu/uuid.h\"\n+#include \"qemu/iov.h\"\n \n /***********************************************************/\n /* ram save/restore */\n@@ -362,6 +363,15 @@ static void compress_threads_save_setup(void)\n \n /* Multiple fd's */\n \n+/* used to continue on the same multifd group */\n+#define MULTIFD_CONTINUE UINT16_MAX\n+\n+typedef struct {\n+ int num;\n+ size_t size;\n+ struct iovec *iov;\n+} multifd_pages_t;\n+\n struct MultiFDSendParams {\n /* not changed */\n uint8_t id;\n@@ -372,11 +382,7 @@ struct MultiFDSendParams {\n QemuMutex mutex;\n /* protected by param mutex */\n bool quit;\n- /* This is a temp field. We are using it now to transmit\n- something the address of the page. Later in the series, we\n- change it for the real page.\n- */\n- uint8_t *address;\n+ multifd_pages_t pages;\n /* protected by multifd mutex */\n /* has the thread finish the last submitted job */\n bool done;\n@@ -389,8 +395,24 @@ struct {\n int count;\n QemuMutex mutex;\n QemuSemaphore sem;\n+ multifd_pages_t pages;\n } *multifd_send_state;\n \n+static void multifd_init_pages(multifd_pages_t *pages)\n+{\n+ pages->num = 0;\n+ pages->size = migrate_multifd_page_count();\n+ pages->iov = g_new0(struct iovec, pages->size);\n+}\n+\n+static void multifd_clear_pages(multifd_pages_t *pages)\n+{\n+ pages->num = 0;\n+ pages->size = 0;\n+ g_free(pages->iov);\n+ pages->iov = NULL;\n+}\n+\n static void terminate_multifd_send_threads(Error *errp)\n {\n int i;\n@@ -429,9 +451,11 @@ int multifd_save_cleanup(Error **errp)\n socket_send_channel_destroy(p->c);\n g_free(p->name);\n p->name = NULL;\n+ multifd_clear_pages(&p->pages);\n }\n g_free(multifd_send_state->params);\n multifd_send_state->params = NULL;\n+ multifd_clear_pages(&multifd_send_state->pages);\n g_free(multifd_send_state);\n multifd_send_state = NULL;\n return ret;\n@@ -471,8 +495,8 @@ static void *multifd_send_thread(void *opaque)\n qemu_mutex_unlock(&p->mutex);\n break;\n }\n- if (p->address) {\n- p->address = 0;\n+ if (p->pages.num) {\n+ p->pages.num = 0;\n qemu_mutex_unlock(&p->mutex);\n qemu_mutex_lock(&multifd_send_state->mutex);\n p->done = true;\n@@ -522,6 +546,7 @@ int multifd_save_setup(void)\n multifd_send_state->count = 0;\n qemu_mutex_init(&multifd_send_state->mutex);\n qemu_sem_init(&multifd_send_state->sem, 0);\n+ multifd_init_pages(&multifd_send_state->pages);\n for (i = 0; i < thread_count; i++) {\n MultiFDSendParams *p = &multifd_send_state->params[i];\n \n@@ -530,7 +555,7 @@ int multifd_save_setup(void)\n p->quit = false;\n p->id = i;\n p->done = true;\n- p->address = 0;\n+ multifd_init_pages(&p->pages);\n p->name = g_strdup_printf(\"multifdsend_%d\", i);\n socket_send_channel_create(multifd_new_channel_async, p);\n }\n@@ -541,6 +566,17 @@ static uint16_t multifd_send_page(uint8_t *address, bool last_page)\n {\n int i;\n MultiFDSendParams *p = NULL; /* make happy gcc */\n+ multifd_pages_t *pages = &multifd_send_state->pages;\n+\n+ pages->iov[pages->num].iov_base = address;\n+ pages->iov[pages->num].iov_len = TARGET_PAGE_SIZE;\n+ pages->num++;\n+\n+ if (!last_page) {\n+ if (pages->num < (pages->size - 1)) {\n+ return MULTIFD_CONTINUE;\n+ }\n+ }\n \n qemu_sem_wait(&multifd_send_state->sem);\n qemu_mutex_lock(&multifd_send_state->mutex);\n@@ -554,7 +590,10 @@ static uint16_t multifd_send_page(uint8_t *address, bool last_page)\n }\n qemu_mutex_unlock(&multifd_send_state->mutex);\n qemu_mutex_lock(&p->mutex);\n- p->address = address;\n+ p->pages.num = pages->num;\n+ iov_copy(p->pages.iov, pages->num, pages->iov, pages->num, 0,\n+ iov_size(pages->iov, pages->num));\n+ pages->num = 0;\n qemu_mutex_unlock(&p->mutex);\n qemu_sem_post(&p->sem);\n \n", "prefixes": [ "v8", "14/20" ] }