Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813360/?format=api
{ "id": 813360, "url": "http://patchwork.ozlabs.org/api/patches/813360/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913105953.13760-5-quintela@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170913105953.13760-5-quintela@redhat.com>", "list_archive_url": null, "date": "2017-09-13T10:59:37", "name": "[v8,04/20] migration: Create migration_has_all_channels", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "08579b1faabac83b55e0df445baedbb30ab5802e", "submitter": { "id": 2643, "url": "http://patchwork.ozlabs.org/api/people/2643/?format=api", "name": "Juan Quintela", "email": "quintela@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913105953.13760-5-quintela@redhat.com/mbox/", "series": [ { "id": 2885, "url": "http://patchwork.ozlabs.org/api/series/2885/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2885", "date": "2017-09-13T10:59:33", "name": "Multifd", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/2885/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813360/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813360/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=quintela@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsf7R5J1pz9sBW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 21:09:22 +1000 (AEST)", "from localhost ([::1]:41588 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds5Xk-0005QI-6Q\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 07:09:20 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:41840)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1ds5Ot-00062Y-9U\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:00:13 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1ds5Os-0006Iv-7i\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:00:11 -0400", "from mx1.redhat.com ([209.132.183.28]:38566)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <quintela@redhat.com>) id 1ds5Os-0006Gi-2a\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:00:10 -0400", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 138BFC0587DF\n\tfor <qemu-devel@nongnu.org>; Wed, 13 Sep 2017 11:00:09 +0000 (UTC)", "from secure.mitica (ovpn-117-188.ams2.redhat.com [10.36.117.188])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 58D4D51919;\n\tWed, 13 Sep 2017 11:00:07 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 138BFC0587DF", "From": "Juan Quintela <quintela@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 13 Sep 2017 12:59:37 +0200", "Message-Id": "<20170913105953.13760-5-quintela@redhat.com>", "In-Reply-To": "<20170913105953.13760-1-quintela@redhat.com>", "References": "<20170913105953.13760-1-quintela@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 13 Sep 2017 11:00:09 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v8 04/20] migration: Create\n\tmigration_has_all_channels", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "This function allows us to decide when to close the listener socket.\nFor now, we only need one connection.\n\nSigned-off-by: Juan Quintela <quintela@redhat.com>\nReviewed-by: Daniel P. Berrange <berrange@redhat.com>\n---\n migration/migration.c | 11 +++++++++++\n migration/migration.h | 2 ++\n migration/socket.c | 10 +++++++---\n 3 files changed, 20 insertions(+), 3 deletions(-)", "diff": "diff --git a/migration/migration.c b/migration/migration.c\nindex 2d4c56e612..bac4a99277 100644\n--- a/migration/migration.c\n+++ b/migration/migration.c\n@@ -384,6 +384,17 @@ void migration_ioc_process_incoming(QIOChannel *ioc)\n /* We still only have a single channel. Nothing to do here yet */\n }\n \n+/**\n+ * @migration_has_all_channels: We have received all channels that we need\n+ *\n+ * Returns true when we have got connections to all the channels that\n+ * we need for migration.\n+ */\n+bool migration_has_all_channels(void)\n+{\n+ return true;\n+}\n+\n /*\n * Send a 'SHUT' message on the return channel with the given value\n * to indicate that we've finished with the RP. Non-0 value indicates\ndiff --git a/migration/migration.h b/migration/migration.h\nindex 99c398d484..1881e4a754 100644\n--- a/migration/migration.h\n+++ b/migration/migration.h\n@@ -155,6 +155,8 @@ void migrate_set_state(int *state, int old_state, int new_state);\n void migration_fd_process_incoming(QEMUFile *f);\n void migration_ioc_process_incoming(QIOChannel *ioc);\n \n+bool migration_has_all_channels(void);\n+\n uint64_t migrate_max_downtime(void);\n \n void migrate_fd_error(MigrationState *s, const Error *error);\ndiff --git a/migration/socket.c b/migration/socket.c\nindex b02d37d7a3..dee869044a 100644\n--- a/migration/socket.c\n+++ b/migration/socket.c\n@@ -152,9 +152,13 @@ static gboolean socket_accept_incoming_migration(QIOChannel *ioc,\n object_unref(OBJECT(sioc));\n \n out:\n- /* Close listening socket as its no longer needed */\n- qio_channel_close(ioc, NULL);\n- return G_SOURCE_REMOVE;\n+ if (migration_has_all_channels()) {\n+ /* Close listening socket as its no longer needed */\n+ qio_channel_close(ioc, NULL);\n+ return G_SOURCE_REMOVE;\n+ } else {\n+ return G_SOURCE_CONTINUE;\n+ }\n }\n \n \n", "prefixes": [ "v8", "04/20" ] }