Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813146/?format=api
{ "id": 813146, "url": "http://patchwork.ozlabs.org/api/patches/813146/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20170913025905.16419-1-xypron.glpk@gmx.de/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170913025905.16419-1-xypron.glpk@gmx.de>", "list_archive_url": null, "date": "2017-09-13T02:59:05", "name": "[U-Boot,1/1] checkpatch.pl: Add warning for new __packed additions", "commit_ref": "5c761ce58666b3a1695697498598f8bf3484a0c7", "pull_url": null, "state": "accepted", "archived": false, "hash": "e4c1f3938ce931e9b38d415d541c0a22a016e1bb", "submitter": { "id": 61270, "url": "http://patchwork.ozlabs.org/api/people/61270/?format=api", "name": "Heinrich Schuchardt", "email": "xypron.glpk@gmx.de" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20170913025905.16419-1-xypron.glpk@gmx.de/mbox/", "series": [ { "id": 2803, "url": "http://patchwork.ozlabs.org/api/series/2803/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=2803", "date": "2017-09-13T02:59:05", "name": "[U-Boot,1/1] checkpatch.pl: Add warning for new __packed additions", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2803/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813146/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813146/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsRKX4rr5z9t39\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 13:02:24 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 6C80BC22363; Wed, 13 Sep 2017 03:01:18 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C02ABC22411;\n\tWed, 13 Sep 2017 03:01:15 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 62CF8C22447; Wed, 13 Sep 2017 02:59:32 +0000 (UTC)", "from mout.gmx.net (mout.gmx.net [212.227.15.19])\n\tby lists.denx.de (Postfix) with ESMTPS id 5EBE9C224C5\n\tfor <u-boot@lists.denx.de>; Wed, 13 Sep 2017 02:59:32 +0000 (UTC)", "from laptop1.fritz.box ([94.197.121.167]) by mail.gmx.com (mrgmx002\n\t[212.227.17.184]) with ESMTPSA (Nemesis) id 0MexFh-1e3HW70Paz-00OTuA;\n\tWed, 13 Sep 2017 04:59:22 +0200" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0", "From": "Heinrich Schuchardt <xypron.glpk@gmx.de>", "To": "Tom Rini <trini@konsulko.com>", "Date": "Wed, 13 Sep 2017 04:59:05 +0200", "Message-Id": "<20170913025905.16419-1-xypron.glpk@gmx.de>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170912213344.GC4474@bill-the-cat>", "References": "<20170912213344.GC4474@bill-the-cat>", "X-Provags-ID": "V03:K0:pESk1yFqPRzF1Qt+vvWy142eUsDcFskJslXx3pJEDeipKhMhhyU\n\tErUlj4t+4tIpwESbjn0ucjjJD1RzgglNk8TeQ20GUtWKIP7k1yZ0Z6V6C3zVPTKeCtALFnT\n\tojMRlJ3IQGLi5fQCKoyzZGBGfgCvcFfQp9N9Lc1ldcYYelzyHbX5bFI4Tatm5AiLjQWZGrq\n\t9f3NHr/ny1I82p9RtB+MA==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:8DPSXuOwqm0=:FQmmEQRVzjyzeh/yAX6O5h\n\tD4WOZgH6nfm9nLNWDPXdxrK2PGWYlLKhZjUxrQr9LWHnmkoiMM24vmfj6224EvQZz/XLqyJ55\n\t/+TiyptFjhnOsFty1JS4NJYxAhbQjs65nfZhTkdanUbFc1tLMM8o20BMPSWVzSXPH4H+sF1EU\n\tfl04l8NXJvh6a9S5ICFhDVUV/puInCpCUw3pnK3rJTQclKxwZZneV6lFnWXwooNliiV4no3k1\n\tp+NRYuTfEBvPE/GxslYYUoffiAG89GBkvHTh5SaEVoKF6EYNaIvP61SdxwxkeWnsdoiZeMqEO\n\tGz5IFvIpQyAAxNe8BN/kMYDGD4vAJB2LQEcgUXv6H+6xFEYE0Gcu/E5/QuMxxG59p/rEsOaTb\n\tTCkga99sm5TJE1EsAzHO9Mq/BLnlA68seMivz5UEA5Sq7wzmCa0li0BmYI2ptLGV0DTuqm82T\n\tQ5zoxfRcV+Qz3RWr2b0LPGKjQrBONvUpkcaNvUKeqQH0eZciJKENRAQ/7cevVIDNMlOXQQndU\n\tqYgGMxx2vcy9obIlOAO1FXPnHfUdsojiuMi0932JVtzYFWwuzoC74BTjLOQOV03CL8QgQP/Vw\n\tpfaElBMxNDU8IZwMiG/eVbFL7zuO9Z0fX+N9HiKFwdueIk1sVjaudhYdHdn/sLXbmGfwsLHMu\n\tuQwhSqSZhbNh++mIuiHO8/Jn426D5AlVBkFlv6DcF626DSGjAkKPeJA9C2/iRfNZTyYCfRp+q\n\tlF1XV65UEjQbQnDR/2+ePq6y/tRoxPw4W6QcrQknuklOBPso5jFi9XrW1YVelREASRwy0bdOX\n\tRb61dcMvGomfTMvhdhxZZIDj8In581+4kfaKhdgtuRx8DEnX7w=", "Cc": "Jagan Teki <jteki@openedev.com>, u-boot@lists.denx.de,\n\tStefan Roese <sr@denx.de>, Heinrich Schuchardt <xypron.glpk@gmx.de>", "Subject": "[U-Boot] [PATCH 1/1] checkpatch.pl: Add warning for new __packed\n\tadditions", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "While there are valid reasons to use __packed, often the answer is that\nyou should be doing something else here instead.\n\nThis reintroduces the changes of\nf503cc49a570 (Add warning for new __packed additions)\n\nSigned-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>\n---\nThis patch is to go after\n[PATCH v2 1/1] checkpatch: update from Linux v4.13-rc6\n\nIn the git log I found no other contributions that we loose by\nupgrading to the new checkpatch version.\n\nI just wonder if the warning text makes sense.\nWouldn't it be more helpful to write:\n\n\"Sequencing structure members in a packed order is\npreferable to using __packed.\"\n\nMaybe this is also the reason why this check was not accepted\nby upstream.\n---\n scripts/checkpatch.pl | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl\nindex 2287a0bca8..4142f5c837 100755\n--- a/scripts/checkpatch.pl\n+++ b/scripts/checkpatch.pl\n@@ -5616,6 +5616,13 @@ sub process {\n \t\t\t \"__packed is preferred over __attribute__((packed))\\n\" . $herecurr);\n \t\t}\n \n+# Check for new packed members, warn to use care\n+\t\tif ($realfile !~ m@\\binclude/uapi/@ &&\n+\t\t $line =~ /\\b(__attribute__\\s*\\(\\s*\\(.*\\bpacked|__packed)\\b/) {\n+\t\t\tWARN(\"NEW_PACKED\",\n+\t\t\t \"Adding new packed members is to be done with care\\n\" . $herecurr);\n+\t\t}\n+\n # Check for __attribute__ aligned, prefer __aligned\n \t\tif ($realfile !~ m@\\binclude/uapi/@ &&\n \t\t $line =~ /\\b__attribute__\\s*\\(\\s*\\(.*aligned/) {\n", "prefixes": [ "U-Boot", "1/1" ] }