Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813117/?format=api
{ "id": 813117, "url": "http://patchwork.ozlabs.org/api/patches/813117/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20170912235441.19238-2-stefan@agner.ch/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170912235441.19238-2-stefan@agner.ch>", "list_archive_url": null, "date": "2017-09-12T23:54:41", "name": "[U-Boot,v3,2/2] imx_common: detect USB serial downloader reliably", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cceab4379c6ae6e7da289c60d467d83b5a2bd192", "submitter": { "id": 4137, "url": "http://patchwork.ozlabs.org/api/people/4137/?format=api", "name": "Stefan Agner", "email": "stefan@agner.ch" }, "delegate": { "id": 1693, "url": "http://patchwork.ozlabs.org/api/users/1693/?format=api", "username": "sbabic", "first_name": "Stefano", "last_name": "Babic", "email": "sbabic@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20170912235441.19238-2-stefan@agner.ch/mbox/", "series": [ { "id": 2789, "url": "http://patchwork.ozlabs.org/api/series/2789/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=2789", "date": "2017-09-12T23:54:40", "name": "[U-Boot,v3,1/2] imx: add macro to detect whether USB PHY is active", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/2789/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813117/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813117/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=agner.ch header.i=@agner.ch header.b=\"LjClKjlx\";\n\tdkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsMB45vW7z9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 09:55:40 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 9AD63C221C5; Tue, 12 Sep 2017 23:55:17 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 93E20C22078;\n\tTue, 12 Sep 2017 23:55:01 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 49286C2203D; Tue, 12 Sep 2017 23:54:58 +0000 (UTC)", "from mail.kmu-office.ch (mail.kmu-office.ch [178.209.48.109])\n\tby lists.denx.de (Postfix) with ESMTPS id D5570C21E4C\n\tfor <u-boot@lists.denx.de>; Tue, 12 Sep 2017 23:54:57 +0000 (UTC)", "from trochilidae.toradex.int\n\t(75-146-58-181-Washington.hfc.comcastbusiness.net [75.146.58.181])\n\tby mail.kmu-office.ch (Postfix) with ESMTPSA id 9217B5C151D;\n\tWed, 13 Sep 2017 01:51:08 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, SPF_HELO_PASS,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "From": "Stefan Agner <stefan@agner.ch>", "To": "sbabic@denx.de,\n\tfabio.estevam@nxp.com,\n\teric@nelint.com", "Date": "Tue, 12 Sep 2017 16:54:41 -0700", "Message-Id": "<20170912235441.19238-2-stefan@agner.ch>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170912235441.19238-1-stefan@agner.ch>", "References": "<20170912235441.19238-1-stefan@agner.ch>", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim;\n\tt=1505260271; bh=5RhxZUxkh33hG/ZgXxMdaabZAYoLDtD8Z+AFSXuPRB4=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References;\n\tb=LjClKjlxwQHo05mPuz11qpBN5sqV/iN/c4HFKfF76MsZWm9a8sQCnaDBex6gJJOMikWLS0Dowim05tcRkkwAjdmjLw00dQHUUwSnfRLNM6i8tXFjH/lrtbuDazU+9AeMmCuqX0AUz7nQMnq1YP4TwDKwtIRiCq+2MQH59xGUZ0A=", "Cc": "marex@denx.de, albert.u.boot@aribaud.net,\n\tStefan Agner <stefan.agner@toradex.com>,\n\tgary.bisson@boundarydevices.com, \n\tMarcel Ziswiler <marcel.ziswiler@toradex.com>,\n\tjoel.esponde@honeywell.com, \n\tu-boot@lists.denx.de, Max Krummenacher <max.krummenacher@toradex.com>,\n\tjagan@openedev.com", "Subject": "[U-Boot] [PATCH v3 2/2] imx_common: detect USB serial downloader\n\treliably", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "From: Stefan Agner <stefan.agner@toradex.com>\n\nThe current mechanism using SCR/GPR registers work well when\nthe serial downloader boot mode has been selected explicitly\n(either via boot mode pins or using bmode command). However,\nin case the system entered boot ROM due to unbootable primary\nboot devices (e.g. empty eMMC), the SPL fails to detect that\nit has been downloaded through serial loader and tries to\ncontinue booting from eMMC:\n Trying to boot from MMC1\n mmc_load_image_raw_sector: mmc block read error\n SPL: failed to boot from all boot devices\n ### ERROR ### Please RESET the board ###\n\nThe only known way to reliably detect USB serial downloader\nis by checking the USB PHY receiver block power state...\n\nSigned-off-by: Stefan Agner <stefan.agner@toradex.com>\nAcked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>\nTested-by: Fabio Estevam <fabio.estevam@nxp.com>\n---\n\nChanges in v3:\n- Fix spelling and grammar\n\nChanges in v2:\n- Add comment that we infer boot ROM behavior from USB PHY state\n\n arch/arm/mach-imx/spl.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c\nindex 258578ac25..522ab9f260 100644\n--- a/arch/arm/mach-imx/spl.c\n+++ b/arch/arm/mach-imx/spl.c\n@@ -31,6 +31,18 @@ u32 spl_boot_device(void)\n \tif (((bmode >> 24) & 0x03) == 0x01) /* Serial Downloader */\n \t\treturn BOOT_DEVICE_BOARD;\n \n+\t/*\n+\t * The above method does not detect that the boot ROM used\n+\t * serial downloader in case the boot ROM decided to use the\n+\t * serial downloader as a fall back (primary boot source failed).\n+\t *\n+\t * Infer that the boot ROM used the USB serial downloader by\n+\t * checking whether the USB PHY is currently active... This\n+\t * assumes that SPL did not (yet) initialize the USB PHY...\n+\t */\n+\tif (is_usbphy_active())\n+\t\treturn BOOT_DEVICE_BOARD;\n+\n \t/* BOOT_CFG1[7:4] - see IMX6DQRM Table 8-8 */\n \tswitch ((reg & IMX6_BMODE_MASK) >> IMX6_BMODE_SHIFT) {\n \t /* EIM: See 8.5.1, Table 8-9 */\n", "prefixes": [ "U-Boot", "v3", "2/2" ] }