Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812814/?format=api
{ "id": 812814, "url": "http://patchwork.ozlabs.org/api/patches/812814/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1505218205-2637-1-git-send-email-nikolay@cumulusnetworks.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505218205-2637-1-git-send-email-nikolay@cumulusnetworks.com>", "list_archive_url": null, "date": "2017-09-12T12:10:05", "name": "[net] net: bonding: fix tlb_dynamic_lb default value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d7b1e4ec94a5119b4a8d45a5e708cabe9a3d7861", "submitter": { "id": 66448, "url": "http://patchwork.ozlabs.org/api/people/66448/?format=api", "name": "Nikolay Aleksandrov", "email": "nikolay@cumulusnetworks.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1505218205-2637-1-git-send-email-nikolay@cumulusnetworks.com/mbox/", "series": [ { "id": 2684, "url": "http://patchwork.ozlabs.org/api/series/2684/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=2684", "date": "2017-09-12T12:10:05", "name": "[net] net: bonding: fix tlb_dynamic_lb default value", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2684/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812814/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812814/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"OCE0CTLb\"; \n\tdkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs3Xf1b52z9sRm\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 12 Sep 2017 22:10:41 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751444AbdILMKX (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 12 Sep 2017 08:10:23 -0400", "from mail-wr0-f169.google.com ([209.85.128.169]:34171 \"EHLO\n\tmail-wr0-f169.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751373AbdILMKV (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 12 Sep 2017 08:10:21 -0400", "by mail-wr0-f169.google.com with SMTP id v109so21449834wrc.1\n\tfor <netdev@vger.kernel.org>; Tue, 12 Sep 2017 05:10:21 -0700 (PDT)", "from debil.mediahub-bg.com (46-10-142-144.ip.btc-net.bg.\n\t[46.10.142.144]) by smtp.gmail.com with ESMTPSA id\n\tx185sm630243wmx.35.2017.09.12.05.10.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 12 Sep 2017 05:10:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=from:to:cc:subject:date:message-id;\n\tbh=k5LhDEVaITb5pP7/GK7O8DUrmwwpKHujLqy/X7xCsxg=;\n\tb=OCE0CTLbMz9PJU798SjZBzCROfRjs37LdvP1dKnqmJMyD3ES9G1mZi6NsmAjShsl2/\n\tNTA3zkrFBdU94oKwK1QY2JUOvy3EoFZO+l0yVlgCUhdsf1wDBJ+IvBlk4udLtOxOU8+Y\n\tHEAsYH4YZMt3dNv+2KTa02DKvqWo3tNDibJUc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=k5LhDEVaITb5pP7/GK7O8DUrmwwpKHujLqy/X7xCsxg=;\n\tb=YRF2cwp7ivPRxipiy40O2PRUK2iYzp0E704a/9Z2EjNe+ii9ol0hxq0iFwO0YPK2Ga\n\t4QwmqLSDYLFDXNZUjILS2gQqsI4nbOMi3WbL8nAreCwoQDkhqfU6H2dr9Br3EW//VQq/\n\t8CrwV37GFEWbyZg5Qa0vMYQiioPVuSCPdrFWs1/+P/wblxh5vylsr/qepRWCBkFsLgFe\n\tMPQL86WrRuawHtcrJvyBNoqVKMxi0Mcql2G3d0mGV7OWAO0EsHGsQgH7jPjnMhl8UgNz\n\tGQQqciR6YraOsVAHILzMYey3alDsH1+ugTDzBBvyxqguO10DWU0FDcU8OXvpwB3P/Kfm\n\t0hUw==", "X-Gm-Message-State": "AHPjjUgFmiLzABoYlaA3plNucjoMYjnrLax27dFjkwTVVS4xgiV71zGY\n\tKBY3PprIDcxgjetOTh8=", "X-Google-Smtp-Source": "ADKCNb62V+alwCcttAQ26qe34wLcW5Yc28E3szTrQjUr5kepmERtVskhQvpwjvUaLSfKdma2MQtALA==", "X-Received": "by 10.223.131.193 with SMTP id 59mr11826349wre.157.1505218220171;\n\tTue, 12 Sep 2017 05:10:20 -0700 (PDT)", "From": "Nikolay Aleksandrov <nikolay@cumulusnetworks.com>", "To": "netdev@vger.kernel.org", "Cc": "j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,\n\tmaheshb@google.com, Nikolay Aleksandrov <nikolay@cumulusnetworks.com>", "Subject": "[PATCH net] net: bonding: fix tlb_dynamic_lb default value", "Date": "Tue, 12 Sep 2017 15:10:05 +0300", "Message-Id": "<1505218205-2637-1-git-send-email-nikolay@cumulusnetworks.com>", "X-Mailer": "git-send-email 2.1.4", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Commit 8b426dc54cf4 (\"bonding: remove hardcoded value\") changed the\ndefault value for tlb_dynamic_lb which lead to either broken ALB mode\n(since tlb_dynamic_lb can be changed only in TLB) or setting TLB mode\nwith tlb_dynamic_lb equal to 0.\nThe first issue was recently fixed by setting tlb_dynamic_lb to 1 always\nwhen switching to ALB mode, but the default value is still wrong and\nwe'll enter TLB mode with tlb_dynamic_lb equal to 0 if the mode is\nchanged via netlink or sysfs. In order to restore the previous behaviour\nand default value simply remove the mode check around the default param\ninitialization for tlb_dynamic_lb which will always set it to 1 as\nbefore.\n\nFixes: 8b426dc54cf4 (\"bonding: remove hardcoded value\")\nSigned-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>\n---\n drivers/net/bonding/bond_main.c | 17 +++++++----------\n 1 file changed, 7 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c\nindex fc63992ab0e0..c99dc59d729b 100644\n--- a/drivers/net/bonding/bond_main.c\n+++ b/drivers/net/bonding/bond_main.c\n@@ -4289,7 +4289,7 @@ static int bond_check_params(struct bond_params *params)\n \tint bond_mode\t= BOND_MODE_ROUNDROBIN;\n \tint xmit_hashtype = BOND_XMIT_POLICY_LAYER2;\n \tint lacp_fast = 0;\n-\tint tlb_dynamic_lb = 0;\n+\tint tlb_dynamic_lb;\n \n \t/* Convert string parameters. */\n \tif (mode) {\n@@ -4601,16 +4601,13 @@ static int bond_check_params(struct bond_params *params)\n \t}\n \tad_user_port_key = valptr->value;\n \n-\tif ((bond_mode == BOND_MODE_TLB) || (bond_mode == BOND_MODE_ALB)) {\n-\t\tbond_opt_initstr(&newval, \"default\");\n-\t\tvalptr = bond_opt_parse(bond_opt_get(BOND_OPT_TLB_DYNAMIC_LB),\n-\t\t\t\t\t&newval);\n-\t\tif (!valptr) {\n-\t\t\tpr_err(\"Error: No tlb_dynamic_lb default value\");\n-\t\t\treturn -EINVAL;\n-\t\t}\n-\t\ttlb_dynamic_lb = valptr->value;\n+\tbond_opt_initstr(&newval, \"default\");\n+\tvalptr = bond_opt_parse(bond_opt_get(BOND_OPT_TLB_DYNAMIC_LB), &newval);\n+\tif (!valptr) {\n+\t\tpr_err(\"Error: No tlb_dynamic_lb default value\");\n+\t\treturn -EINVAL;\n \t}\n+\ttlb_dynamic_lb = valptr->value;\n \n \tif (lp_interval == 0) {\n \t\tpr_warn(\"Warning: ip_interval must be between 1 and %d, so it was reset to %d\\n\",\n", "prefixes": [ "net" ] }