Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812782/?format=api
{ "id": 812782, "url": "http://patchwork.ozlabs.org/api/patches/812782/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/patch/20170912111250.31576-6-sojkam1@fel.cvut.cz/", "project": { "id": 54, "url": "http://patchwork.ozlabs.org/api/projects/54/?format=api", "name": "LEDE development", "link_name": "lede", "list_id": "lede-dev.lists.infradead.org", "list_email": "lede-dev@lists.infradead.org", "web_url": "http://lede-project.org/", "scm_url": "", "webscm_url": "http://git.lede-project.org/", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170912111250.31576-6-sojkam1@fel.cvut.cz>", "list_archive_url": null, "date": "2017-09-12T11:12:35", "name": "[LEDE-DEV,procd,03/17] Do not disable seccomp when configuration is not found", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7773d7c48fd57af37e867a06034f07dcc8e2e38a", "submitter": { "id": 14651, "url": "http://patchwork.ozlabs.org/api/people/14651/?format=api", "name": "Michal Sojka", "email": "sojkam1@fel.cvut.cz" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/lede/patch/20170912111250.31576-6-sojkam1@fel.cvut.cz/mbox/", "series": [ { "id": 2665, "url": "http://patchwork.ozlabs.org/api/series/2665/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/list/?series=2665", "date": "2017-09-12T11:12:36", "name": "[LEDE-DEV,procd,01/17] utrace: Fix environment initialization", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2665/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812782/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812782/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"b2ftD8UB\"; \n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs2Ls4dr1z9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 21:17:09 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drjBa-00081q-CF; Tue, 12 Sep 2017 11:16:58 +0000", "from smtpx.feld.cvut.cz ([147.32.192.33])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drj8i-0004Y1-VT\n\tfor lede-dev@lists.infradead.org; Tue, 12 Sep 2017 11:14:11 +0000", "from localhost (unknown [192.168.200.7])\n\tby smtpx.feld.cvut.cz (Postfix) with ESMTP id 9EF53DC3D0;\n\tTue, 12 Sep 2017 13:13:15 +0200 (CEST)", "from smtpx.feld.cvut.cz ([192.168.200.6])\n\tby localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new,\n\tport 10054)\n\twith ESMTP id X77GKhbZk6At; Tue, 12 Sep 2017 13:13:14 +0200 (CEST)", "from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\n\tby smtpx.feld.cvut.cz (Postfix) with ESMTP id F1A40DC3D1;\n\tTue, 12 Sep 2017 13:13:12 +0200 (CEST)", "from wsh by steelpick.2x.cz with local (Exim 4.89)\n\t(envelope-from <sojkam1@fel.cvut.cz>)\n\tid 1drj7x-0008EG-00; Tue, 12 Sep 2017 13:13:13 +0200" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References:\n\tIn-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=ki8gbRs2Kf39J0dA6z9X67kgWJZWzMw1A2FFZUZi7lM=;\n\tb=b2ftD8UB41Lb6J\n\t3d0W6SsaNI19HE44WP1zhd6zQ7Q/Avc+Kdw5JeXXju+/mLnFjymvJmqeiU6tjzbpGyOQkv8wSRv2K\n\twMx3iaisLqsJ+2KvQKHYvEBHdR9C9gmAT6dzikyFzw6nK50b+Ozqh9NaHfZzDSCLI+hiNp6Xz8l8M\n\tTWCJ7+vwc7F7bWDTcXlhu6d8JG47KTqL1w2xPARNHomW6ClT+YYyqRe+1zOxLjG53+iGdFrk9e5U7\n\tY2JLwHJ9kFD651Mto4GAQBF8Y1H3fq0BbL6ekMQ0OkOEZodWjxg3H5CRZRw8pKZt+FaCKfTG26YX5\n\tVMDYVYldF+udct0O6Xzg==;", "X-Virus-Scanned": "IMAP STYX AMAVIS", "From": "Michal Sojka <sojkam1@fel.cvut.cz>", "To": "lede-dev@lists.infradead.org", "Date": "Tue, 12 Sep 2017 13:12:35 +0200", "Message-Id": "<20170912111250.31576-6-sojkam1@fel.cvut.cz>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170912111250.31576-1-sojkam1@fel.cvut.cz>", "References": "<20170912111250.31576-1-sojkam1@fel.cvut.cz>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170912_041401_321569_684E63FA ", "X-CRM114-Status": "UNSURE ( 8.03 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-4.2 (----)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [147.32.192.33 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]", "Subject": "[LEDE-DEV] [PATCH procd 03/17] Do not disable seccomp when\n\tconfiguration is not found", "X-BeenThere": "lede-dev@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<lede-dev.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/lede-dev/>", "List-Post": "<mailto:lede-dev@lists.infradead.org>", "List-Help": "<mailto:lede-dev-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>", "Cc": "Michal Sojka <sojkam1@fel.cvut.cz>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>", "Errors-To": "lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Previously, when seccomp configuration file for a service was not\nfound, the service was started without seccomp. I consider this\npotential attack vector.\n\nWith this change, procd starts the service as if the configuration\nexisted but the service fails in libpreload-seccomp.so, because the\nconfiguration cannot be loaded. This is announced in the syslog.\n\nSigned-off-by: Michal Sojka <sojkam1@fel.cvut.cz>\n---\n service/instance.c | 11 ++---------\n 1 file changed, 2 insertions(+), 9 deletions(-)", "diff": "diff --git a/service/instance.c b/service/instance.c\nindex bb766ea..dc7e3ca 100644\n--- a/service/instance.c\n+++ b/service/instance.c\n@@ -873,15 +873,8 @@ instance_config_parse(struct service_instance *in)\n \tif (tb[INSTANCE_ATTR_NO_NEW_PRIVS])\n \t\tin->no_new_privs = blobmsg_get_bool(tb[INSTANCE_ATTR_NO_NEW_PRIVS]);\n \n-\tif (!in->trace && tb[INSTANCE_ATTR_SECCOMP]) {\n-\t\tchar *seccomp = blobmsg_get_string(tb[INSTANCE_ATTR_SECCOMP]);\n-\t\tstruct stat s;\n-\n-\t\tif (stat(seccomp, &s))\n-\t\t\tERROR(\"%s: not starting seccomp as %s is missing\\n\", in->name, seccomp);\n-\t\telse\n-\t\t\tin->seccomp = seccomp;\n-\t}\n+\tif (!in->trace && tb[INSTANCE_ATTR_SECCOMP])\n+\t\tin->seccomp = blobmsg_get_string(tb[INSTANCE_ATTR_SECCOMP]);\n \n \tif (tb[INSTANCE_ATTR_PIDFILE]) {\n \t\tchar *pidfile = blobmsg_get_string(tb[INSTANCE_ATTR_PIDFILE]);\n", "prefixes": [ "LEDE-DEV", "procd", "03/17" ] }