Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812779/?format=api
{ "id": 812779, "url": "http://patchwork.ozlabs.org/api/patches/812779/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/patch/20170912111250.31576-8-sojkam1@fel.cvut.cz/", "project": { "id": 54, "url": "http://patchwork.ozlabs.org/api/projects/54/?format=api", "name": "LEDE development", "link_name": "lede", "list_id": "lede-dev.lists.infradead.org", "list_email": "lede-dev@lists.infradead.org", "web_url": "http://lede-project.org/", "scm_url": "", "webscm_url": "http://git.lede-project.org/", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170912111250.31576-8-sojkam1@fel.cvut.cz>", "list_archive_url": null, "date": "2017-09-12T11:12:37", "name": "[LEDE-DEV,procd,05/17] utrace: Sort syscalls by number of invocations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6c544465975579e8919dac7e1c70e9dba49e9ff9", "submitter": { "id": 14651, "url": "http://patchwork.ozlabs.org/api/people/14651/?format=api", "name": "Michal Sojka", "email": "sojkam1@fel.cvut.cz" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/lede/patch/20170912111250.31576-8-sojkam1@fel.cvut.cz/mbox/", "series": [ { "id": 2665, "url": "http://patchwork.ozlabs.org/api/series/2665/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/list/?series=2665", "date": "2017-09-12T11:12:36", "name": "[LEDE-DEV,procd,01/17] utrace: Fix environment initialization", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2665/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812779/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812779/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"L00u9hfz\"; \n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs2Ks6hYqz9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 21:16:17 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drjAp-0007Nw-BQ; Tue, 12 Sep 2017 11:16:11 +0000", "from smtpx.feld.cvut.cz ([147.32.192.33])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drj8i-0004Yh-VU\n\tfor lede-dev@lists.infradead.org; Tue, 12 Sep 2017 11:14:06 +0000", "from localhost (unknown [192.168.200.7])\n\tby smtpx.feld.cvut.cz (Postfix) with ESMTP id E1429DC3DC;\n\tTue, 12 Sep 2017 13:13:15 +0200 (CEST)", "from smtpx.feld.cvut.cz ([192.168.200.6])\n\tby localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new,\n\tport 10054)\n\twith ESMTP id yRzERkUB0CTE; Tue, 12 Sep 2017 13:13:14 +0200 (CEST)", "from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\n\tby smtpx.feld.cvut.cz (Postfix) with ESMTP id 2A4F4DC3D9;\n\tTue, 12 Sep 2017 13:13:13 +0200 (CEST)", "from wsh by steelpick.2x.cz with local (Exim 4.89)\n\t(envelope-from <sojkam1@fel.cvut.cz>)\n\tid 1drj7x-0008EM-3b; Tue, 12 Sep 2017 13:13:13 +0200" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References:\n\tIn-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=eJ2MGoPA9mhAZqF7cS4WKb4j2p/8gC+hRZdvuYvgSGU=;\n\tb=L00u9hfzGtfmA/\n\tAwSmWyt81/PfqwwyiW2l2H9J+IfSKgaq6ZPrfBVdEWXvbAtQ4NYtsD91xZ2bbpJGy5FH96BY7iTuA\n\tsyPX3BXERtH1PjSwoP1oRBBnD3GGI6VD+KdqIySpRmNul7jtwt5vBQc09KN5i4Yyp8b60JMYVIWAl\n\tZ1Ue18qn1wr3xWu5rTZjyAr5wrpEdZXq5xtBoRrd3ljS6C+3+DnNqA2qJAXnCFJesSL0FategS/bm\n\tUZftlix5krpIi9u/0LdbC9CWyQqG5bXFkkdtuwg4onOyxrQbPCK61JyucNXuGYaBbeHLuutiLYcmC\n\tQLrd6F1MvVUjyxHbskjw==;", "X-Virus-Scanned": "IMAP STYX AMAVIS", "From": "Michal Sojka <sojkam1@fel.cvut.cz>", "To": "lede-dev@lists.infradead.org", "Date": "Tue, 12 Sep 2017 13:12:37 +0200", "Message-Id": "<20170912111250.31576-8-sojkam1@fel.cvut.cz>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170912111250.31576-1-sojkam1@fel.cvut.cz>", "References": "<20170912111250.31576-1-sojkam1@fel.cvut.cz>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170912_041401_264342_1D069AB0 ", "X-CRM114-Status": "UNSURE ( 9.28 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-4.2 (----)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [147.32.192.33 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]", "Subject": "[LEDE-DEV] [PATCH procd 05/17] utrace: Sort syscalls by number of\n\tinvocations", "X-BeenThere": "lede-dev@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<lede-dev.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/lede-dev/>", "List-Post": "<mailto:lede-dev@lists.infradead.org>", "List-Help": "<mailto:lede-dev-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>", "Cc": "Michal Sojka <sojkam1@fel.cvut.cz>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>", "Errors-To": "lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "seccomp and service jailing announce email [1] mentioned that \"utrace\ntool will sort the syscalls by the number of invocations\". The code\ndid not do that until this commit.\n\n[1] https://lists.openwrt.org/pipermail/openwrt-devel/2015-March/032197.html\n\nSigned-off-by: Michal Sojka <sojkam1@fel.cvut.cz>\n---\n trace/trace.c | 32 ++++++++++++++++++++++++++------\n 1 file changed, 26 insertions(+), 6 deletions(-)", "diff": "diff --git a/trace/trace.c b/trace/trace.c\nindex 65fe067..35bc548 100644\n--- a/trace/trace.c\n+++ b/trace/trace.c\n@@ -77,6 +77,16 @@ static void set_syscall(const char *name, int val)\n \t\t}\n }\n \n+struct syscall {\n+\tint syscall;\n+\tint count;\n+};\n+\n+static int cmp_count(const void *a, const void *b)\n+{\n+\treturn ((struct syscall*)b)->count - ((struct syscall*)a)->count;\n+}\n+\n static void print_syscalls(int policy, const char *json)\n {\n \tvoid *c;\n@@ -88,19 +98,29 @@ static void print_syscalls(int policy, const char *json)\n \tset_syscall(\"exit_group\", 1);\n \tset_syscall(\"exit\", 1);\n \n+\tstruct syscall sorted[ARRAY_SIZE(syscall_names)];\n+\n+\tfor (i = 0; i < ARRAY_SIZE(syscall_names); i++) {\n+\t\tsorted[i].syscall = i;\n+\t\tsorted[i].count = syscall_count[i];\n+\t}\n+\n+\tqsort(sorted, ARRAY_SIZE(syscall_names), sizeof(sorted[0]), cmp_count);\n+\n \tblob_buf_init(&b, 0);\n \tc = blobmsg_open_array(&b, \"whitelist\");\n \n \tfor (i = 0; i < ARRAY_SIZE(syscall_names); i++) {\n-\t\tif (!syscall_count[i])\n-\t\t\tcontinue;\n-\t\tif (syscall_names[i]) {\n+\t\tint sc = sorted[i].syscall;\n+\t\tif (!sorted[i].count)\n+\t\t\tbreak;\n+\t\tif (syscall_names[sc]) {\n \t\t\tif (debug)\n \t\t\t\tprintf(\"syscall %d (%s) was called %d times\\n\",\n-\t\t\t\t\ti, syscall_names[i], syscall_count[i]);\n-\t\t\tblobmsg_add_string(&b, NULL, syscall_names[i]);\n+\t\t\t\t\tsc, syscall_names[sc], sorted[i].count);\n+\t\t\tblobmsg_add_string(&b, NULL, syscall_names[sc]);\n \t\t} else {\n-\t\t\tERROR(\"no name found for syscall(%d)\\n\", i);\n+\t\t\tERROR(\"no name found for syscall(%d)\\n\", sc);\n \t\t}\n \t}\n \tblobmsg_close_array(&b, c);\n", "prefixes": [ "LEDE-DEV", "procd", "05/17" ] }