Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812738/?format=api
{ "id": 812738, "url": "http://patchwork.ozlabs.org/api/patches/812738/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1505206676-13222-1-git-send-email-patrick.delaunay@st.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505206676-13222-1-git-send-email-patrick.delaunay@st.com>", "list_archive_url": null, "date": "2017-09-12T08:57:56", "name": "[U-Boot,v2] cmd: usb: add check on usb_stor_curr_dev in usb dev command", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "11c7be682af33df18b9deb691b758617eeea2f02", "submitter": { "id": 70437, "url": "http://patchwork.ozlabs.org/api/people/70437/?format=api", "name": "Patrick DELAUNAY", "email": "patrick.delaunay@st.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1505206676-13222-1-git-send-email-patrick.delaunay@st.com/mbox/", "series": [ { "id": 2640, "url": "http://patchwork.ozlabs.org/api/series/2640/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=2640", "date": "2017-09-12T08:57:56", "name": "[U-Boot,v2] cmd: usb: add check on usb_stor_curr_dev in usb dev command", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/2640/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812738/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812738/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrzGd62J6z9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 18:58:17 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 85722C21F95; Tue, 12 Sep 2017 08:58:07 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id F09A9C21DBA;\n\tTue, 12 Sep 2017 08:58:04 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid B4C01C21DBA; Tue, 12 Sep 2017 08:58:03 +0000 (UTC)", "from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com\n\t[91.207.212.93])\n\tby lists.denx.de (Postfix) with ESMTPS id 698F8C21C40\n\tfor <u-boot@lists.denx.de>; Tue, 12 Sep 2017 08:58:03 +0000 (UTC)", "from pps.filterd (m0046661.ppops.net [127.0.0.1])\n\tby mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8C8sY2c005408; Tue, 12 Sep 2017 10:58:00 +0200", "from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35])\n\tby mx08-00178001.pphosted.com with ESMTP id 2cv76c0dg0-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tTue, 12 Sep 2017 10:58:00 +0200", "from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9])\n\tby beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id EE2565C;\n\tTue, 12 Sep 2017 08:57:59 +0000 (GMT)", "from Webmail-eu.st.com (Safex1hubcas21.st.com [10.75.90.44])\n\tby zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D537523F4;\n\tTue, 12 Sep 2017 08:57:59 +0000 (GMT)", "from SAFEX1HUBCAS24.st.com (10.75.90.95) by SAFEX1HUBCAS21.st.com\n\t(10.75.90.44) with Microsoft SMTP Server (TLS) id 14.3.352.0;\n\tTue, 12 Sep 2017 10:57:59 +0200", "from localhost (10.201.23.85) by webmail-ga.st.com (10.75.90.48)\n\twith Microsoft SMTP Server (TLS) id 14.3.352.0;\n\tTue, 12 Sep 2017 10:57:59 +0200" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0", "From": "Patrick Delaunay <patrick.delaunay@st.com>", "To": "<u-boot@lists.denx.de>", "Date": "Tue, 12 Sep 2017 10:57:56 +0200", "Message-ID": "<1505206676-13222-1-git-send-email-patrick.delaunay@st.com>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "X-Originating-IP": "[10.201.23.85]", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-12_04:, , signatures=0", "Cc": "Stefan Roese <sr@denx.de>, Yann Gautier <yann.gautier@st.com>,\n\tMichal Simek <michal.simek@xilinx.com>", "Subject": "[U-Boot] [PATCH v2] cmd: usb: add check on usb_stor_curr_dev in usb\n\tdev command", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "If the command 'usb start' is successfully executed but\nU-Boot don't found a storage device (usb_stor_curr_dev stay to -1)\nthe next command 'usb dev' without parameter\nleads to data abort after the message \"USB device -1\"\n\nThe added check on usb_stor_curr_dev avoid the issue.\n\nSigned-off-by: Patrick Delaunay <patrick.delaunay@st.com>\n---\n\nChanges in v2:\n- Updated the commit message\n- use command_ret_t for result\n\n cmd/usb.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/cmd/usb.c b/cmd/usb.c\nindex 992d414..53305bb 100644\n--- a/cmd/usb.c\n+++ b/cmd/usb.c\n@@ -806,6 +806,10 @@ static int do_usb(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])\n \t\t\tprintf(\"... is now current device\\n\");\n \t\t\treturn 0;\n \t\t} else {\n+\t\t\tif (usb_stor_curr_dev < 0) {\n+\t\t\t\tprintf(\"no current device selected\\n\");\n+\t\t\t\treturn CMD_RET_FAILURE;\n+\t\t\t}\n \t\t\tprintf(\"\\nUSB device %d: \", usb_stor_curr_dev);\n \t\t\tstor_dev = blk_get_devnum_by_type(IF_TYPE_USB,\n \t\t\t\t\t\t\t usb_stor_curr_dev);\n", "prefixes": [ "U-Boot", "v2" ] }