Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812640/?format=api
{ "id": 812640, "url": "http://patchwork.ozlabs.org/api/patches/812640/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170911212131.27262.52988.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170911212131.27262.52988.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2017-09-11T21:21:31", "name": "[1/2] ixgbe: fix use of uninitialized padding", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "16ad377c13f992957e84dd9889eb7bebca31ffca", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170911212131.27262.52988.stgit@localhost6.localdomain6/mbox/", "series": [ { "id": 2584, "url": "http://patchwork.ozlabs.org/api/series/2584/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=2584", "date": "2017-09-11T21:21:31", "name": "[1/2] ixgbe: fix use of uninitialized padding", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2584/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812640/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812640/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrgns4gKPz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 07:20:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 08776862EB;\n\tMon, 11 Sep 2017 21:20:46 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bW03BuLbWYzq; Mon, 11 Sep 2017 21:20:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C8ED0860DC;\n\tMon, 11 Sep 2017 21:20:43 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 485D31C1599\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Sep 2017 21:20:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 412AB860DC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Sep 2017 21:20:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 77ZuWclT-juT for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Sep 2017 21:20:41 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 60F0385F00\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Sep 2017 21:20:41 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Sep 2017 14:20:40 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.177.78])\n\tby fmsmga001.fm.intel.com with ESMTP; 11 Sep 2017 14:20:40 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.42,379,1500966000\"; d=\"scan'208\";\n\ta=\"1193945922\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 11 Sep 2017 14:21:31 -0700", "Message-ID": "<20170911212131.27262.52988.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 1/2] ixgbe: fix use of uninitialized\n\tpadding", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch is resolving Coverity hits where padding in a structure could\nbe used uninitialized.\n\n- Initialize fwd_cmd.pad/2 before ixgbe_calculate_checksum()\n\n- Initialize buffer.pad2/3 before ixgbe_hic_unlocked()\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 4 ++--\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 2 ++\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\nindex 2c19070..041940c 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n@@ -3800,10 +3800,10 @@ s32 ixgbe_set_fw_drv_ver_generic(struct ixgbe_hw *hw, u8 maj, u8 min,\n \tfw_cmd.ver_build = build;\n \tfw_cmd.ver_sub = sub;\n \tfw_cmd.hdr.checksum = 0;\n-\tfw_cmd.hdr.checksum = ixgbe_calculate_checksum((u8 *)&fw_cmd,\n-\t\t\t\t(FW_CEM_HDR_LEN + fw_cmd.hdr.buf_len));\n \tfw_cmd.pad = 0;\n \tfw_cmd.pad2 = 0;\n+\tfw_cmd.hdr.checksum = ixgbe_calculate_checksum((u8 *)&fw_cmd,\n+\t\t\t\t(FW_CEM_HDR_LEN + fw_cmd.hdr.buf_len));\n \n \tfor (i = 0; i <= FW_CEM_MAX_RETRIES; i++) {\n \t\tret_val = ixgbe_host_interface_command(hw, &fw_cmd,\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex 1974f8f..54cdbcd 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -1000,6 +1000,8 @@ static s32 ixgbe_read_ee_hostif_buffer_X550(struct ixgbe_hw *hw,\n \t\t/* convert offset from words to bytes */\n \t\tbuffer.address = cpu_to_be32((offset + current_word) * 2);\n \t\tbuffer.length = cpu_to_be16(words_to_read * 2);\n+\t\tbuffer.pad2 = 0;\n+\t\tbuffer.pad3 = 0;\n \n \t\tstatus = ixgbe_hic_unlocked(hw, (u32 *)&buffer, sizeof(buffer),\n \t\t\t\t\t IXGBE_HI_COMMAND_TIMEOUT);\n", "prefixes": [ "1/2" ] }