Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812573/?format=api
{ "id": 812573, "url": "http://patchwork.ozlabs.org/api/patches/812573/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/ae8f8a7f0a88ded61743dff2adade21f8122a9e7.1505158760.git.alistair.francis@xilinx.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<ae8f8a7f0a88ded61743dff2adade21f8122a9e7.1505158760.git.alistair.francis@xilinx.com>", "list_archive_url": null, "date": "2017-09-11T19:52:50", "name": "[v4,3/8] Convert single line fprintf(.../n) to warn_report()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ba817c3f23ad4a1b62ac9416df86a48bc78ffaab", "submitter": { "id": 47878, "url": "http://patchwork.ozlabs.org/api/people/47878/?format=api", "name": "Alistair Francis", "email": "alistair.francis@xilinx.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/ae8f8a7f0a88ded61743dff2adade21f8122a9e7.1505158760.git.alistair.francis@xilinx.com/mbox/", "series": [ { "id": 2556, "url": "http://patchwork.ozlabs.org/api/series/2556/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2556", "date": "2017-09-11T19:52:38", "name": "More warning reporting fixed", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/2556/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812573/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812573/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=xilinx.onmicrosoft.com\n\theader.i=@xilinx.onmicrosoft.com header.b=\"M8GVOV1l\"; \n\tdkim-atps=neutral", "spf=pass (sender IP is 149.199.60.100)\n\tsmtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed)\n\theader.d=none;redhat.com; dmarc=bestguesspass action=none\n\theader.from=xilinx.com;" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrf0T4Kz3z9s0Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 05:59:53 +1000 (AEST)", "from localhost ([::1]:60226 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drUs3-0008N6-Le\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 15:59:51 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:39887)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <alistai@xilinx.com>) id 1drUov-00062K-HK\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:56:39 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <alistai@xilinx.com>) id 1drUor-00024r-Ob\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:56:37 -0400", "from mail-co1nam03on0051.outbound.protection.outlook.com\n\t([104.47.40.51]:15574\n\thelo=NAM03-CO1-obe.outbound.protection.outlook.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <alistai@xilinx.com>) id 1drUor-00023k-AU\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:56:33 -0400", "from MWHPR0201CA0076.namprd02.prod.outlook.com (10.167.161.17) by\n\tBLUPR02MB1124.namprd02.prod.outlook.com (10.163.79.150) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.56.9; Mon, 11 Sep 2017 19:56:28 +0000", "from BL2NAM02FT034.eop-nam02.prod.protection.outlook.com\n\t(2a01:111:f400:7e46::209) by MWHPR0201CA0076.outlook.office365.com\n\t(2603:10b6:301:75::17) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8 via\n\tFrontend Transport; Mon, 11 Sep 2017 19:56:28 +0000", "from xsj-pvapsmtpgw02 (149.199.60.100) by\n\tBL2NAM02FT034.mail.protection.outlook.com (10.152.77.161) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.13.11\n\tvia Frontend Transport; Mon, 11 Sep 2017 19:56:27 +0000", "from unknown-38-66.xilinx.com ([149.199.38.66]:45251\n\thelo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63)\n\t(envelope-from <alistair.francis@xilinx.com>)\n\tid 1drUol-0001Pn-1X; Mon, 11 Sep 2017 12:56:27 -0700", "from [127.0.0.1] (helo=localhost)\n\tby xsj-pvapsmtp01 with smtp (Exim 4.63)\n\t(envelope-from <alistair.francis@xilinx.com>)\n\tid 1drUok-0008Vd-Tm; Mon, 11 Sep 2017 12:56:26 -0700", "from xsj-pvapsmtp01 (smtp.xilinx.com [149.199.38.66])\n\tby xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id\n\tv8BJuOIS017517; Mon, 11 Sep 2017 12:56:24 -0700", "from [172.19.2.220] (helo=localhost.localdomain)\n\tby xsj-pvapsmtp01 with esmtp (Exim 4.63)\n\t(envelope-from <alistair.francis@xilinx.com>)\n\tid 1drUoi-0008VG-JY; Mon, 11 Sep 2017 12:56:24 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=xilinx.onmicrosoft.com; s=selector1-xilinx-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=ezKPdxRF2PqD8cpBLHUB1URg9BZgPAndfVT4q+Kr1lg=;\n\tb=M8GVOV1lR/W0BZnQqJ9a0w2NfrpIasnGKmHY1ykSCs/imWSOCmOlISvJcZV9Oj+3iCc5vPAHcB8C4AaYw2gtZ14hT8JmJcPF9qo/kMw9Hz+mNuw/diRnhleGkTgMpawHm6jgV20KiCclGjD9NWyVSySYUH81/evu2nHuiX06T6k=", "Received-SPF": "Pass (protection.outlook.com: domain of xilinx.com designates\n\t149.199.60.100 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=149.199.60.100; helo=xsj-pvapsmtpgw02;", "From": "Alistair Francis <alistair.francis@xilinx.com>", "To": "<qemu-devel@nongnu.org>", "Date": "Mon, 11 Sep 2017 12:52:50 -0700", "Message-ID": "<ae8f8a7f0a88ded61743dff2adade21f8122a9e7.1505158760.git.alistair.francis@xilinx.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<cover.1505158760.git.alistair.francis@xilinx.com>", "References": "<cover.1505158760.git.alistair.francis@xilinx.com>", "X-RCIS-Action": "ALLOW", "X-TM-AS-Product-Ver": "IMSS-7.1.0.1224-8.1.0.1062-23322.005", "X-TM-AS-User-Approved-Sender": "Yes;Yes", "X-EOPAttributedMessage": "0", "X-MS-Office365-Filtering-HT": "Tenant", "X-Forefront-Antispam-Report": "CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; \n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(2980300002)(438002)(189002)(199003)(36386004)(50986999)(2950100002)(54906002)(4326008)(6916009)(478600001)(76176999)(36756003)(6666003)(2906002)(5660300001)(81156014)(81166006)(110136004)(39060400002)(356003)(77096006)(8676002)(5003940100001)(48376002)(8936002)(189998001)(106466001)(305945005)(63266004)(50466002)(47776003)(7416002)(9786002)(118296001)(575784001)(2351001)(50226002)(33646002)(107986001)(5001870100001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR02MB1124; H:xsj-pvapsmtpgw02;\n\tFPR:; SPF:Pass; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;\n\tMX:1; A:1; LANG:en; ", "X-Microsoft-Exchange-Diagnostics": [ "1; BL2NAM02FT034;\n\t1:/h+dqcJwnRYPQEy5a4BC0AD4SlQZF4dMHzTteRLz6a47h2WIXpmPtITyd6z9vZnD11BoV459aXTtQ4TWpgLTwVFwUn1NvZ4PchZwVKP7RaYqngd6YGMG4HXgnM6xw5EI", "1; BLUPR02MB1124;\n\t3:4/5qPB0dMCHFBx3xkqsnsDEG+pvihRRbx+xT0oUZk78qYUDgYgEUAQKzlbb3eiW3Cpvq0KDXWfm8KXyZeqI7ypHREPpb676kl15Z66KEFr2QgoDCVU3H0fgk76xgDz3Ziga4mTom6+8TmbTvXTjGmAFguNGfYhgC0s7n1y0QNS5qrj1ctyD/8j7YFopUj5soJwZcgnU1rj2aEtRzUdYnLfT/q3HNjRjFmQb5alGyNLbymUB0SwPi9xExtMhmemWjHS9AouyQesrOgvRfQVw6ZkvtOZCKLILxrsM15L96gHEj98p5KNhCdAY4aaLqnhoh+78bQ5QMh/S12dsku5Dwd+9pdw/6jMbf6Gf2Ijf8Msw=;\n\t25:GtTG2la3uRAj6r6rfq/wAdYWJEoDEhd1kl+MALsPAOUfAnj0cvgkCiqje4E90rDz7OgrCd9G5Xm+DFr2VLHZFLzdhTD/6aPZHDz5LxmJINvqHSPgtL5qD+hVnGPBG0Q5AteYDtfQd9l28ZO/M9TR0k6DQy5YwnAUh5wYhQIp8WaIr7n8E4F8HdlRoCtzm2zKAmaHwfoGCosPi7/0f2z+F8gxWtprN+yFYUeaqwlWV4u4zyl7Ls2r3Zv4yON9+4wHtYLhNwhWSWSquwED6XRLKp6oW20Ns1WCsg0LACy0K8iINBZjTr5Fp497Hw/1TA6qGhWCX+bozoBwL4c3XqBZtA==", "1; BLUPR02MB1124;\n\t31:iM3rAOzhFP2EspsbNhMoTwD8a+T0wtvDFdNJFISmuktu+L7NPHtMaJhw2qF6DPX/9tPFPtt57JnY/y8DGVXE267duT8dG8NnTLldEAdrX90jciWIJWQzPOKdI4nBJxlyywzrPZyVb9xn/Lp/scSN7VTICwfL3kw1bY7HHI2afGo9uZZ/+Mdw4pHzqfvOb3ihPxQZPbwlwGCTtCJAE408MyKCntmYAVWHQyQsEB/PeoM=;\n\t20:AGj9NLF4msMuw+M7h/8WF+nhSb3Zm0Omcl5JLPVeP6x3yQM6BO2akTIk+ss1U74WiTENSHF4v/FP/eSWAE/Uqvg+x+zj+eCuS8JrUFCCUdkhldHW1v+NoC98Y8IRIs44sk3G2rtrDwrnzpgDR8zqAQsKdP4duQjsnq7j3ryDpyOOJItW+JcWvM32GxZQwPJW+zSYJikA0N8nSM1E95PtM5gRcfKxMfu1TeLZqng9Box8vRc64ezN9c3yHiF/sflID0rbKrbmZABBWCaBKx60nXqBw7i0gUlaux+ABlbEr2nHKzDv0t7vUZyxLoaOB96bIlxUdFiNU1zUsb2MuxH0dkwXV3eOusTvyJX6DjSCyq/eICuP9vkA75+yhp7TZrgyb5bUmaL8KtIJ1kplUl4RWZ4pRg4okrBq4ja6XVvVcAcVorT8d8rJH8FDSmSiJ4ZnGhjcweDwHicDqTdFmeGcUzlhIAB1saypGYbWxCGeXfsMIFc6W5ePxORG4prgyLUI", "1; BLUPR02MB1124;\n\t4:nGbhEmP4ps1mKwkl8NljBXJMML8XKwr+BBMkY6CCVFkfQdYfFQDzU6Q3Mjxd8zsY3mh8dq6+BEs40gmIf3m3ewcOyLZZawQs24a/YjUh3XOspJuX5PaKt+NkkBF2EfpLY5Dl7YrXlekWxQqHcitmAnej1X3Dq4WoRZiqoa7ysGZoeHYxTcg0Wl4HE3OSQSDksF0xKpkFJSmoD45ttcBYHXTvYOt/Ti1pbl072tkPWFiWC9sjjBU9zr8u5iNmW3QC24QkFp+7IvQuf5+KD7ygqJ/kjPgQ5Z8rrq52q6Db6BONCdznLJiQA400V+FcFJGubcRipvTC9lw7reDnaaUlJQ==", "=?us-ascii?Q?1; BLUPR02MB1124;\n\t23:NdW1gNoQY0qK0gOHPwzdhYp5gzksbdh9XUoOfHZeA?=\n\tTttrsvkEq4tNT7kuSaLoJHyIR6Jqrbhzd3OyAh7wq3wT5hyGWkNSp7Od6ijgKwbAlZmgtIPY9n9N8QaZwdUatY+9l+YipruHwhlrocHgsHXv27qWdKVy3QsLtZzokFIp/WByxT0O0svmEmAS3ODmiTK4gIh2oSY6kCVTBXmHhr+NimwRFUY9Ycw1J1nG5d6V4gp2yQ0995ML6ejyUzeFN6aDgoDpMqv6FL6krg1EvmlTOkFOTARWe5VCOIcHZ++s3MXhypjEQ6Hd9cpMxz1IfgM8NRAQJuytKThuhEYY64D96GaTpiiqWoXVsWitYMpHPK0F2FyuIX5BJsSkgCEsku8YExOtYUKvm2TN58STsSeGivyb2dviCfw7ic9qwJxvRy7TfkMHMSHhHmsM82j+E9hgVAvQBbSuzg6pmVu93OWrac5ohUPN2ABmdYnFC4d7XFUbQ0w6/D0Z9SnE6u5DOgJQEPixavpWSrrGk+SL7Rn4nCMyQ5bTIhN2VYRKVZV0Zo/A1Q2FQUZAGynwo8WXEkmuon4eOv0Pbb9HDq1dxjTZ01Fvcg5zhnKkwg6wFVcEUSCKPhl46DCh7suqBmqXa13j92MDrTEOX8DdzDIfzd5vka59YKWTjeyw+le/MHhjdmaKSKIDEz04exo54qYW2U6s1kW/ANYld+ppdsqwIvGdNltOWvhA9r2xFq621UgGPOD1H2qDCfz7+qMsngiUjdcq8iuHzZdPFWiwSjLVMuBohPP1Vua9jDmbpVviu94VkGBe+VIEYVqKXW4aOB0RA1oNvbns6mH53AqJJLtxtL+WDV865MYyGvC3/d8TJB5OyTeYSpzSzkNr4aGYbVbCwLMQE5DYZ5owVOpzn+sciKKGUEzIvOUOrkazazex1pMpVcxMPu2WY5bc4/k+pTOWF/c/zIGA4hQTHUTcvZtPyk3dIZ8zbHBsYWLeBOMAOGCrsBJpA0mLxN7sDuMHdrmY/pC8RU+U2cvpnCfo5fiy5/lsw==", "1; BLUPR02MB1124;\n\t6:CDMFCHlHHz3sy0Zors0KXbfRIm0pg9qCpzfA5FsAre8FqB4ZJzhOBSxTJAOC/rHNy+LbFGOPJ7rbLQxW7qX0QoTus51+fHQo0t+1x0B7/O/LHdnsIl7beUzCW7g25MWPnkv6uJxJnkYFw7wkkejiTgZdVlruEt4x6Dp+rOjqbTfv9c8X9AXTYlw3+Jdr8hA1+3UIiw+TCazr0wT85fas6c7neH+wB7CDt2MUDGYaYxFACLRJS3skx7lIwohQiPnmbmbGU0YQUga8CvIFXwonwlVVmMthQkdSZVYhb6DVvxmwJDCZYIEii5QxFsKlJ6bt9lXP0g2Y4FkfXROmeSnl6g==;\n\t5:MmvMeLDU3j+8uRWTUYnyhnShCdzAM87jb5SBrnOF8+FhTnsKARkoM8M242R1590f2QK/zcqQVSzpJeLViNHso/7+3AwUkYjmjs9/IsuYceFplFWO6GSD9EHC/qWDiiDMH29xyQR5vCycEyHBqshoGw==;\n\t24:l/sTAWCSYO7o8WpIDXnAMX56CH8uLO+DuBoeeKjEDATusNj735GPjn7KeHybj4OkRxHMh1ZFqzwuZTxKw2z/q5F3jYb8S8s2/19iCvcRAKI=;\n\t7:rELaNn2UAW4Lx/fr4y358ctxohF2+Uh092Oe492gupwToAI+mkoW/dz1WZ+BKgdJ/IG3ETnDNdM2iRqj3OGdfTDI9xPZoH0JPmx+odYZsnUISeshafS3Kt2ucgkhmA9uqwrLL2flDnUzTmYSuv8Vi/n1LTrPPI96rOQKzVD77BkqX/5XeB7QfWpBZW2JBP8KQyBX1wity+zrHjB52BT+ZzrPVoNcuBtjUnWxTOLV8Dk=" ], "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "df02b838-c63f-4fc8-b31b-08d4f94f30c4", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR02MB1124; ", "X-MS-TrafficTypeDiagnostic": "BLUPR02MB1124:", "X-Exchange-Antispam-Report-Test": "UriScan:(192813158149592)(104084551191319); ", "X-Microsoft-Antispam-PRVS": "<BLUPR02MB112455CA22779D4844A702AEDC680@BLUPR02MB1124.namprd02.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93004095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123558100)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR02MB1124; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR02MB1124; ", "X-Forefront-PRVS": "04270EF89C", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "xilinx.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "11 Sep 2017 19:56:27.8731\n\t(UTC)", "X-MS-Exchange-CrossTenant-Id": "657af505-d5df-48d0-8300-c31994686c5c", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=657af505-d5df-48d0-8300-c31994686c5c; \n\tIp=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BLUPR02MB1124", "X-detected-operating-system": "by eggs.gnu.org: Windows 7 or 8 [fuzzy]", "X-Received-From": "104.47.40.51", "Subject": "[Qemu-devel] [PATCH v4 3/8] Convert single line fprintf(.../n) to\n\twarn_report()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>, James Hogan <james.hogan@imgtec.com>,\n\tEduardo Habkost <ehabkost@redhat.com>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tJason Wang <jasowang@redhat.com>, armbru@redhat.com,\n\tMax Reitz <mreitz@redhat.com>, Igor Mammedov <imammedo@redhat.com>,\n\tGerd Hoffmann <kraxel@redhat.com>,\n\tStefan Hajnoczi <stefanha@redhat.com>, pbonzini@redhat.com,\n\tYongbok Kim <yongbok.kim@imgtec.com>, alistair23@gmail.com,\n\talistair.francis@xilinx.com, Michael Roth <mdroth@linux.vnet.ibm.com>,\n\tAurelien Jarno <aurelien@aurel32.net>,\n\tRichard Henderson <rth@twiddle.net>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Convert all the single line uses of fprintf(stderr, \"warning:\"...\"\\n\"...\nto use warn_report() instead. This helps standardise on a single\nmethod of printing warnings to the user.\n\nAll of the warnings were changed using this command:\n find ./* -type f -exec sed -i \\\n 's|fprintf(.*\".*warning[,:] \\(.*\\)\\\\n\"\\(.*\\));|warn_report(\"\\1\"\\2);|Ig' \\\n {} +\n\nSome of the lines were manually edited to reduce the line length to below\n80 charecters.\n\nThe #include lines were manually updated to allow the code to compile.\n\nSigned-off-by: Alistair Francis <alistair.francis@xilinx.com>\nCc: Kevin Wolf <kwolf@redhat.com>\nCc: Max Reitz <mreitz@redhat.com>\nCc: \"Michael S. Tsirkin\" <mst@redhat.com>\nCc: Igor Mammedov <imammedo@redhat.com>\nCc: Paolo Bonzini <pbonzini@redhat.com>\nCc: Richard Henderson <rth@twiddle.net>\nCc: Eduardo Habkost <ehabkost@redhat.com>\nCc: Gerd Hoffmann <kraxel@redhat.com>\nCc: Jason Wang <jasowang@redhat.com>\nCc: Michael Roth <mdroth@linux.vnet.ibm.com>\nCc: James Hogan <james.hogan@imgtec.com>\nCc: Aurelien Jarno <aurelien@aurel32.net>\nCc: Yongbok Kim <yongbok.kim@imgtec.com>\nCc: Stefan Hajnoczi <stefanha@redhat.com>\nReviewed-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: James Hogan <james.hogan@imgtec.com> [mips]\n---\nV4:\n - Rebase\n\n block/vvfat.c | 4 +++-\n hw/acpi/core.c | 3 ++-\n hw/i386/pc.c | 2 +-\n hw/misc/applesmc.c | 2 +-\n hw/usb/hcd-ehci.c | 5 +++--\n hw/virtio/virtio-balloon.c | 3 ++-\n net/hub.c | 3 ++-\n qga/vss-win32.c | 2 +-\n target/mips/kvm.c | 4 ++--\n trace/simple.c | 3 ++-\n ui/keymaps.c | 2 +-\n ui/spice-display.c | 2 +-\n 12 files changed, 21 insertions(+), 14 deletions(-)", "diff": "diff --git a/block/vvfat.c b/block/vvfat.c\nindex c54fa94651..efad5750ba 100644\n--- a/block/vvfat.c\n+++ b/block/vvfat.c\n@@ -32,6 +32,7 @@\n #include \"qapi/qmp/qbool.h\"\n #include \"qapi/qmp/qstring.h\"\n #include \"qemu/cutils.h\"\n+#include \"qemu/error-report.h\"\n \n #ifndef S_IWGRP\n #define S_IWGRP 0\n@@ -3028,7 +3029,8 @@ DLOG(checkpoint());\n if (memcmp(direntries + k,\n array_get(&(s->directory), dir_index + k),\n sizeof(direntry_t))) {\n- fprintf(stderr, \"Warning: tried to write to write-protected file\\n\");\n+ warn_report(\"tried to write to write-protected \"\n+ \"file\");\n return -1;\n }\n }\ndiff --git a/hw/acpi/core.c b/hw/acpi/core.c\nindex 95fcac95a2..2a1b79c838 100644\n--- a/hw/acpi/core.c\n+++ b/hw/acpi/core.c\n@@ -28,6 +28,7 @@\n #include \"qapi/opts-visitor.h\"\n #include \"qapi-visit.h\"\n #include \"qapi-event.h\"\n+#include \"qemu/error-report.h\"\n \n struct acpi_table_header {\n uint16_t _length; /* our length, not actual part of the hdr */\n@@ -221,7 +222,7 @@ static void acpi_table_install(const char unsigned *blob, size_t bloblen,\n }\n \n if (!has_header && changed_fields == 0) {\n- fprintf(stderr, \"warning: ACPI table: no headers are specified\\n\");\n+ warn_report(\"ACPI table: no headers are specified\");\n }\n \n /* recalculate checksum */\ndiff --git a/hw/i386/pc.c b/hw/i386/pc.c\nindex c882f8c2ea..ef5f30e644 100644\n--- a/hw/i386/pc.c\n+++ b/hw/i386/pc.c\n@@ -1310,7 +1310,7 @@ void pc_acpi_init(const char *default_dsdt)\n \n filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);\n if (filename == NULL) {\n- fprintf(stderr, \"WARNING: failed to find %s\\n\", default_dsdt);\n+ warn_report(\"failed to find %s\", default_dsdt);\n } else {\n QemuOpts *opts = qemu_opts_create(qemu_find_opts(\"acpi\"), NULL, 0,\n &error_abort);\ndiff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c\nindex 7896812304..7be8b5f13c 100644\n--- a/hw/misc/applesmc.c\n+++ b/hw/misc/applesmc.c\n@@ -331,7 +331,7 @@ static void applesmc_isa_realize(DeviceState *dev, Error **errp)\n s->iobase + APPLESMC_ERR_PORT);\n \n if (!s->osk || (strlen(s->osk) != 64)) {\n- fprintf(stderr, \"WARNING: Using AppleSMC with invalid key\\n\");\n+ warn_report(\"Using AppleSMC with invalid key\");\n s->osk = default_osk;\n }\n \ndiff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex 604912cb3e..46fd30b075 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -32,6 +32,7 @@\n #include \"hw/usb/ehci-regs.h\"\n #include \"hw/usb/hcd-ehci.h\"\n #include \"trace.h\"\n+#include \"qemu/error-report.h\"\n \n #define FRAME_TIMER_FREQ 1000\n #define FRAME_TIMER_NS (NANOSECONDS_PER_SECOND / FRAME_TIMER_FREQ)\n@@ -348,7 +349,7 @@ static void ehci_trace_sitd(EHCIState *s, hwaddr addr,\n static void ehci_trace_guest_bug(EHCIState *s, const char *message)\n {\n trace_usb_ehci_guest_bug(message);\n- fprintf(stderr, \"ehci warning: %s\\n\", message);\n+ warn_report(\"%s\", message);\n }\n \n static inline bool ehci_enabled(EHCIState *s)\n@@ -1728,7 +1729,7 @@ static int ehci_state_fetchsitd(EHCIState *ehci, int async)\n /* siTD is not active, nothing to do */;\n } else {\n /* TODO: split transfers are not implemented */\n- fprintf(stderr, \"WARNING: Skipping active siTD\\n\");\n+ warn_report(\"Skipping active siTD\");\n }\n \n ehci_set_fetch_addr(ehci, async, sitd.next);\ndiff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c\nindex a705e0ec55..37cde38982 100644\n--- a/hw/virtio/virtio-balloon.c\n+++ b/hw/virtio/virtio-balloon.c\n@@ -26,6 +26,7 @@\n #include \"qapi/visitor.h\"\n #include \"qapi-event.h\"\n #include \"trace.h\"\n+#include \"qemu/error-report.h\"\n \n #include \"hw/virtio/virtio-bus.h\"\n #include \"hw/virtio/virtio-access.h\"\n@@ -292,7 +293,7 @@ static void virtio_balloon_receive_stats(VirtIODevice *vdev, VirtQueue *vq)\n s->stats_vq_offset = offset;\n \n if (qemu_gettimeofday(&tv) < 0) {\n- fprintf(stderr, \"warning: %s: failed to get time of day\\n\", __func__);\n+ warn_report(\"%s: failed to get time of day\", __func__);\n goto out;\n }\n \ndiff --git a/net/hub.c b/net/hub.c\nindex 32d8cf5cd4..afe941ae7a 100644\n--- a/net/hub.c\n+++ b/net/hub.c\n@@ -18,6 +18,7 @@\n #include \"clients.h\"\n #include \"hub.h\"\n #include \"qemu/iov.h\"\n+#include \"qemu/error-report.h\"\n \n /*\n * A hub broadcasts incoming packets to all its ports except the source port.\n@@ -330,7 +331,7 @@ void net_hub_check_clients(void)\n }\n }\n if (has_host_dev && !has_nic) {\n- fprintf(stderr, \"Warning: vlan %d with no nics\\n\", hub->id);\n+ warn_report(\"vlan %d with no nics\", hub->id);\n }\n if (has_nic && !has_host_dev) {\n fprintf(stderr,\ndiff --git a/qga/vss-win32.c b/qga/vss-win32.c\nindex a80933c98b..b748b9ff57 100644\n--- a/qga/vss-win32.c\n+++ b/qga/vss-win32.c\n@@ -61,7 +61,7 @@ static bool vss_check_os_version(void)\n return false;\n }\n if (wow64) {\n- fprintf(stderr, \"Warning: Running under WOW64\\n\");\n+ warn_report(\"Running under WOW64\");\n }\n #endif\n return !wow64;\ndiff --git a/target/mips/kvm.c b/target/mips/kvm.c\nindex 3317905e71..a23aa438d2 100644\n--- a/target/mips/kvm.c\n+++ b/target/mips/kvm.c\n@@ -95,11 +95,11 @@ void kvm_mips_reset_vcpu(MIPSCPU *cpu)\n CPUMIPSState *env = &cpu->env;\n \n if (!kvm_mips_fpu_cap && env->CP0_Config1 & (1 << CP0C1_FP)) {\n- fprintf(stderr, \"Warning: KVM does not support FPU, disabling\\n\");\n+ warn_report(\"KVM does not support FPU, disabling\");\n env->CP0_Config1 &= ~(1 << CP0C1_FP);\n }\n if (!kvm_mips_msa_cap && env->CP0_Config3 & (1 << CP0C3_MSAP)) {\n- fprintf(stderr, \"Warning: KVM does not support MSA, disabling\\n\");\n+ warn_report(\"KVM does not support MSA, disabling\");\n env->CP0_Config3 &= ~(1 << CP0C3_MSAP);\n }\n \ndiff --git a/trace/simple.c b/trace/simple.c\nindex a221a3f703..e82018d923 100644\n--- a/trace/simple.c\n+++ b/trace/simple.c\n@@ -15,6 +15,7 @@\n #include \"qemu/timer.h\"\n #include \"trace/control.h\"\n #include \"trace/simple.h\"\n+#include \"qemu/error-report.h\"\n \n /** Trace file header event ID, picked to avoid conflict with real event IDs */\n #define HEADER_EVENT_ID (~(uint64_t)0)\n@@ -405,7 +406,7 @@ bool st_init(void)\n \n thread = trace_thread_create(writeout_thread);\n if (!thread) {\n- fprintf(stderr, \"warning: unable to initialize simple trace backend\\n\");\n+ warn_report(\"unable to initialize simple trace backend\");\n return false;\n }\n \ndiff --git a/ui/keymaps.c b/ui/keymaps.c\nindex fa00b82027..7fa21f81b2 100644\n--- a/ui/keymaps.c\n+++ b/ui/keymaps.c\n@@ -141,7 +141,7 @@ static kbd_layout_t *parse_keyboard_layout(const name2keysym_t *table,\n int keysym;\n keysym = get_keysym(table, keyname);\n if (keysym == 0) {\n- /* fprintf(stderr, \"Warning: unknown keysym %s\\n\", line);*/\n+ /* warn_report(\"unknown keysym %s\", line);*/\n } else {\n const char *rest = line + offset + 1;\n int keycode = strtol(rest, NULL, 0);\ndiff --git a/ui/spice-display.c b/ui/spice-display.c\nindex 042292cc90..0963c7825f 100644\n--- a/ui/spice-display.c\n+++ b/ui/spice-display.c\n@@ -850,7 +850,7 @@ static void qemu_spice_gl_unblock_bh(void *opaque)\n \n static void qemu_spice_gl_block_timer(void *opaque)\n {\n- fprintf(stderr, \"WARNING: spice: no gl-draw-done within one second\\n\");\n+ warn_report(\"spice: no gl-draw-done within one second\");\n }\n \n static void spice_gl_refresh(DisplayChangeListener *dcl)\n", "prefixes": [ "v4", "3/8" ] }