Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812520/?format=api
{ "id": 812520, "url": "http://patchwork.ozlabs.org/api/patches/812520/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/1505152570-6143-5-git-send-email-gvrose8192@gmail.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505152570-6143-5-git-send-email-gvrose8192@gmail.com>", "list_archive_url": null, "date": "2017-09-11T17:56:00", "name": "[ovs-dev,05/15] datapath: Remove unnecessary newlines from OVS_NLERR uses", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ed4b4d874ab8be2075e0b632bedebe653d0d4906", "submitter": { "id": 69140, "url": "http://patchwork.ozlabs.org/api/people/69140/?format=api", "name": "Gregory Rose", "email": "gvrose8192@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/1505152570-6143-5-git-send-email-gvrose8192@gmail.com/mbox/", "series": [ { "id": 2537, "url": "http://patchwork.ozlabs.org/api/series/2537/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=2537", "date": "2017-09-11T17:55:56", "name": "[ovs-dev,01/15] acinclude: Check for SKB_GSO_UDP", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2537/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812520/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812520/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jlL0TCqr\"; dkim-atps=neutral" ], "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrbJm4sMJz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 03:58:48 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 3E9D8B2A;\n\tMon, 11 Sep 2017 17:56:26 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 13132B08\n\tfor <dev@openvswitch.org>; Mon, 11 Sep 2017 17:56:25 +0000 (UTC)", "from mail-pf0-f194.google.com (mail-pf0-f194.google.com\n\t[209.85.192.194])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 01A54E0\n\tfor <dev@openvswitch.org>; Mon, 11 Sep 2017 17:56:23 +0000 (UTC)", "by mail-pf0-f194.google.com with SMTP id i23so401089pfi.2\n\tfor <dev@openvswitch.org>; Mon, 11 Sep 2017 10:56:23 -0700 (PDT)", "from gizo.domain (67-5-132-83.ptld.qwest.net. [67.5.132.83])\n\tby smtp.gmail.com with ESMTPSA id\n\th185sm16733084pfe.160.2017.09.11.10.56.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 10:56:22 -0700 (PDT)" ], "X-Greylist": "whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=0+aUV5igeT+9+FLHYM4g+qIb6RSjylqrQrjIkbzhqlA=;\n\tb=jlL0TCqryuXcZwrEAKi3CXj5T9Y0jEGozT4Xnkz2R8z2RJP91CgP1RKnZjswILYrYN\n\t9QCJG95OgKNdW7HsPiVVtFyxOGmAwUdH7dEkn6oQGFLgqfsbUgNFr6b8oz9oSJswtAnJ\n\tgnbzrMrO9VTBiSmd4dKdrwbRNnelDGq44c5r+PbFgkeGiOTFFg9z/D4VSHxEkElPbbCM\n\tm1ibFAIssvYWWiWTKX85lzLhR4y34/RsgKFZpUT41l6vEFuzZJCNbWetRJ/UzuaEIgyl\n\t/O9DpM3nEtohYqsXW5AJpBRHkwbsztKZG+jonSKhHv7K7A+tIRe2Wtq+DhgZ2nuBQrtU\n\tST5Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=0+aUV5igeT+9+FLHYM4g+qIb6RSjylqrQrjIkbzhqlA=;\n\tb=HjIV4FIxlgerNwdJWMVTMMPOfrgaG7G0veWvAs45XS7qG1z7QK3ra/6b6Yee0mKhQb\n\tIAEGkgknA5Igxx1cdMPcmj2Fv+DW1d7QcpJfGPnj2P85juxH6Wt9A4bgBADGraY1IXIk\n\tUVRvmQoBDRBWPDGpqTizrKTKxbDPvgGpvC7k3o1mObwK798dRvTfOac2LVIP1skXDR0L\n\txe2F0WRme0z1gnbZzeQqXb8VL37rLU05McLz/VLJmxHhybdrJI7ZXRVh7VmBDq/0M/sW\n\tsUAvD4CjCjl34jM1HH745x//rC0N5E4tNUPQs01TBvW6BrWq9UTvh3YfImHNvDvh9c3K\n\tcc4A==", "X-Gm-Message-State": "AHPjjUgiSAu0dFkGe0frBbPDMfXznWzh1nYdOu7SwbyCZTvzF5C+j6Yn\n\tmrj7NJ4UiNGBXPiX", "X-Google-Smtp-Source": "ADKCNb40eVdjjXDB7F4FUUzlPE1RMgu/O7HH7sddInJwvMkIA3tAd/wYepkvY9zNgieL/Gqz30sj9g==", "X-Received": "by 10.98.10.146 with SMTP id 18mr12342497pfk.346.1505152583300; \n\tMon, 11 Sep 2017 10:56:23 -0700 (PDT)", "From": "Greg Rose <gvrose8192@gmail.com>", "To": "dev@openvswitch.org", "Date": "Mon, 11 Sep 2017 10:56:00 -0700", "Message-Id": "<1505152570-6143-5-git-send-email-gvrose8192@gmail.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1505152570-6143-1-git-send-email-gvrose8192@gmail.com>", "References": "<1505152570-6143-1-git-send-email-gvrose8192@gmail.com>", "X-Spam-Status": "No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, \n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Subject": "[ovs-dev] [PATCH 05/15] datapath: Remove unnecessary newlines from\n\tOVS_NLERR uses", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "Upstream commit:\n commit 0ed80da518a1f27562a013f106505e495e891fe4\n Author: Joe Perches <joe@perches.com>\n Date: Fri Aug 11 04:26:26 2017 -0700\n\n openvswitch: Remove unnecessary newlines from OVS_NLERR uses\n\n OVS_NLERR already adds a newline so these just add blank\n lines to the logging.\n\n Signed-off-by: Joe Perches <joe@perches.com>\n Acked-by: Joe Stringer <joe@ovn.org>\n Signed-off-by: David S. Miller <davem@davemloft.net>\n\nSigned-off-by: Greg Rose <gvrose8192@gmail.com>\n---\n datapath/conntrack.c | 14 +++++---------\n datapath/flow_netlink.c | 2 +-\n 2 files changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/datapath/conntrack.c b/datapath/conntrack.c\nindex b645ab1..d517a87 100644\n--- a/datapath/conntrack.c\n+++ b/datapath/conntrack.c\n@@ -1221,15 +1221,13 @@ static int parse_nat(const struct nlattr *attr,\n \t\tint type = nla_type(a);\n \n \t\tif (type > OVS_NAT_ATTR_MAX) {\n-\t\t\tOVS_NLERR(log,\n-\t\t\t\t \"Unknown NAT attribute (type=%d, max=%d).\\n\",\n+\t\t\tOVS_NLERR(log, \"Unknown NAT attribute (type=%d, max=%d)\",\n \t\t\t\t type, OVS_NAT_ATTR_MAX);\n \t\t\treturn -EINVAL;\n \t\t}\n \n \t\tif (nla_len(a) != ovs_nat_attr_lens[type][ip_vers]) {\n-\t\t\tOVS_NLERR(log,\n-\t\t\t\t \"NAT attribute type %d has unexpected length (%d != %d).\\n\",\n+\t\t\tOVS_NLERR(log, \"NAT attribute type %d has unexpected length (%d != %d)\",\n \t\t\t\t type, nla_len(a),\n \t\t\t\t ovs_nat_attr_lens[type][ip_vers]);\n \t\t\treturn -EINVAL;\n@@ -1239,9 +1237,7 @@ static int parse_nat(const struct nlattr *attr,\n \t\tcase OVS_NAT_ATTR_SRC:\n \t\tcase OVS_NAT_ATTR_DST:\n \t\t\tif (info->nat) {\n-\t\t\t\tOVS_NLERR(log,\n-\t\t\t\t\t \"Only one type of NAT may be specified.\\n\"\n-\t\t\t\t\t );\n+\t\t\t\tOVS_NLERR(log, \"Only one type of NAT may be specified\");\n \t\t\t\treturn -ERANGE;\n \t\t\t}\n \t\t\tinfo->nat |= OVS_CT_NAT;\n@@ -1291,13 +1287,13 @@ static int parse_nat(const struct nlattr *attr,\n \t\t\tbreak;\n \n \t\tdefault:\n-\t\t\tOVS_NLERR(log, \"Unknown nat attribute (%d).\\n\", type);\n+\t\t\tOVS_NLERR(log, \"Unknown nat attribute (%d)\", type);\n \t\t\treturn -EINVAL;\n \t\t}\n \t}\n \n \tif (rem > 0) {\n-\t\tOVS_NLERR(log, \"NAT attribute has %d unknown bytes.\\n\", rem);\n+\t\tOVS_NLERR(log, \"NAT attribute has %d unknown bytes\", rem);\n \t\treturn -EINVAL;\n \t}\n \tif (!info->nat) {\ndiff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c\nindex 9b48612..df9d88e 100644\n--- a/datapath/flow_netlink.c\n+++ b/datapath/flow_netlink.c\n@@ -1257,7 +1257,7 @@ static int ovs_key_from_nlattrs(struct net *net, struct sw_flow_match *match,\n \t\t}\n \n \t\tif (!is_mask && ipv6_key->ipv6_label & htonl(0xFFF00000)) {\n-\t\t\tOVS_NLERR(log, \"IPv6 flow label %x is out of range (max=%x).\\n\",\n+\t\t\tOVS_NLERR(log, \"IPv6 flow label %x is out of range (max=%x)\",\n \t\t\t\t ntohl(ipv6_key->ipv6_label), (1 << 20) - 1);\n \t\t\treturn -EINVAL;\n \t\t}\n", "prefixes": [ "ovs-dev", "05/15" ] }