Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812447/?format=api
{ "id": 812447, "url": "http://patchwork.ozlabs.org/api/patches/812447/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911165929.2791-6-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170911165929.2791-6-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2017-09-11T16:59:27", "name": "[v6,5/7] kdump: set vmcoreinfo location", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3870482c26d9ece1a563213b539401d56ee76d72", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911165929.2791-6-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 2525, "url": "http://patchwork.ozlabs.org/api/series/2525/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2525", "date": "2017-09-11T16:59:22", "name": "KASLR kernel dump support", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/2525/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812447/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812447/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrZ6w6HBKz9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 03:05:12 +1000 (AEST)", "from localhost ([::1]:59179 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drS91-0001jb-0D\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 13:05:11 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:57729)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1drS46-00069u-3Q\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 13:00:11 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1drS42-0007Ag-9k\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 13:00:06 -0400", "from mx1.redhat.com ([209.132.183.28]:57284)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <marcandre.lureau@redhat.com>)\n\tid 1drS42-0007AY-4x\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 13:00:02 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 290BAF262A\n\tfor <qemu-devel@nongnu.org>; Mon, 11 Sep 2017 17:00:01 +0000 (UTC)", "from localhost (ovpn-112-51.ams2.redhat.com [10.36.112.51])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2F00B5D968;\n\tMon, 11 Sep 2017 16:59:55 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 290BAF262A", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 11 Sep 2017 18:59:27 +0200", "Message-Id": "<20170911165929.2791-6-marcandre.lureau@redhat.com>", "In-Reply-To": "<20170911165929.2791-1-marcandre.lureau@redhat.com>", "References": "<20170911165929.2791-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tMon, 11 Sep 2017 17:00:01 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v6 5/7] kdump: set vmcoreinfo location", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "ehabkost@redhat.com, mst@redhat.com, anderson@redhat.com, =?utf-8?q?Ma?=\n\t=?utf-8?q?rc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\timammedo@redhat.com, lersek@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "kdump header provides offset and size of the vmcoreinfo content,\nappend it if available (skip the ELF note header).\n\ncrash-7.1.9 was the first version that started looking in the\nvmcoreinfo data for phys_base instead of in the kdump_sub_header.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n dump.c | 24 ++++++++++++++++++++++++\n 1 file changed, 24 insertions(+)", "diff": "diff --git a/dump.c b/dump.c\nindex 0671a73108..f061fc69db 100644\n--- a/dump.c\n+++ b/dump.c\n@@ -858,6 +858,18 @@ static void create_header32(DumpState *s, Error **errp)\n kh->dump_level = cpu_to_dump32(s, DUMP_LEVEL);\n \n offset_note = DISKDUMP_HEADER_BLOCKS * block_size + size;\n+ if (s->guest_note &&\n+ note_name_equal(s, s->guest_note, \"VMCOREINFO\")) {\n+ uint64_t hsize, name_size, size_vmcoreinfo_desc, offset_vmcoreinfo;\n+\n+ get_note_sizes(s, s->guest_note,\n+ &hsize, &name_size, &size_vmcoreinfo_desc);\n+ offset_vmcoreinfo = offset_note + s->note_size - s->guest_note_size +\n+ (DIV_ROUND_UP(hsize, 4) + DIV_ROUND_UP(name_size, 4)) * 4;\n+ kh->offset_vmcoreinfo = cpu_to_dump64(s, offset_vmcoreinfo);\n+ kh->size_vmcoreinfo = cpu_to_dump32(s, size_vmcoreinfo_desc);\n+ }\n+\n kh->offset_note = cpu_to_dump64(s, offset_note);\n kh->note_size = cpu_to_dump32(s, s->note_size);\n \n@@ -958,6 +970,18 @@ static void create_header64(DumpState *s, Error **errp)\n kh->dump_level = cpu_to_dump32(s, DUMP_LEVEL);\n \n offset_note = DISKDUMP_HEADER_BLOCKS * block_size + size;\n+ if (s->guest_note &&\n+ note_name_equal(s, s->guest_note, \"VMCOREINFO\")) {\n+ uint64_t hsize, name_size, size_vmcoreinfo_desc, offset_vmcoreinfo;\n+\n+ get_note_sizes(s, s->guest_note,\n+ &hsize, &name_size, &size_vmcoreinfo_desc);\n+ offset_vmcoreinfo = offset_note + s->note_size - s->guest_note_size +\n+ (DIV_ROUND_UP(hsize, 4) + DIV_ROUND_UP(name_size, 4)) * 4;\n+ kh->offset_vmcoreinfo = cpu_to_dump64(s, offset_vmcoreinfo);\n+ kh->size_vmcoreinfo = cpu_to_dump64(s, size_vmcoreinfo_desc);\n+ }\n+\n kh->offset_note = cpu_to_dump64(s, offset_note);\n kh->note_size = cpu_to_dump64(s, s->note_size);\n \n", "prefixes": [ "v6", "5/7" ] }