Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812296/?format=api
{ "id": 812296, "url": "http://patchwork.ozlabs.org/api/patches/812296/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/150512485206.8642.14117914178635650186.stgit@bahia.lan/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<150512485206.8642.14117914178635650186.stgit@bahia.lan>", "list_archive_url": null, "date": "2017-09-11T10:14:12", "name": "[1/2] spapr_pci: convert sprintf() to g_strdup_printf()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "02c4e9cf813162350807d874cedfaeeaa47620fa", "submitter": { "id": 69178, "url": "http://patchwork.ozlabs.org/api/people/69178/?format=api", "name": "Greg Kurz", "email": "groug@kaod.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/150512485206.8642.14117914178635650186.stgit@bahia.lan/mbox/", "series": [ { "id": 2468, "url": "http://patchwork.ozlabs.org/api/series/2468/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2468", "date": "2017-09-11T10:13:56", "name": "spapr_pci: some more cleanup", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2468/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812296/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812296/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrP1j3Jwbz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 20:15:05 +1000 (AEST)", "from localhost ([::1]:56504 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drLk7-0008WS-Ft\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 06:15:03 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:57010)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <groug@kaod.org>) id 1drLjP-0008On-99\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 06:14:23 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <groug@kaod.org>) id 1drLjM-0002h9-4b\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 06:14:19 -0400", "from 13.mo1.mail-out.ovh.net ([178.33.253.128]:55240)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <groug@kaod.org>) id 1drLjL-0002gF-V0\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 06:14:16 -0400", "from player169.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo1.mail-out.ovh.net (Postfix) with ESMTP id 818B093404\n\tfor <qemu-devel@nongnu.org>; Mon, 11 Sep 2017 12:14:14 +0200 (CEST)", "from bahia.lan (gar31-1-82-66-74-139.fbx.proxad.net [82.66.74.139])\n\t(Authenticated sender: groug@kaod.org)\n\tby player169.ha.ovh.net (Postfix) with ESMTPA id 4817D580079;\n\tMon, 11 Sep 2017 12:14:12 +0200 (CEST)" ], "From": "Greg Kurz <groug@kaod.org>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 11 Sep 2017 12:14:12 +0200", "Message-ID": "<150512485206.8642.14117914178635650186.stgit@bahia.lan>", "In-Reply-To": "<150512483616.8642.15831240906912354238.stgit@bahia.lan>", "References": "<150512483616.8642.15831240906912354238.stgit@bahia.lan>", "User-Agent": "StGit/0.17.1-46-g6855-dirty", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-Ovh-Tracer-Id": "7058829469574994259", "X-VR-SPAMSTATE": "OK", "X-VR-SPAMSCORE": "-100", "X-VR-SPAMCAUSE": "gggruggvucftvghtrhhoucdtuddrfeelledrgedtgddvjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "178.33.253.128", "Subject": "[Qemu-devel] [PATCH 1/2] spapr_pci: convert sprintf() to\n\tg_strdup_printf()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "In order to follow a QEMU common practice.\n\nSigned-off-by: Greg Kurz <groug@kaod.org>\n---\n hw/ppc/spapr_pci.c | 21 ++++++++++++---------\n 1 file changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c\nindex 75cd9392233e..7d84b9766ed2 100644\n--- a/hw/ppc/spapr_pci.c\n+++ b/hw/ppc/spapr_pci.c\n@@ -1609,34 +1609,37 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp)\n \n sphb->dtbusname = g_strdup_printf(\"pci@%\" PRIx64, sphb->buid);\n \n- namebuf = alloca(strlen(sphb->dtbusname) + 32);\n-\n /* Initialize memory regions */\n- sprintf(namebuf, \"%s.mmio\", sphb->dtbusname);\n+ namebuf = g_strdup_printf(\"%s.mmio\", sphb->dtbusname);\n memory_region_init(&sphb->memspace, OBJECT(sphb), namebuf, UINT64_MAX);\n+ g_free(namebuf);\n \n- sprintf(namebuf, \"%s.mmio32-alias\", sphb->dtbusname);\n+ namebuf = g_strdup_printf(\"%s.mmio32-alias\", sphb->dtbusname);\n memory_region_init_alias(&sphb->mem32window, OBJECT(sphb),\n namebuf, &sphb->memspace,\n SPAPR_PCI_MEM_WIN_BUS_OFFSET, sphb->mem_win_size);\n+ g_free(namebuf);\n memory_region_add_subregion(get_system_memory(), sphb->mem_win_addr,\n &sphb->mem32window);\n \n- sprintf(namebuf, \"%s.mmio64-alias\", sphb->dtbusname);\n+ namebuf = g_strdup_printf(\"%s.mmio64-alias\", sphb->dtbusname);\n memory_region_init_alias(&sphb->mem64window, OBJECT(sphb),\n namebuf, &sphb->memspace,\n sphb->mem64_win_pciaddr, sphb->mem64_win_size);\n+ g_free(namebuf);\n memory_region_add_subregion(get_system_memory(), sphb->mem64_win_addr,\n &sphb->mem64window);\n \n /* Initialize IO regions */\n- sprintf(namebuf, \"%s.io\", sphb->dtbusname);\n+ namebuf = g_strdup_printf(\"%s.io\", sphb->dtbusname);\n memory_region_init(&sphb->iospace, OBJECT(sphb),\n namebuf, SPAPR_PCI_IO_WIN_SIZE);\n+ g_free(namebuf);\n \n- sprintf(namebuf, \"%s.io-alias\", sphb->dtbusname);\n+ namebuf = g_strdup_printf(\"%s.io-alias\", sphb->dtbusname);\n memory_region_init_alias(&sphb->iowindow, OBJECT(sphb), namebuf,\n &sphb->iospace, 0, SPAPR_PCI_IO_WIN_SIZE);\n+ g_free(namebuf);\n memory_region_add_subregion(get_system_memory(), sphb->io_win_addr,\n &sphb->iowindow);\n \n@@ -1654,10 +1657,10 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp)\n * Later the guest might want to create another DMA window\n * which will become another memory subregion.\n */\n- sprintf(namebuf, \"%s.iommu-root\", sphb->dtbusname);\n-\n+ namebuf = g_strdup_printf(\"%s.iommu-root\", sphb->dtbusname);\n memory_region_init(&sphb->iommu_root, OBJECT(sphb),\n namebuf, UINT64_MAX);\n+ g_free(namebuf);\n address_space_init(&sphb->iommu_as, &sphb->iommu_root,\n sphb->dtbusname);\n \n", "prefixes": [ "1/2" ] }