Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812250/?format=api
{ "id": 812250, "url": "http://patchwork.ozlabs.org/api/patches/812250/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/1505117637-16460-1-git-send-email-maddy@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505117637-16460-1-git-send-email-maddy@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-09-11T08:13:57", "name": "skiboot/hw/imc: Add NULL pointer check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ae89c0e26b70aaa8bcedbed022f08e2fd284a2a3", "submitter": { "id": 33703, "url": "http://patchwork.ozlabs.org/api/people/33703/?format=api", "name": "maddy", "email": "maddy@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/1505117637-16460-1-git-send-email-maddy@linux.vnet.ibm.com/mbox/", "series": [ { "id": 2453, "url": "http://patchwork.ozlabs.org/api/series/2453/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/list/?series=2453", "date": "2017-09-11T08:13:57", "name": "skiboot/hw/imc: Add NULL pointer check", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2453/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812250/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812250/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrLLY3NShz9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 18:14:29 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xrLLY2QZQzDrp1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 18:14:29 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xrLLJ0Td4zDrZQ\n\tfor <skiboot@lists.ozlabs.org>; Mon, 11 Sep 2017 18:14:14 +1000 (AEST)", "from pps.filterd (m0098421.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8B8E1dP131785\n\tfor <skiboot@lists.ozlabs.org>; Mon, 11 Sep 2017 04:14:11 -0400", "from e23smtp04.au.ibm.com (e23smtp04.au.ibm.com [202.81.31.146])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cwndpcn37-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Mon, 11 Sep 2017 04:14:10 -0400", "from localhost\n\tby e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <maddy@linux.vnet.ibm.com>;\n\tMon, 11 Sep 2017 18:14:05 +1000", "from d23relay10.au.ibm.com (202.81.31.229)\n\tby e23smtp04.au.ibm.com (202.81.31.210) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 11 Sep 2017 18:14:03 +1000", "from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])\n\tby d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8B8E3cN36962326\n\tfor <skiboot@lists.ozlabs.org>; Mon, 11 Sep 2017 18:14:03 +1000", "from d23av01.au.ibm.com (localhost [127.0.0.1])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8B8E3Ve001247\n\tfor <skiboot@lists.ozlabs.org>; Mon, 11 Sep 2017 18:14:03 +1000", "from SrihariSrinidhi.in.ibm.com ([9.79.202.143])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8B8DxxZ001178; Mon, 11 Sep 2017 18:14:00 +1000" ], "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=maddy@linux.vnet.ibm.com; receiver=<UNKNOWN>)", "From": "Madhavan Srinivasan <maddy@linux.vnet.ibm.com>", "To": "stewart@linux.vnet.ibm.com", "Date": "Mon, 11 Sep 2017 13:43:57 +0530", "X-Mailer": "git-send-email 2.7.4", "X-TM-AS-MML": "disable", "x-cbid": "17091108-0012-0000-0000-0000025D3C9A", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17091108-0013-0000-0000-0000077A6251", "Message-Id": "<1505117637-16460-1-git-send-email-maddy@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-11_03:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709110129", "Subject": "[Skiboot] [PATCH] skiboot/hw/imc: Add NULL pointer check", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "Cc": "skiboot@lists.ozlabs.org, mikey@neuling.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Minor cleanup to avoid null pointer access.\n\nSigned-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>\n---\n hw/imc.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/hw/imc.c b/hw/imc.c\nindex 3db67a2a9d34..ccf3973c4752 100644\n--- a/hw/imc.c\n+++ b/hw/imc.c\n@@ -599,6 +599,8 @@ static int64_t opal_imc_counters_start(uint32_t type, uint64_t cpu_pir)\n \tcase OPAL_IMC_COUNTERS_NEST:\n \t\t/* Fetch the IMC control block structure */\n \t\tcb = get_imc_cb(c->chip_id);\n+\t\tif (!cb)\n+\t\t\treturn OPAL_HARDWARE;\n \n \t\t/* Set the run command */\n \t\top = NEST_IMC_ENABLE;\n@@ -651,6 +653,8 @@ static int64_t opal_imc_counters_stop(uint32_t type, uint64_t cpu_pir)\n \tcase OPAL_IMC_COUNTERS_NEST:\n \t\t/* Fetch the IMC control block structure */\n \t\tcb = get_imc_cb(c->chip_id);\n+\t\tif (!cb)\n+\t\t\treturn OPAL_HARDWARE;\n \n \t\t/* Set the run command */\n \t\top = NEST_IMC_DISABLE;\n", "prefixes": [] }