Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812244/?format=api
{ "id": 812244, "url": "http://patchwork.ozlabs.org/api/patches/812244/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/20170911075426.514-1-aleksander@aleksander.es/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170911075426.514-1-aleksander@aleksander.es>", "list_archive_url": null, "date": "2017-09-11T07:54:26", "name": "libmbim: fix build with musl libc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "86fa1efcbfa229ab3e86502f5a1fa271dbdae506", "submitter": { "id": 48681, "url": "http://patchwork.ozlabs.org/api/people/48681/?format=api", "name": "Aleksander Morgado", "email": "aleksander@aleksander.es" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/20170911075426.514-1-aleksander@aleksander.es/mbox/", "series": [ { "id": 2450, "url": "http://patchwork.ozlabs.org/api/series/2450/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/list/?series=2450", "date": "2017-09-11T07:54:26", "name": "libmbim: fix build with musl libc", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2450/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812244/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812244/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aleksander-es.20150623.gappssmtp.com\n\theader.i=@aleksander-es.20150623.gappssmtp.com\n\theader.b=\"jETUSnA6\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrKvs3zsgz9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 17:54:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8A3D0880EA;\n\tMon, 11 Sep 2017 07:54:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eWyCwGwYcTLD; Mon, 11 Sep 2017 07:54:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id EE2BA880DC;\n\tMon, 11 Sep 2017 07:54:40 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id F13411C0906\n\tfor <buildroot@lists.busybox.net>;\n\tMon, 11 Sep 2017 07:54:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id EB4622C2F9\n\tfor <buildroot@lists.busybox.net>;\n\tMon, 11 Sep 2017 07:54:39 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pPp886E36gTS for <buildroot@lists.busybox.net>;\n\tMon, 11 Sep 2017 07:54:38 +0000 (UTC)", "from mail-wm0-f41.google.com (mail-wm0-f41.google.com\n\t[74.125.82.41])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 5B6E425AD8\n\tfor <buildroot@buildroot.org>; Mon, 11 Sep 2017 07:54:37 +0000 (UTC)", "by mail-wm0-f41.google.com with SMTP id f199so32923454wme.0\n\tfor <buildroot@buildroot.org>; Mon, 11 Sep 2017 00:54:37 -0700 (PDT)", "from localhost.localdomain\n\t(116.red-83-40-186.dynamicip.rima-tde.net. [83.40.186.116])\n\tby smtp.gmail.com with ESMTPSA id\n\tj65sm4221074wmj.3.2017.09.11.00.54.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 00:54:35 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=aleksander-es.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=UOREsE4Na8FC8nVb5zu2JEvSSgnBpNQXnOmJG7rJoO4=;\n\tb=jETUSnA6Xnj0eSjsnGLs+HX3gaCAC8knacZbai00Wk1KzTCt4nexh5Q8QPtr776kqf\n\tSDz5J1F/XtpGm0GWgGeEsYyiYL8z/oO9Pf3Uesgo/v0+w0jo7gw8i9hWMOwuwdAtCAWW\n\tD5AXfCx9Yy0d1j99gdBN6ly+rVic2vLRDzSKqETeOP2VGeiIs2A0eZujCUu7ooT0qb+X\n\t7xNlH9916kgZgNvrRj0C03ezL0z7naZPyBIESgqmdLJPArZOAW40IzIZDwxpgGGMPyjp\n\tdNJvAVsknYC8TyDHi2ExVAJ8ul99LU//LFqNWpM8xWnz5U3gQlrQVRVdkbAsdnSbT31l\n\t+5BQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=UOREsE4Na8FC8nVb5zu2JEvSSgnBpNQXnOmJG7rJoO4=;\n\tb=TfhCY1GWxeV2FvFgI2dTyavsPCdBlJiv9KZPje2wOjpQYVTxQQRiErJQN+PbnaM2Ui\n\tmqZ5b7B2ceEfO/KzxHXNyaD5SgN0Eiu1f6kS+iA985t2ry6rNV9uxqzCn8X9yvmc10LA\n\t6UOskXLNCa656oxQA+Dg7MbzNv8yqmJY50Vu2f6jPW4ZSDK2qlsuFQEEQfeAg3laHguQ\n\tG4cT44w05NZcEnPZ5eYoWqW+ylH2ynsZr0Y12/o9Lo/JVz9rt71fLeIYBvZFYv9/TG7+\n\t3xxyOubHadmjKcUUGjBfD0dqZnROloYbLBKbwCtBu4hI8fhYnFclgKs09Q+XGS0Ku19z\n\tPGJw==", "X-Gm-Message-State": "AHPjjUiSquF+KBRL6tDaHWk8giTIYOaVoNxH0cE+EJuNX6Iu4Z2zvu85\n\tgoM4WMH0aiXYY+opYYjqHt+vA/A4G4U=", "X-Google-Smtp-Source": "AOwi7QDCjiu+0MLUsAvGCHgGNjMlZI7ctZmSYNM5eNQ2maSO17umEmCB+PQ1aTkb1qvJpw/LE+ommQ==", "X-Received": "by 10.28.99.69 with SMTP id x66mr7008581wmb.30.1505116475843;\n\tMon, 11 Sep 2017 00:54:35 -0700 (PDT)", "From": "Aleksander Morgado <aleksander@aleksander.es>", "To": "buildroot@buildroot.org", "Date": "Mon, 11 Sep 2017 09:54:26 +0200", "Message-Id": "<20170911075426.514-1-aleksander@aleksander.es>", "X-Mailer": "git-send-email 2.13.1", "Cc": "thomas.petazzoni@free-electrons.com,\n\tAleksander Morgado <aleksander@aleksander.es>", "Subject": "[Buildroot] [PATCH] libmbim: fix build with musl libc", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "This is now failing because the libgudev dependency is optional and\nthe build will only use if it's found during the configure checks.\n\nImported the same patch that has been applied in the upstream libmbim\ngit repository:\n https://cgit.freedesktop.org/libmbim/libmbim/commit/?id=417b0b80023dc30d61c111ec0a54da2884d3a541\n\nSigned-off-by: Aleksander Morgado <aleksander@aleksander.es>\n---\n ...-prefer-realpath-to-canonicalize_file_nam.patch | 36 ++++++++++++++++++++++\n 1 file changed, 36 insertions(+)\n create mode 100644 package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch", "diff": "diff --git a/package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch b/package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch\nnew file mode 100644\nindex 000000000..a13aee547\n--- /dev/null\n+++ b/package/libmbim/0001-mbim-device-prefer-realpath-to-canonicalize_file_nam.patch\n@@ -0,0 +1,36 @@\n+From 48772b32f10523cca22b7d63c3523377279c7427 Mon Sep 17 00:00:00 2001\n+From: Aleksander Morgado <aleksander@aleksander.es>\n+Date: Mon, 11 Sep 2017 09:31:03 +0200\n+Subject: [PATCH] mbim-device: prefer realpath() to canonicalize_file_name()\n+\n+Usually the canonicalize_file_name() GNU extension is preferred to the\n+POSIX realpath(), as it covers some of the limitations the latter has.\n+But this extension isn't available in lots of platforms or in other\n+c library implementations (e.g. musl), so just default to the POSIX\n+method to improve portability.\n+\n+Note that the check for canonicalize_file_name() availability during\n+configure isn't as trivial as adding a new AC_CHECK_FUNCS(), and\n+importing a gnulib module seems overkill just for this one liner.\n+\n+(cherry picked from commit 417b0b80023dc30d61c111ec0a54da2884d3a541)\n+---\n+ src/libmbim-glib/mbim-device.c | 2 +-\n+ 1 file changed, 1 insertion(+), 1 deletion(-)\n+\n+diff --git a/src/libmbim-glib/mbim-device.c b/src/libmbim-glib/mbim-device.c\n+index e1f32a6..20e64af 100644\n+--- a/src/libmbim-glib/mbim-device.c\n++++ b/src/libmbim-glib/mbim-device.c\n+@@ -867,7 +867,7 @@ get_descriptors_filepath (MbimDevice *self)\n+ * /sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.5/2-1.5:2.0\n+ */\n+ tmp = g_strdup_printf (\"/sys/class/%s/%s/device\", subsystems[i], device_basename);\n+- path = canonicalize_file_name (tmp);\n++ path = realpath (tmp, NULL);\n+ g_free (tmp);\n+ \n+ if (g_file_test (path, G_FILE_TEST_EXISTS)) {\n+-- \n+2.13.1\n+\n", "prefixes": [] }