Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812199/?format=api
{ "id": 812199, "url": "http://patchwork.ozlabs.org/api/patches/812199/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/20170911011654.28743-3-gabriel@inconstante.eti.br/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170911011654.28743-3-gabriel@inconstante.eti.br>", "list_archive_url": null, "date": "2017-09-11T01:16:51", "name": "[v2,2/5] powerpc: Add redirection for finitef128, isinf128, and isnanf128", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4e1587a9d5ecf30668d28c0db42fa46aeeea4982", "submitter": { "id": 72317, "url": "http://patchwork.ozlabs.org/api/people/72317/?format=api", "name": "Gabriel F. T. Gomes", "email": "gabriel@inconstante.eti.br" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/20170911011654.28743-3-gabriel@inconstante.eti.br/mbox/", "series": [ { "id": 2426, "url": "http://patchwork.ozlabs.org/api/series/2426/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=2426", "date": "2017-09-11T01:16:49", "name": "Fixes for gcc enabling -mfloat128 by default", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/2426/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812199/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812199/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-return-84431-incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list libc-alpha@sourceware.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84431-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"ysArIocm\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xr95P1hQ4z9s76\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 11:17:29 +1000 (AEST)", "(qmail 38787 invoked by alias); 11 Sep 2017 01:17:15 -0000", "(qmail 38488 invoked by uid 89); 11 Sep 2017 01:17:14 -0000" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-type; q=dns; s=default; b=s+cWd\n\tx+1aBnAyYV7CyG1hhTMniJ13kyddrWx1luW2ZTrrOCTr53nNqJIjl2tUKWGJm2Bt\n\tUJMn//QbmHAkoUkAv3DSHDq59pkSZ3guvhaNkM3TAtISma2tKLaZNPVvNj83HlG2\n\tfdaouYAjxIsv2FbHmAWiCFnAcEnLx8RGFZn3RA=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-type; s=default; bh=q0LAZTFYcMr\n\tKTlMi2vzHXVOPBiY=; b=ysArIocmWkIz3hGULcoaN/mYH7QchsHXlsQcaRRuXHr\n\t8rTy10Bnk0Htl9/FjAOW9ZcWj8HyvNkkl/tpLgrrtbTlZhDwU3mWpESK03iK4A17\n\tIqpLJgSpKjSDtg6xsAZq73p7HtCu5qt55sYwlDYvrkEUVXlzRh6oPSWzi/dSZIQ0\n\t=", "Mailing-List": "contact libc-alpha-help@sourceware.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<libc-alpha.sourceware.org>", "List-Unsubscribe": "<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>", "List-Subscribe": "<mailto:libc-alpha-subscribe@sourceware.org>", "List-Archive": "<http://sourceware.org/ml/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>", "Sender": "libc-alpha-owner@sourceware.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-24.9 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tKAM_LAZY_DOMAIN_SECURITY,\n\tRCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=H*F:D*br", "X-HELO": "mo20.mail-out.ovh.net", "From": "\"Gabriel F. T. Gomes\" <gabriel@inconstante.eti.br>", "To": "<libc-alpha@sourceware.org>", "Subject": "[PATCH v2 2/5] powerpc: Add redirection for finitef128, isinf128,\n\tand isnanf128", "Date": "Sun, 10 Sep 2017 22:16:51 -0300", "Message-ID": "<20170911011654.28743-3-gabriel@inconstante.eti.br>", "In-Reply-To": "<20170911011654.28743-1-gabriel@inconstante.eti.br>", "References": "<20170911011654.28743-1-gabriel@inconstante.eti.br>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-ClientProxiedBy": "EX1.emp.local (172.16.2.1) To EX2.emp.local (172.16.2.2)", "X-Ovh-Tracer-Id": "16435605369161764547", "X-VR-SPAMSTATE": "OK", "X-VR-SPAMSCORE": "0", "X-VR-SPAMCAUSE": "gggruggvucftvghtrhhoucdtuddrfeelledrfeelgddtfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecu" }, "content": "Changes since v1:\n\n - Added comments to explain the need to redefine __finitef, __finitel,\n and __finitef128 in s_finite.c. Likewise for isinf and isnan.\n\n-- 8< --\nOn powerpc64le, compiler support for float128 is not enabled by default\non gcc. To enable it, the flag -mfloat128 must be passed as a command\nline option to the compiler. This means that only the few files that\nactively have -mfloat128 passed as an argument get compiler support for\nfloat128, whereas all other files don't.\n\nWhen -mfloat128 becomes enabled by default on powerpc [1], all the files\nthat do not currently have compiler support for float128 enabled during\ntheir compilation, will start to have it. This will lead to build\nerrors in s_finite.c, s_isinf.c, and s_isnan.c.\n\nThe errors are due to the unintended macro expansion of __finitef128 to\n__redirect_finitef128 in math/bits/mathcalls-helper-functions.h. In\nthat header, __MATHDECL_1 takes '__finite' and 'f128' as arguments and\nconcatenates them, but '__finite' has been redefined in s_finite.c.\nThis effect was already true for the 'float' and 'long double' versions\nand is now true for float128. Likewise for isinsff128 and isnanf128.\n\nThis patch defines __finitef128 as __redirect___finitef128 in\nsysdeps/powerpc/powerpc64/fpu/multiarch/s_finite.c, similarly to what's\ndone for the float and long double versions of these functions, to get\nrid of the build error. Likewise for isinff128 and isnanf128.\n\n[1] https://gcc.gnu.org/ml/gcc-patches/2017-08/msg01028.html\n\nTested for powerpc64 and powerpc64le.\n\n\t* sysdeps/powerpc/powerpc64/fpu/multiarch/s_finite.c\n\t(__finitef128): Define to __redirect___finitef128.\n\t* sysdeps/powerpc/powerpc64/fpu/multiarch/s_isinf.c\n\t(__isinff128): Define to __redirect___isinff128.\n\t* sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan.c\n\t(__isnanf128): Define to __redirect___isnanf128.\n---\n sysdeps/powerpc/powerpc64/fpu/multiarch/s_finite.c | 7 +++++++\n sysdeps/powerpc/powerpc64/fpu/multiarch/s_isinf.c | 7 +++++++\n sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan.c | 7 +++++++\n 3 files changed, 21 insertions(+)", "diff": "diff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_finite.c b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_finite.c\nindex a5ec36b72f..0382bfb95c 100644\n--- a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_finite.c\n+++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_finite.c\n@@ -17,8 +17,15 @@\n <http://www.gnu.org/licenses/>. */\n \n #define __finite __redirect___finite\n+\n+/* The following definitions, although not related to the 'double'\n+ version of 'finite', are required to compensate for the unintended\n+ macro expansion of __finitef to __redirect___finitef, etc. in\n+ math/bits/mathcalls-helper-functions.h. */\n #define __finitef __redirect___finitef\n #define __finitel __redirect___finitel\n+#define __finitef128 __redirect___finitef128\n+\n #include <math.h>\n #include <math_ldbl_opt.h>\n #include <shlib-compat.h>\ndiff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isinf.c b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isinf.c\nindex 9c6789c7bd..43827557a3 100644\n--- a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isinf.c\n+++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isinf.c\n@@ -17,8 +17,15 @@\n <http://www.gnu.org/licenses/>. */\n \n #define __isinf __redirect___isinf\n+\n+/* The following definitions, although not related to the 'double'\n+ version of 'isinf', are required to compensate for the unintended\n+ macro expansion of __isinff to __redirect___isinff, etc. in\n+ math/bits/mathcalls-helper-functions.h. */\n #define __isinff __redirect___isinff\n #define __isinfl __redirect___isinfl\n+#define __isinff128 __redirect___isinff128\n+\n #include <math.h>\n #include <math_ldbl_opt.h>\n #include <shlib-compat.h>\ndiff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan.c b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan.c\nindex 3cfe1793da..bbc59808a4 100644\n--- a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan.c\n+++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan.c\n@@ -17,8 +17,15 @@\n <http://www.gnu.org/licenses/>. */\n \n #define __isnan __redirect___isnan\n+\n+/* The following definitions, although not related to the 'double'\n+ version of 'isnan', are required to compensate for the unintended\n+ macro expansion of __isnanf to __redirect___isnanf, etc. in\n+ math/bits/mathcalls-helper-functions.h. */\n #define __isnanf __redirect___isnanf\n #define __isnanl __redirect___isnanl\n+#define __isnanf128 __redirect___isnanf128\n+\n #include <math.h>\n #include <math_ldbl_opt.h>\n #include <shlib-compat.h>\n", "prefixes": [ "v2", "2/5" ] }