Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 812178,
    "url": "http://patchwork.ozlabs.org/api/patches/812178/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1505072930-13049-1-git-send-email-johunt@akamai.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1505072930-13049-1-git-send-email-johunt@akamai.com>",
    "list_archive_url": null,
    "date": "2017-09-10T19:48:50",
    "name": "net/sched: fix pointer check in gen_handle",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ada5e85ee2a300062ba73599a03c84f4773e4f5e",
    "submitter": {
        "id": 4788,
        "url": "http://patchwork.ozlabs.org/api/people/4788/?format=api",
        "name": "Josh Hunt",
        "email": "johunt@akamai.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1505072930-13049-1-git-send-email-johunt@akamai.com/mbox/",
    "series": [
        {
            "id": 2416,
            "url": "http://patchwork.ozlabs.org/api/series/2416/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=2416",
            "date": "2017-09-10T19:48:50",
            "name": "net/sched: fix pointer check in gen_handle",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/2416/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/812178/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/812178/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tsecure) header.d=akamai.com header.i=@akamai.com header.b=\"OL8+CsjM\";\n\tdkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xr1pd6pqjz9s7g\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 11 Sep 2017 05:49:13 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751376AbdIJTtL (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 10 Sep 2017 15:49:11 -0400",
            "from mx0a-00190b01.pphosted.com ([67.231.149.131]:58014 \"EHLO\n\tmx0a-00190b01.pphosted.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1750789AbdIJTtK (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sun, 10 Sep 2017 15:49:10 -0400",
            "from pps.filterd (m0122332.ppops.net [127.0.0.1])\n\tby mx0a-00190b01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8AJlAX8027174; Sun, 10 Sep 2017 20:49:09 +0100",
            "from prod-mail-ppoint1 (prod-mail-ppoint1.akamai.com\n\t[184.51.33.18])\n\tby mx0a-00190b01.pphosted.com with ESMTP id 2cwb2w86bn-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Sun, 10 Sep 2017 20:49:09 +0100",
            "from pps.filterd (prod-mail-ppoint1.akamai.com [127.0.0.1])\n\tby prod-mail-ppoint1.akamai.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8AJk78e020567; Sun, 10 Sep 2017 15:49:07 -0400",
            "from prod-mail-relay11.akamai.com ([172.27.118.250])\n\tby prod-mail-ppoint1.akamai.com with ESMTP id 2cvbmuapxa-1;\n\tSun, 10 Sep 2017 15:49:07 -0400",
            "from bos-lpwg1 (bos-lpwg1.kendall.corp.akamai.com [172.28.12.251])\n\tby prod-mail-relay11.akamai.com (Postfix) with ESMTP id 25AF01FC88;\n\tSun, 10 Sep 2017 19:49:07 +0000 (GMT)",
            "from johunt by bos-lpwg1 with local (Exim 4.82)\n\t(envelope-from <johunt@akamai.com>)\n\tid 1dr8E6-0003P6-TR; Sun, 10 Sep 2017 15:49:06 -0400"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com;\n\th=from : to : cc :\n\tsubject : date : message-id; s=jan2016.eng;\n\tbh=tGx350hhZItuCyjcawJFu4vpVt0QgvLMrVX68QQjWN8=;\n\tb=OL8+CsjMVCyqsAnhioUBWE0uctCxdE9FQ13I/qi5jt7/S7m7inpZ+uCxpUCnKO0ygis8\n\t6AhD3GasTzazWIyn5AYSubN+qFL8BOYmlpQNWTkhejOHiJtzVr5ktVRE1TZ8oFE/FeVD\n\tyYaSWh+5Ml5+ClY2MgqDfs4Vp92a/cYgu7nV0LMagHMcpBE129nmtPuPLtWi5F9HuN3k\n\taRVfC+Bj6lZRO/ju0Tiuy+q1V64JAKLr3YMCc0A2yXYtcyX5wOR+dJ7xs/GDjQRDB7ti\n\tGpcIKBrFWomZOYlGsR1Uz/poY0FJJCmdtdgYyZXN9qgVimDygAtyHRH2EqgnUAtdL8jz\n\tZw== ",
        "From": "Josh Hunt <johunt@akamai.com>",
        "To": "davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com,\n\tjiri@resnulli.us",
        "Cc": "netdev@vger.kernel.org, Josh Hunt <johunt@akamai.com>",
        "Subject": "[PATCH] net/sched: fix pointer check in gen_handle",
        "Date": "Sun, 10 Sep 2017 15:48:50 -0400",
        "Message-Id": "<1505072930-13049-1-git-send-email-johunt@akamai.com>",
        "X-Mailer": "git-send-email 1.9.1",
        "X-Proofpoint-Virus-Version": [
            "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-10_09:, , signatures=0",
            "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-10_09:, , signatures=0"
        ],
        "X-Proofpoint-Spam-Details": [
            "rule=notspam policy=default score=0 spamscore=0\n\tsuspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709100318",
            "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011\n\tlowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709100318"
        ],
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Fixes sparse warning about pointer in gen_handle:\nnet/sched/cls_rsvp.h:392:40: warning: Using plain integer as NULL pointer\n\nFixes: 8113c095672f6 (\"net_sched: use void pointer for filter handle\")\nSigned-off-by: Josh Hunt <johunt@akamai.com>\n---\n net/sched/cls_rsvp.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/net/sched/cls_rsvp.h b/net/sched/cls_rsvp.h\nindex 98c05db85bcb..b1f6ed48bc72 100644\n--- a/net/sched/cls_rsvp.h\n+++ b/net/sched/cls_rsvp.h\n@@ -389,7 +389,7 @@ static unsigned int gen_handle(struct tcf_proto *tp, unsigned salt)\n \t\tif ((data->hgenerator += 0x10000) == 0)\n \t\t\tdata->hgenerator = 0x10000;\n \t\th = data->hgenerator|salt;\n-\t\tif (rsvp_get(tp, h) == 0)\n+\t\tif (!rsvp_get(tp, h))\n \t\t\treturn h;\n \t}\n \treturn 0;\n",
    "prefixes": []
}