Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812154/?format=api
{ "id": 812154, "url": "http://patchwork.ozlabs.org/api/patches/812154/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1505054255-2990-5-git-send-email-mark.cave-ayland@ilande.co.uk/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505054255-2990-5-git-send-email-mark.cave-ayland@ilande.co.uk>", "list_archive_url": null, "date": "2017-09-10T14:37:35", "name": "[4/4] ppc: ensure we update the decrementer value during migration", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f5d76abc48a959dcb1f26b74e02ae358fd3248be", "submitter": { "id": 12451, "url": "http://patchwork.ozlabs.org/api/people/12451/?format=api", "name": "Mark Cave-Ayland", "email": "mark.cave-ayland@ilande.co.uk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1505054255-2990-5-git-send-email-mark.cave-ayland@ilande.co.uk/mbox/", "series": [ { "id": 2404, "url": "http://patchwork.ozlabs.org/api/series/2404/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2404", "date": "2017-09-10T14:37:33", "name": "ppc: migration fixes for TCG", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2404/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812154/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqtwc2p3Wz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 00:38:56 +1000 (AEST)", "from localhost ([::1]:53206 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dr3Nu-0007ev-ES\n\tfor incoming@patchwork.ozlabs.org; Sun, 10 Sep 2017 10:38:54 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:45002)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1dr3N2-0007dS-PM\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 10:38:01 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1dr3N0-0000VH-JD\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 10:38:00 -0400", "from chuckie.co.uk ([82.165.15.123]:60557\n\thelo=s16892447.onlinehome-server.info)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mark.cave-ayland@ilande.co.uk>)\n\tid 1dr3N0-0000QO-CZ; Sun, 10 Sep 2017 10:37:58 -0400", "from host109-147-184-220.range109-147.btcentralplus.com\n\t([109.147.184.220] helo=kentang.home)\n\tby s16892447.onlinehome-server.info with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76)\n\t(envelope-from <mark.cave-ayland@ilande.co.uk>)\n\tid 1dr3Mw-00066v-6W; Sun, 10 Sep 2017 15:37:55 +0100" ], "From": "Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>", "To": "qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, \n\taik@ozlabs.ru, lvivier@redhat.com", "Date": "Sun, 10 Sep 2017 15:37:35 +0100", "Message-Id": "<1505054255-2990-5-git-send-email-mark.cave-ayland@ilande.co.uk>", "X-Mailer": "git-send-email 1.7.10.4", "In-Reply-To": "<1505054255-2990-1-git-send-email-mark.cave-ayland@ilande.co.uk>", "References": "<1505054255-2990-1-git-send-email-mark.cave-ayland@ilande.co.uk>", "X-SA-Exim-Connect-IP": "109.147.184.220", "X-SA-Exim-Mail-From": "mark.cave-ayland@ilande.co.uk", "X-SA-Exim-Version": "4.2.1 (built Sun, 08 Jan 2012 02:45:44 +0000)", "X-SA-Exim-Scanned": "Yes (on s16892447.onlinehome-server.info)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "82.165.15.123", "Subject": "[Qemu-devel] [PATCH 4/4] ppc: ensure we update the decrementer\n\tvalue during migration", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "During local testing with TCG, intermittent errors were found when trying to\nmigrate Darwin OS images.\n\nThe underlying cause was that Darwin resets the decrementer value to fairly\nsmall values on each interrupt. cpu_ppc_set_tb_clk() sets the default value\nof the decrementer to 0xffffffff during initialisation which typically\ncorresponds to several seconds. Hence when restoring the image, the guest\nwould effectively \"lose\" decrementer interrupts during this time causing\nconfusion in the guest.\n\nSigned-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>\n---\n target/ppc/machine.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/target/ppc/machine.c b/target/ppc/machine.c\nindex 10b3c41..a16a856 100644\n--- a/target/ppc/machine.c\n+++ b/target/ppc/machine.c\n@@ -176,6 +176,7 @@ static void cpu_pre_save(void *opaque)\n env->spr[SPR_CFAR] = env->cfar;\n #endif\n env->spr[SPR_BOOKE_SPEFSCR] = env->spe_fscr;\n+ env->spr[SPR_DECR] = cpu_ppc_load_decr(env);\n \n for (i = 0; (i < 4) && (i < env->nb_BATs); i++) {\n env->spr[SPR_DBAT0U + 2*i] = env->DBAT[0][i];\n@@ -280,6 +281,7 @@ static int cpu_post_load(void *opaque, int version_id)\n env->cfar = env->spr[SPR_CFAR];\n #endif\n env->spe_fscr = env->spr[SPR_BOOKE_SPEFSCR];\n+ cpu_ppc_store_decr(env, env->spr[SPR_DECR]);\n \n for (i = 0; (i < 4) && (i < env->nb_BATs); i++) {\n env->DBAT[0][i] = env->spr[SPR_DBAT0U + 2*i];\n", "prefixes": [ "4/4" ] }