Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812/?format=api
{ "id": 812, "url": "http://patchwork.ozlabs.org/api/patches/812/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080922000039.GA1878@2ka.mipt.ru/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20080922000039.GA1878@2ka.mipt.ru>", "list_archive_url": null, "date": "2008-09-22T00:00:39", "name": "Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware restart.", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "d18993a5266b6e1296ca67b20d1702338a83f592", "submitter": { "id": 225, "url": "http://patchwork.ozlabs.org/api/people/225/?format=api", "name": "Evgeniy Polyakov", "email": "johnpol@2ka.mipt.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080922000039.GA1878@2ka.mipt.ru/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/812/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id D0AC8DDEE9\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 22 Sep 2008 10:01:51 +1000 (EST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753037AbYIVABr (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 21 Sep 2008 20:01:47 -0400", "(majordomo@vger.kernel.org) by vger.kernel.org id S1752822AbYIVABr\n\t(ORCPT <rfc822; netdev-outgoing>); Sun, 21 Sep 2008 20:01:47 -0400", "from relay.2ka.mipt.ru ([194.85.80.65]:60064 \"EHLO 2ka.mipt.ru\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752402AbYIVABq (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tSun, 21 Sep 2008 20:01:46 -0400", "from 2ka.mipt.ru (localhost [127.0.0.1])\n\tby 2ka.mipt.ru (8.14.1/8.14.1) with ESMTP id m8M00eBI007693;\n\tMon, 22 Sep 2008 04:00:40 +0400", "(from johnpol@localhost)\n\tby 2ka.mipt.ru (8.14.1/8.12.1/Submit) id m8M00dns007627;\n\tMon, 22 Sep 2008 04:00:39 +0400" ], "Date": "Mon, 22 Sep 2008 04:00:39 +0400", "From": "Evgeniy Polyakov <johnpol@2ka.mipt.ru>", "To": "Marcel Holtmann <holtmann@linux.intel.com>", "Cc": "Arjan van de Ven <arjan@infradead.org>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tipw2100-devel@lists.sourceforge.net,\n\tlinux-wireless@vger.kernel.org, yi.zhu@intel.com,\n\treinette.chatre@intel.com, jgarzik@pobox.com,\n\tlinville@tuxdriver.com, davem@davemloft.net", "Subject": "Re: Mark IPW2100 as BROKEN: Fatal interrupt. Scheduling firmware\n\trestart.", "Message-ID": "<20080922000039.GA1878@2ka.mipt.ru>", "References": "<20080921190050.GA20484@2ka.mipt.ru>\n\t<1222024444.3023.53.camel@johannes.berg>\n\t<20080921193809.GA8735@2ka.mipt.ru>\n\t<20080921124332.67ddc13a@infradead.org>\n\t<20080921202057.GB25052@2ka.mipt.ru>\n\t<20080921132753.5689b564@infradead.org>\n\t<20080921205706.GA24545@2ka.mipt.ru>\n\t<20080921140203.4698a2ee@infradead.org>\n\t<20080921210554.GA2135@2ka.mipt.ru>\n\t<1222039667.6782.125.camel@californication>", "Mime-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<1222039667.6782.125.camel@californication>", "User-Agent": "Mutt/1.5.9i", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "On Mon, Sep 22, 2008 at 01:27:47AM +0200, Marcel Holtmann (holtmann@linux.intel.com) wrote:\n> as Arjan and Alan pointed out already, WARN_ON_ONCE is enough and I\n> agree with them. Just to make this perfectly clear, this is with my\n> community hat on.\n> \n> Please send a proper patch with a simple WARN_ON_ONCE and I am happy to\n> sign off on it.\n\nI really do not care about if there is warning at all, I just want that\nbug to be fixed. And a we can see, something started to change, and that's\nprobably a good sign. I glad there is a result. I will check d3 states\ntomorrow. Attached patch if you think it is yet needed.", "diff": "diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c\nindex 19a401c..637dc05 100644\n--- a/drivers/net/wireless/ipw2100.c\n+++ b/drivers/net/wireless/ipw2100.c\n@@ -3174,16 +3174,18 @@ static void ipw2100_irq_tasklet(struct ipw2100_priv *priv)\n \tif (inta & IPW2100_INTA_FATAL_ERROR) {\n \t\tprintk(KERN_WARNING DRV_NAME\n \t\t \": Fatal interrupt. Scheduling firmware restart.\\n\");\n+\n \t\tpriv->inta_other++;\n \t\twrite_register(dev, IPW_REG_INTA, IPW2100_INTA_FATAL_ERROR);\n \n \t\tread_nic_dword(dev, IPW_NIC_FATAL_ERROR, &priv->fatal_error);\n-\t\tIPW_DEBUG_INFO(\"%s: Fatal error value: 0x%08X\\n\",\n-\t\t\t priv->net_dev->name, priv->fatal_error);\n-\n \t\tread_nic_dword(dev, IPW_ERROR_ADDR(priv->fatal_error), &tmp);\n-\t\tIPW_DEBUG_INFO(\"%s: Fatal error address value: 0x%08X\\n\",\n-\t\t\t priv->net_dev->name, tmp);\n+\n+\t\tprintk(KERN_WARNING \"%s: Fatal error value: 0x%08X, \"\n+\t\t\t\t\"address: 0x%08X, inta: 0x%08lX\\n\",\n+\t\t\tpriv->net_dev->name, priv->fatal_error, tmp,\n+\t\t\t(unsigned long)inta & IPW_INTERRUPT_MASK);\n+\t\tWARN_ON_ONCE(1);\n \n \t\t/* Wake up any sleeping jobs */\n \t\tschedule_reset(priv);\n", "prefixes": [] }