Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811966/?format=api
{ "id": 811966, "url": "http://patchwork.ozlabs.org/api/patches/811966/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/150496957801.9654.17692506571556698840.stgit@bahia/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<150496957801.9654.17692506571556698840.stgit@bahia>", "list_archive_url": null, "date": "2017-09-09T15:06:18", "name": "[3/5] spapr_pci: use g_strdup_printf()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1b110c49129ba1a2649961082282248bb7616c05", "submitter": { "id": 69178, "url": "http://patchwork.ozlabs.org/api/people/69178/?format=api", "name": "Greg Kurz", "email": "groug@kaod.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/150496957801.9654.17692506571556698840.stgit@bahia/mbox/", "series": [ { "id": 2354, "url": "http://patchwork.ozlabs.org/api/series/2354/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2354", "date": "2017-09-09T15:05:46", "name": "spapr_pci: various cleanups and improvements", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2354/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811966/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811966/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqHjV6rKRz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 10 Sep 2017 01:12:14 +1000 (AEST)", "from localhost ([::1]:49901 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqhQb-0003W4-2m\n\tfor incoming@patchwork.ozlabs.org; Sat, 09 Sep 2017 11:12:13 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:50969)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <groug@kaod.org>) id 1dqhL1-0007ps-Lw\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 11:06:32 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <groug@kaod.org>) id 1dqhKw-00069q-Of\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 11:06:27 -0400", "from 6.mo177.mail-out.ovh.net ([46.105.51.249]:53098)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <groug@kaod.org>) id 1dqhKw-000687-3Z\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 11:06:22 -0400", "from player714.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo177.mail-out.ovh.net (Postfix) with ESMTP id CDAE871BB4\n\tfor <qemu-devel@nongnu.org>; Sat, 9 Sep 2017 17:06:20 +0200 (CEST)", "from [192.168.0.243] (gar31-1-82-66-74-139.fbx.proxad.net\n\t[82.66.74.139]) (Authenticated sender: groug@kaod.org)\n\tby player714.ha.ovh.net (Postfix) with ESMTPA id 955683C0073;\n\tSat, 9 Sep 2017 17:06:18 +0200 (CEST)" ], "From": "Greg Kurz <groug@kaod.org>", "To": "qemu-devel@nongnu.org", "Date": "Sat, 09 Sep 2017 17:06:18 +0200", "Message-ID": "<150496957801.9654.17692506571556698840.stgit@bahia>", "In-Reply-To": "<150496954641.9654.1998704077006846521.stgit@bahia>", "References": "<150496954641.9654.1998704077006846521.stgit@bahia>", "User-Agent": "StGit/0.17.1-46-g6855-dirty", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-Ovh-Tracer-Id": "246572081182185811", "X-VR-SPAMSTATE": "OK", "X-VR-SPAMSCORE": "-100", "X-VR-SPAMCAUSE": "gggruggvucftvghtrhhoucdtuddrfeelledrfeeigdekjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "46.105.51.249", "Subject": "[Qemu-devel] [PATCH 3/5] spapr_pci: use g_strdup_printf()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Building strings with g_strdup_printf() instead of snprintf() is\na QEMU common practice.\n\nSigned-off-by: Greg Kurz <groug@kaod.org>\n---\n hw/ppc/spapr_pci.c | 19 ++++++++++---------\n 1 file changed, 10 insertions(+), 9 deletions(-)", "diff": "diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c\nindex cd8efb181223..6da73fe6bc29 100644\n--- a/hw/ppc/spapr_pci.c\n+++ b/hw/ppc/spapr_pci.c\n@@ -61,8 +61,6 @@\n #define RTAS_TYPE_MSI 1\n #define RTAS_TYPE_MSIX 2\n \n-#define FDT_NAME_MAX 128\n-\n #define _FDT(exp) \\\n do { \\\n int ret = (exp); \\\n@@ -1194,7 +1192,7 @@ static const char *pci_find_device_name(uint8_t class, uint8_t subclass,\n return name;\n }\n \n-static void pci_get_node_name(char *nodename, int len, PCIDevice *dev)\n+static gchar *pci_get_node_name(PCIDevice *dev)\n {\n int slot = PCI_SLOT(dev->devfn);\n int func = PCI_FUNC(dev->devfn);\n@@ -1205,9 +1203,9 @@ static void pci_get_node_name(char *nodename, int len, PCIDevice *dev)\n ccode & 0xff);\n \n if (func != 0) {\n- snprintf(nodename, len, \"%s@%x,%x\", name, slot, func);\n+ return g_strdup_printf(\"%s@%x,%x\", name, slot, func);\n } else {\n- snprintf(nodename, len, \"%s@%x\", name, slot);\n+ return g_strdup_printf(\"%s@%x\", name, slot);\n }\n }\n \n@@ -1325,10 +1323,12 @@ static int spapr_create_pci_child_dt(sPAPRPHBState *phb, PCIDevice *dev,\n void *fdt, int node_offset)\n {\n int offset, ret;\n- char nodename[FDT_NAME_MAX];\n+ gchar *nodename;\n \n- pci_get_node_name(nodename, FDT_NAME_MAX, dev);\n+ nodename = pci_get_node_name(dev);\n offset = fdt_add_subnode(fdt, node_offset, nodename);\n+ g_free(nodename);\n+\n ret = spapr_populate_pci_child_dt(dev, fdt, offset, phb);\n \n g_assert(!ret);\n@@ -2072,7 +2072,7 @@ int spapr_populate_pci_dt(sPAPRPHBState *phb,\n void *fdt)\n {\n int bus_off, i, j, ret;\n- char nodename[FDT_NAME_MAX];\n+ gchar *nodename;\n uint32_t bus_range[] = { cpu_to_be32(0), cpu_to_be32(0xff) };\n struct {\n uint32_t hi;\n@@ -2121,8 +2121,9 @@ int spapr_populate_pci_dt(sPAPRPHBState *phb,\n sPAPRFDT s_fdt;\n \n /* Start populating the FDT */\n- snprintf(nodename, FDT_NAME_MAX, \"pci@%\" PRIx64, phb->buid);\n+ nodename = g_strdup_printf(\"pci@%\" PRIx64, phb->buid);\n bus_off = fdt_add_subnode(fdt, 0, nodename);\n+ g_free(nodename);\n if (bus_off < 0) {\n return bus_off;\n }\n", "prefixes": [ "3/5" ] }