Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811796/?format=api
{ "id": 811796, "url": "http://patchwork.ozlabs.org/api/patches/811796/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504894024-2750-12-git-send-email-ldufour@linux.vnet.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<1504894024-2750-12-git-send-email-ldufour@linux.vnet.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/1504894024-2750-12-git-send-email-ldufour@linux.vnet.ibm.com/", "date": "2017-09-08T18:06:55", "name": "[v3,11/20] mm: Introduce __maybe_mkwrite()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "fee351a4f4c7718d35d620c676bd37751feb5db2", "submitter": { "id": 40248, "url": "http://patchwork.ozlabs.org/api/people/40248/?format=api", "name": "Laurent Dufour", "email": "ldufour@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504894024-2750-12-git-send-email-ldufour@linux.vnet.ibm.com/mbox/", "series": [ { "id": 2269, "url": "http://patchwork.ozlabs.org/api/series/2269/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=2269", "date": "2017-09-08T18:06:44", "name": "Speculative page faults", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/2269/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811796/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811796/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpmQr0tLgz9s82\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Sep 2017 04:42:44 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xpmQp29v3zDqG4\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Sep 2017 04:42:42 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xplfc6fqmzDrYd\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 9 Sep 2017 04:07:52 +1000 (AEST)", "from pps.filterd (m0098420.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv88I5m8o068923\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 8 Sep 2017 14:07:50 -0400", "from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cux3knxup-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 08 Sep 2017 14:07:50 -0400", "from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@lists.ozlabs.org> from <ldufour@linux.vnet.ibm.com>;\n\tFri, 8 Sep 2017 19:07:48 +0100", "from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 8 Sep 2017 19:07:41 +0100", "from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com\n\t[9.149.105.60])\n\tby b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v88I7f4s21954596; Fri, 8 Sep 2017 18:07:41 GMT", "from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 35E834203F;\n\tFri, 8 Sep 2017 19:04:08 +0100 (BST)", "from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 727694204C;\n\tFri, 8 Sep 2017 19:04:06 +0100 (BST)", "from nimbus.lab.toulouse-stg.fr.ibm.com (unknown [9.145.31.125])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tFri, 8 Sep 2017 19:04:06 +0100 (BST)" ], "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=ldufour@linux.vnet.ibm.com; receiver=<UNKNOWN>)", "From": "Laurent Dufour <ldufour@linux.vnet.ibm.com>", "To": "paulmck@linux.vnet.ibm.com, peterz@infradead.org,\n\takpm@linux-foundation.org, kirill@shutemov.name, ak@linux.intel.com, \n\tmhocko@kernel.org, dave@stgolabs.net, jack@suse.cz,\n\tMatthew Wilcox <willy@infradead.org>, benh@kernel.crashing.org,\n\tmpe@ellerman.id.au, paulus@samba.org,\n\tThomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, \n\thpa@zytor.com, Will Deacon <will.deacon@arm.com>,\n\tSergey Senozhatsky <sergey.senozhatsky@gmail.com>", "Subject": "[PATCH v3 11/20] mm: Introduce __maybe_mkwrite()", "Date": "Fri, 8 Sep 2017 20:06:55 +0200", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1504894024-2750-1-git-send-email-ldufour@linux.vnet.ibm.com>", "References": "<1504894024-2750-1-git-send-email-ldufour@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17090818-0040-0000-0000-000003F89DBE", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17090818-0041-0000-0000-00002099A53F", "Message-Id": "<1504894024-2750-12-git-send-email-ldufour@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-08_12:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=2\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709080270", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "linuxppc-dev@lists.ozlabs.org, x86@kernel.org,\n\tlinux-kernel@vger.kernel.org, npiggin@gmail.com, linux-mm@kvack.org,\n\tTim Chen <tim.c.chen@linux.intel.com>, \n\tharen@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "The current maybe_mkwrite() is getting passed the pointer to the vma\nstructure to fetch the vm_flags field.\n\nWhen dealing with the speculative page fault handler, it will be better to\nrely on the cached vm_flags value stored in the vm_fault structure.\n\nThis patch introduce a __maybe_mkwrite() service which can be called by\npassing the value of the vm_flags field.\n\nThere is no change functional changes expected for the other callers of\nmaybe_mkwrite().\n\nSigned-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>\n---\n include/linux/mm.h | 9 +++++++--\n mm/memory.c | 6 +++---\n 2 files changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/linux/mm.h b/include/linux/mm.h\nindex 5fd90ac31317..bb0c87f1c725 100644\n--- a/include/linux/mm.h\n+++ b/include/linux/mm.h\n@@ -673,13 +673,18 @@ void free_compound_page(struct page *page);\n * pte_mkwrite. But get_user_pages can cause write faults for mappings\n * that do not have writing enabled, when used by access_process_vm.\n */\n-static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma)\n+static inline pte_t __maybe_mkwrite(pte_t pte, unsigned long vma_flags)\n {\n-\tif (likely(vma->vm_flags & VM_WRITE))\n+\tif (likely(vma_flags & VM_WRITE))\n \t\tpte = pte_mkwrite(pte);\n \treturn pte;\n }\n \n+static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma)\n+{\n+\treturn __maybe_mkwrite(pte, vma->vm_flags);\n+}\n+\n int alloc_set_pte(struct vm_fault *vmf, struct mem_cgroup *memcg,\n \t\tstruct page *page);\n int finish_fault(struct vm_fault *vmf);\ndiff --git a/mm/memory.c b/mm/memory.c\nindex 4583f354be94..c306f1f64c9e 100644\n--- a/mm/memory.c\n+++ b/mm/memory.c\n@@ -2408,7 +2408,7 @@ static inline void wp_page_reuse(struct vm_fault *vmf)\n \n \tflush_cache_page(vma, vmf->address, pte_pfn(vmf->orig_pte));\n \tentry = pte_mkyoung(vmf->orig_pte);\n-\tentry = maybe_mkwrite(pte_mkdirty(entry), vma);\n+\tentry = __maybe_mkwrite(pte_mkdirty(entry), vmf->vma_flags);\n \tif (ptep_set_access_flags(vma, vmf->address, vmf->pte, entry, 1))\n \t\tupdate_mmu_cache(vma, vmf->address, vmf->pte);\n \tpte_unmap_unlock(vmf->pte, vmf->ptl);\n@@ -2498,8 +2498,8 @@ static int wp_page_copy(struct vm_fault *vmf)\n \t\t\tinc_mm_counter_fast(mm, MM_ANONPAGES);\n \t\t}\n \t\tflush_cache_page(vma, vmf->address, pte_pfn(vmf->orig_pte));\n-\t\tentry = mk_pte(new_page, vma->vm_page_prot);\n-\t\tentry = maybe_mkwrite(pte_mkdirty(entry), vma);\n+\t\tentry = mk_pte(new_page, vmf->vma_page_prot);\n+\t\tentry = __maybe_mkwrite(pte_mkdirty(entry), vmf->vma_flags);\n \t\t/*\n \t\t * Clear the pte entry and flush it first, before updating the\n \t\t * pte with the new entry. This will avoid a race condition\n", "prefixes": [ "v3", "11/20" ] }