Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811651/?format=api
{ "id": 811651, "url": "http://patchwork.ozlabs.org/api/patches/811651/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20170908153604.28383-2-romain.izard.pro@gmail.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908153604.28383-2-romain.izard.pro@gmail.com>", "list_archive_url": null, "date": "2017-09-08T15:35:55", "name": "[v1,01/10] clk: at91: pmc: Wait for clocks when resuming", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3c0aefa7e09b25b04e247655ccad78b77581748f", "submitter": { "id": 8236, "url": "http://patchwork.ozlabs.org/api/people/8236/?format=api", "name": "Romain Izard", "email": "romain.izard.pro@gmail.com" }, "delegate": { "id": 58324, "url": "http://patchwork.ozlabs.org/api/users/58324/?format=api", "username": "bbrezillon", "first_name": "Boris", "last_name": "Brezillon", "email": "boris.brezillon@free-electrons.com" }, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20170908153604.28383-2-romain.izard.pro@gmail.com/mbox/", "series": [ { "id": 2239, "url": "http://patchwork.ozlabs.org/api/series/2239/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=2239", "date": "2017-09-08T15:35:55", "name": "Various patches for SAMA5D2 backup mode", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2239/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811651/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811651/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"c1hhGcS8\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"i6EOBulN\"; dkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xphMV6Hqsz9t3F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 9 Sep 2017 01:39:31 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqLL4-0006RS-OC; Fri, 08 Sep 2017 15:37:02 +0000", "from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqLKf-00066v-Ov; Fri, 08 Sep 2017 15:36:39 +0000", "by mail-wm0-x242.google.com with SMTP id e64so1985407wmi.2;\n\tFri, 08 Sep 2017 08:36:16 -0700 (PDT)", "from localhost.localdomain (146.187.3.109.rev.sfr.net.\n\t[109.3.187.146]) by smtp.gmail.com with ESMTPSA id\n\tp199sm1689224wmb.28.2017.09.08.08.36.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 08:36:14 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=Vayr77kqbaog+q+1CnYzSWXbefHZtNBWmDlqW2Uoyco=;\n\tb=c1hhGcS8tsDLJYgeI9CNJBy87W\n\tAs97rVQw6VfgoPraUyLGs45VHX/Ra59NxjFYqoSbn5DRVhAC20m1JIwVTa6vXqnkBRazhTGAL5ajN\n\tV/6rwpLo1ajBCacZgqOTl2Rmy9yh3VLdN8adv4hXav8eMKk6x5rhgPxF88qzOTm0dy9toqGnH0wPF\n\tGfQr4zXi+W9R2ApQDdBsy18vV68WqKMQq6hN3FeIhZUAbqNmBe8k/Jv6r21xG1xsjhqOs7+GI5ayo\n\tIPyWOYRpnwkVNiYU+7VSfu4muAX6JgH9mUHUw1Cu3hLHMZXCfYlLiAJgpNiNAkBF5BMtymH8rdVWC\n\tvkuNANVQ==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=QpAJytz+aiNN6ugMH0pd0IRk4M6Nw+EoUUnBnzUoU6Q=;\n\tb=i6EOBulN8YFDPPcLnFOi2ORTbNpVr5uBBKSVaIhENa2jfTZx0sLc+ugZDHWClO1GwQ\n\tbhrAv2RM1KdbKFPEv3g4kBTFJKYR0xZGPC1pOAazcu3m+D7dt9Djf/WHPnjTMvsNobRr\n\tXQ1fMPAyTJFzk23gt6Qfz2Pp0XAJJsXzF/oOhAcSuG7t1KLFAzqwg516F+WjudqcbEZw\n\tEPvojp4xWi0mPdKhRy6Er9Exko5AhW6RFL5KJ2pX7xR2JHzg3J+Dtb7K1YFRYBbN63wt\n\txMNz9zn8kJ2NF6cwfJczwOcnkmCl/+XVNgYM4hWWkAYgT28Khnfyz+wR3jnLXYszsI/8\n\t+GeA==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=QpAJytz+aiNN6ugMH0pd0IRk4M6Nw+EoUUnBnzUoU6Q=;\n\tb=qRctaAT6tjHHvlNFYZRe81dfxsfuPDyUQr8UUvVTFxfWPlPlX6541jZHDkdbGMqJJJ\n\t0AnnirzZ7Ny4RTdcS/OO3tiLgZ2JELxs7/NWEHJUxOtNDXVq29Qnm/s9kdkaEcbgfsdd\n\tUSqFTNu5QLLHQK/9pB6d+8xcF1tcseD2HPgvHGR6Lgf6UaWXqbCGzrLje28Io+YIz27u\n\t9i1BV/DwEJ9iMp4UtA+rBMqrtfRlB+3PpI7rhRgbJFdKU0bmHY/ZF+acevDYCxOPqbIh\n\taZTDN4pjHCCFU/5qEdP9rfHLhWjzUkJ3tF39afjrbNLmqsqg43O3o8mOBJNuLMYazOPG\n\t31WQ==", "X-Gm-Message-State": "AHPjjUievI8m3d4Nw7FoUZNqDzZ4Dsqn67dMrxoP0z9qkzQqnUEmNVag\n\tniH6GxsuGvuHtFqZ27DWzo0=", "X-Google-Smtp-Source": "ADKCNb4fLcqaI4Bbux5Uj+MvxzRvSdLca1ahW6b+xJ5qnWs3ry78s7WhZ/UvNl37XkVAX6PhlG5ZZA==", "X-Received": "by 10.28.48.71 with SMTP id w68mr213535wmw.3.1504884975148;\n\tFri, 08 Sep 2017 08:36:15 -0700 (PDT)", "From": "Romain Izard <romain.izard.pro@gmail.com>", "To": "Nicolas Ferre <nicolas.ferre@microchip.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tMichael Turquette <mturquette@baylibre.com>,\n\tStephen Boyd <sboyd@codeaurora.org>,\n\tLudovic Desroches <ludovic.desroches@microchip.com>,\n\tJonathan Cameron <jic23@kernel.org>,\n\tWenyou Yang <wenyou.yang@atmel.com>, Josh Wu <rainyfeeling@outlook.com>,\n\tDavid Woodhouse <dwmw2@infradead.org>, \n\tBrian Norris <computersforpeace@gmail.com>,\n\tMarek Vasut <marek.vasut@gmail.com>,\n\tCyrille Pitchen <cyrille.pitchen@wedev4u.fr>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tRichard Genoud <richard.genoud@gmail.com>,\n\tGreg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\tAlan Stern <stern@rowland.harvard.edu>", "Subject": "[PATCH v1 01/10] clk: at91: pmc: Wait for clocks when resuming", "Date": "Fri, 8 Sep 2017 17:35:55 +0200", "Message-Id": "<20170908153604.28383-2-romain.izard.pro@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170908153604.28383-1-romain.izard.pro@gmail.com>", "References": "<20170908153604.28383-1-romain.izard.pro@gmail.com>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170908_083637_978175_497A9C41 ", "X-CRM114-Status": "GOOD ( 12.31 )", "X-Spam-Score": "-2.0 (--)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c09:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (romain.izard.pro[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Cc": "linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-mtd@lists.infradead.org, linux-serial@vger.kernel.org,\n\tRomain Izard <romain.izard.pro@gmail.com>, linux-clk@vger.kernel.org, \n\tlinux-arm-kernel@lists.infradead.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Wait for the syncronization of all clocks when resuming, not only the\nUPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG()\nwhen interrupts are masked, which is the case in here.\n\nSigned-off-by: Romain Izard <romain.izard.pro@gmail.com>\n---\n drivers/clk/at91/pmc.c | 24 ++++++++++++++++--------\n 1 file changed, 16 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\nindex 775af473fe11..5c2b26de303e 100644\n--- a/drivers/clk/at91/pmc.c\n+++ b/drivers/clk/at91/pmc.c\n@@ -107,10 +107,20 @@ static int pmc_suspend(void)\n \treturn 0;\n }\n \n+static bool pmc_ready(unsigned int mask)\n+{\n+\tunsigned int status;\n+\n+\tregmap_read(pmcreg, AT91_PMC_SR, &status);\n+\n+\treturn ((status & mask) == mask) ? 1 : 0;\n+}\n+\n static void pmc_resume(void)\n {\n-\tint i, ret = 0;\n+\tint i;\n \tu32 tmp;\n+\tu32 mask = AT91_PMC_MCKRDY | AT91_PMC_LOCKA;\n \n \tregmap_read(pmcreg, AT91_PMC_MCKR, &tmp);\n \tif (pmc_cache.mckr != tmp)\n@@ -134,13 +144,11 @@ static void pmc_resume(void)\n \t\t\t AT91_PMC_PCR_CMD);\n \t}\n \n-\tif (pmc_cache.uckr & AT91_PMC_UPLLEN) {\n-\t\tret = regmap_read_poll_timeout(pmcreg, AT91_PMC_SR, tmp,\n-\t\t\t\t\t !(tmp & AT91_PMC_LOCKU),\n-\t\t\t\t\t 10, 5000);\n-\t\tif (ret)\n-\t\t\tpr_crit(\"USB PLL didn't lock when resuming\\n\");\n-\t}\n+\tif (pmc_cache.uckr & AT91_PMC_UPLLEN)\n+\t\tmask |= AT91_PMC_LOCKU;\n+\n+\twhile (!pmc_ready(mask))\n+\t\tcpu_relax();\n }\n \n static struct syscore_ops pmc_syscore_ops = {\n", "prefixes": [ "v1", "01/10" ] }