Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811616/?format=api
{ "id": 811616, "url": "http://patchwork.ozlabs.org/api/patches/811616/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908135831.10556-4-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908135831.10556-4-berrange@redhat.com>", "list_archive_url": null, "date": "2017-09-08T13:58:31", "name": "[v3,3/3] io: use case insensitive check for Connection & Upgrade websock headers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5ff8317ddf70ffd4d2cdbc170d640efc249c4aae", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908135831.10556-4-berrange@redhat.com/mbox/", "series": [ { "id": 2221, "url": "http://patchwork.ozlabs.org/api/series/2221/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2221", "date": "2017-09-08T13:58:30", "name": "Improve websock response / error handling", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/2221/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811616/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811616/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com" ], "Received": [ "from lists.gnu.org (unknown [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpfGL2nzqz9s7G\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 9 Sep 2017 00:04:57 +1000 (AEST)", "from localhost ([::1]:45594 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqJtl-0006cM-3V\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 10:04:45 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:42520)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <berrange@redhat.com>) id 1dqJo0-00027p-EE\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 09:58:49 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <berrange@redhat.com>) id 1dqJnz-0005mZ-Ne\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 09:58:48 -0400", "from mx1.redhat.com ([209.132.183.28]:35626)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <berrange@redhat.com>) id 1dqJnz-0005lQ-IW\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 09:58:47 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7F2AC81DFA;\n\tFri, 8 Sep 2017 13:58:46 +0000 (UTC)", "from t460.redhat.com (unknown [10.33.36.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8C12217A76;\n\tFri, 8 Sep 2017 13:58:42 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 7F2AC81DFA", "From": "\"Daniel P. Berrange\" <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 8 Sep 2017 14:58:31 +0100", "Message-Id": "<20170908135831.10556-4-berrange@redhat.com>", "In-Reply-To": "<20170908135831.10556-1-berrange@redhat.com>", "References": "<20170908135831.10556-1-berrange@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 08 Sep 2017 13:58:46 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v3 3/3] io: use case insensitive check for\n\tConnection & Upgrade websock headers", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Brian Rak <brak@vultr.com>, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t<f4bug@amsat.org>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "When checking the value of the Connection and Upgrade HTTP headers\nthe websock RFC (6455) requires the comparison to be case insensitive.\nThe Connection value should be an exact match not a substring.\n\nReviewed-by: Eric Blake <eblake@redhat.com>\nSigned-off-by: Daniel P. Berrange <berrange@redhat.com>\n---\n io/channel-websock.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/io/channel-websock.c b/io/channel-websock.c\nindex 5d2df95596..145cfb6a55 100644\n--- a/io/channel-websock.c\n+++ b/io/channel-websock.c\n@@ -432,12 +432,12 @@ static void qio_channel_websock_handshake_process(QIOChannelWebsock *ioc,\n goto bad_request;\n }\n \n- if (!g_strrstr(connection, QIO_CHANNEL_WEBSOCK_CONNECTION_UPGRADE)) {\n+ if (strcasecmp(connection, QIO_CHANNEL_WEBSOCK_CONNECTION_UPGRADE) != 0) {\n error_setg(errp, \"No connection upgrade requested '%s'\", connection);\n goto bad_request;\n }\n \n- if (!g_str_equal(upgrade, QIO_CHANNEL_WEBSOCK_UPGRADE_WEBSOCKET)) {\n+ if (strcasecmp(upgrade, QIO_CHANNEL_WEBSOCK_UPGRADE_WEBSOCKET) != 0) {\n error_setg(errp, \"Incorrect upgrade method '%s'\", upgrade);\n goto bad_request;\n }\n", "prefixes": [ "v3", "3/3" ] }