Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811542/?format=api
{ "id": 811542, "url": "http://patchwork.ozlabs.org/api/patches/811542/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/001c01d32895$483027f0$d89077d0$@samsung.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<001c01d32895$483027f0$d89077d0$@samsung.com>", "list_archive_url": null, "date": "2017-09-08T11:26:14", "name": "[1/1] AArch64: Fix single stepping of ERET instruction", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e0bef5b17f0006572a5b4da6bd2893d830fa5808", "submitter": { "id": 71957, "url": "http://patchwork.ozlabs.org/api/people/71957/?format=api", "name": "Jaroslaw Pelczar", "email": "j.pelczar@samsung.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/001c01d32895$483027f0$d89077d0$@samsung.com/mbox/", "series": [ { "id": 2184, "url": "http://patchwork.ozlabs.org/api/series/2184/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2184", "date": "2017-09-08T11:26:14", "name": "[1/1] AArch64: Fix single stepping of ERET instruction", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2184/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811542/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811542/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpZrS1K0Zz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 21:30:48 +1000 (AEST)", "from localhost ([::1]:44786 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqHUk-0002Tu-81\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 07:30:46 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51516)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <j.pelczar@samsung.com>) id 1dqHQW-00076T-IF\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:26:25 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <j.pelczar@samsung.com>) id 1dqHQS-00013N-1W\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:26:24 -0400", "from mailout2.w1.samsung.com ([210.118.77.12]:51140)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <j.pelczar@samsung.com>)\n\tid 1dqHQR-000129-R6\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:26:19 -0400", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n\tby mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20170908112616euoutp025121cda0b9cc847654e9bf8ed1f4ab4d~iX0VTP3Z61996519965euoutp02I\n\tfor <qemu-devel@nongnu.org>; Fri, 8 Sep 2017 11:26:16 +0000 (GMT)", "from eusmges4.samsung.com (unknown [203.254.199.244]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTP id\n\t20170908112616eucas1p1537ccf55d4abe3396cf4559eb829baf5~iX0Ul-9dP2948829488eucas1p1g\n\tfor <qemu-devel@nongnu.org>; Fri, 8 Sep 2017 11:26:16 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n\teusmges4.samsung.com (EUCPMTA) with SMTP id C4.70.12944.75E72B95;\n\tFri, 8 Sep 2017 12:26:15 +0100 (BST)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTP id\n\t20170908112615eucas1p12372f91b57dad31cdcfad2d7b5683c7a~iX0TtG3Te3026230262eucas1p1c\n\tfor <qemu-devel@nongnu.org>; Fri, 8 Sep 2017 11:26:15 +0000 (GMT)", "from eusync3.samsung.com ( [203.254.199.213]) by\n\teusmgms2.samsung.com (EUCPMTA) with SMTP id 91.55.20118.75E72B95;\n\tFri, 8 Sep 2017 12:26:15 +0100 (BST)", "from AMDN1843 ([106.120.52.68]) by eusync3.samsung.com (Oracle\n\tCommunications Messaging Server 7.0.5.31.0 64bit (built May 5 2014))\n\twith ESMTPA id <0OVY00JXFL3QR360@eusync3.samsung.com> for\n\tqemu-devel@nongnu.org; Fri, 08 Sep 2017 12:26:15 +0100 (BST)" ], "X-AuditID": "cbfec7f4-f79ab6d000003290-24-59b27e57d03e", "From": "Jaroslaw Pelczar <j.pelczar@samsung.com>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 08 Sep 2017 13:26:14 +0200", "Message-id": "<001c01d32895$483027f0$d89077d0$@samsung.com>", "MIME-version": "1.0", "Content-type": "text/plain; charset=\"us-ascii\"", "Content-transfer-encoding": "7bit", "X-Mailer": "Microsoft Outlook 14.0", "Thread-index": "AdMokUb29KFN5T8PRlCzIe249EE0ug==", "Content-language": "pl", "X-Brightmail-Tracker": [ "H4sIAAAAAAAAA+NgFnrEIsWRmVeSWpSXmKPExsWy7djPc7rhdZsiDRqmmVgc793B4sDo8eTa\n\tZqYAxigum5TUnMyy1CJ9uwSujL0HZrEV7GavWLjnKksD40vWLkZODgkBE4n5C3YzQthiEhfu\n\trWfrYuTiEBJYyijRtfMPlNPPJNGy8CsjTMfd/ifsEIlljBJH7u9mgXC6mSSedc5mAaliE9CT\n\tOP/oLViHiICkxO+u08wgtrCAq0TbyvVMIDaLgKrEmc2z2UFsXgFLiX+3TrNA2IISPybfA7OZ\n\tBXQkzh5bxwhhy0tsXvOWGeIKBYkdZ19DzdeTONc9EapeROJuw3NWkIMkBF6ySjzddQ/qUReJ\n\tNW3/oJqFJV4d38IOYctIXJ7czQLRMJlR4vHah1DOakaJxiXrWSCqrCU23XjFBLGCT2LStulA\n\tkziA4rwSHW1CECUeEu93LIRa4Chx6ttMNhBbSCBW4uX366wTGOVmIXluFpLnZiF5bhaSJxYw\n\tsqxiFEktLc5NTy020StOzC0uzUvXS87P3cQIjPnT/45/2cG4+JjVIUYBDkYlHt6I/I2RQqyJ\n\tZcWVuYcYJTiYlUR4HSo3RQrxpiRWVqUW5ccXleakFh9ilOZgURLntY1qixQSSE8sSc1OTS1I\n\tLYLJMnFwSjUwen41mXj25eWg3+96JRLqvRctaLaKWXr/iBHbTaHHKoXx+fdXLNtYMTPZt0/7\n\tl2fXcQ5jnVMeL3POLLvEqL9fwSc/8imf2EanI+KfbmZ1Laq5MOt0k5Tge8/chQ+k1q6uYlmn\n\tfSNTK1lq2945575/u3yW6dV6kYu+Sae4Zd98kbuzxmirQPQeQyWW4oxEQy3mouJEAERbMCz1\n\tAgAA", "H4sIAAAAAAAAA+NgFlrFLMWRmVeSWpSXmKPExsVy+t/xq7rhdZsiDXZtYbc43ruDxYHR48m1\n\tzUwBjFFcNimpOZllqUX6dglcGXsPzGIr2M1esXDPVZYGxpesXYycHBICJhJ3+5+wQ9hiEhfu\n\trWfrYuTiEBJYwihx/tRSKKeXSeL8st2MIFVsAnoS5x+9BbNFBCQlfnedZgaxhQVcJdpWrmcC\n\tsVkEVCXObJ4NNpVXwFLi363TLBC2oMSPyffAbGYBLYn1O48zQdjyEpvXvGWGuEJBYsfZ11Dz\n\t9STOdU+EqheRuNvwnHUCI/8sJKNmIRk1C8moWUhaFjCyrGIUSS0tzk3PLTbSK07MLS7NS9dL\n\tzs/dxAgMwW3Hfm7Zwdj1LvgQowAHoxIPr0Xwxkgh1sSy4srcQ4wSHMxKIrwOlZsihXhTEiur\n\tUovy44tKc1KLDzFKc7AoifP27lkdKSSQnliSmp2aWpBaBJNl4uCUamDM5xXbJ2C+YX8I27YJ\n\tM5carrLYI8di03jZ0mdxReSdrs9Jdgz3VjwyTnfd1vOZr/Hvk3Slt6wO/wSfPhLLYlrPv2Rj\n\t1vdnP8yL+m8HdIfVn38280TPxzehSwLvK9StkFvXv9s51eTVkypWFW7bfTqJyi1H/Nj/vs3h\n\t+3byw5yqdQHiGbZrY/crsRRnJBpqMRcVJwIARdtKZz0CAAA=" ], "X-CMS-MailID": "20170908112615eucas1p12372f91b57dad31cdcfad2d7b5683c7a", "X-Msg-Generator": "CA", "X-Sender-IP": "182.198.249.180", "X-Local-Sender": "=?utf-8?b?7JW866Gc7Iqs65287ZSEG1NSUE9MLVNlY3VyZSBPUyAo?=\n\t=?utf-8?b?VFApG+yCvOyEseyghOyekBsuL1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVl?=\n\t=?utf-8?q?r?=", "X-Global-Sender": "=?utf-8?q?Jaroslaw_Pelczar=1BSRPOL-Secure_OS_=28TP=29=1B?=\n\t=?utf-8?q?Samsung_Electronics=1B=2E/Senior_Software_Engineer?=", "X-Sender-Code": "=?utf-8?q?C10=1BEHQ=1BC10CD02CD027394?=", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20170908112615eucas1p12372f91b57dad31cdcfad2d7b5683c7a", "X-RootMTR": "20170908112615eucas1p12372f91b57dad31cdcfad2d7b5683c7a", "References": "<CGME20170908112615eucas1p12372f91b57dad31cdcfad2d7b5683c7a@eucas1p1.samsung.com>", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "210.118.77.12", "Subject": "[Qemu-devel] [PATCH 1/1] AArch64: Fix single stepping of ERET\n\tinstruction", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Previously when single stepping through ERET instruction via GDB\nwould result in debugger entering the \"next\" PC after ERET instruction.\nWhen debugging in kernel mode, this will also cause unintended behavior,\nbecause debugger will try to access memory from EL0 point of view.\n\nSigned-off-by: Jaroslaw Pelczar <j.pelczar@samsung.com>\n---\n target/arm/translate-a64.c | 1 +\n 1 file changed, 1 insertion(+)\n\n gen_exception_internal(EXCP_DEBUG);", "diff": "diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c\nindex 9017e30510..1bc12d93ca 100644\n--- a/target/arm/translate-a64.c\n+++ b/target/arm/translate-a64.c\n@@ -11348,6 +11348,7 @@ static void aarch64_tr_tb_stop(DisasContextBase\n*dcbase, CPUState *cpu)\n default:\n gen_a64_set_pc_im(dc->pc);\n /* fall through */\n+ case DISAS_EXIT:\n case DISAS_JUMP:\n if (dc->base.singlestep_enabled) {\n", "prefixes": [ "1/1" ] }