Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811522/?format=api
{ "id": 811522, "url": "http://patchwork.ozlabs.org/api/patches/811522/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-39-david@gibson.dropbear.id.au/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908103558.31632-39-david@gibson.dropbear.id.au>", "list_archive_url": null, "date": "2017-09-08T10:35:56", "name": "[PULL,38/40] ppc: drop caching ObjectClass from PowerPCCPUAlias", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "095243ac288243fb85fd85294aee5062a9408a47", "submitter": { "id": 47, "url": "http://patchwork.ozlabs.org/api/people/47/?format=api", "name": "David Gibson", "email": "david@gibson.dropbear.id.au" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-39-david@gibson.dropbear.id.au/mbox/", "series": [ { "id": 2179, "url": "http://patchwork.ozlabs.org/api/series/2179/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2179", "date": "2017-09-08T10:35:20", "name": "[PULL,01/40] hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2179/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811522/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811522/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"KwovIK1t\"; \n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpZ5q72Pcz9s7G\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 20:57:19 +1000 (AEST)", "from localhost ([::1]:44550 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqGyM-0003cE-1E\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 06:57:18 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:58997)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1dqGeJ-0002Ly-91\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:46 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1dqGe8-0003Pq-Mg\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:35 -0400", "from ozlabs.org ([2401:3900:2:1::2]:46323)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <dgibson@ozlabs.org>)\n\tid 1dqGe8-0003Mv-Bw; Fri, 08 Sep 2017 06:36:24 -0400", "by ozlabs.org (Postfix, from userid 1007)\n\tid 3xpYdR5XQhz9t6K; Fri, 8 Sep 2017 20:36:09 +1000 (AEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1504866971;\n\tbh=srj1Jwd3UpKxUOa+f9dcnJRUjBvZCGlR/bPoLoCicTI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KwovIK1tQIjwNy9U3zkFHh+48yBhgEcYk9K/Bg/KhTNttuLt0a874J4NHoGDH+cF/\n\tI21YKHNNQPmJ0AumyNYawelz8B9nrnGaqkAhmecQqsNZV4GBYQgoMvcrk7yKPEbeCh\n\tBYugIONYQYCV0z9BDkpDn3mYRfp/wy8bOGp5xloA=", "From": "David Gibson <david@gibson.dropbear.id.au>", "To": "peter.maydell@linaro.org", "Date": "Fri, 8 Sep 2017 20:35:56 +1000", "Message-Id": "<20170908103558.31632-39-david@gibson.dropbear.id.au>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170908103558.31632-1-david@gibson.dropbear.id.au>", "References": "<20170908103558.31632-1-david@gibson.dropbear.id.au>", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2401:3900:2:1::2", "Subject": "[Qemu-devel] [PULL 38/40] ppc: drop caching ObjectClass from\n\tPowerPCCPUAlias", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de,\n\tmdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org,\n\timammedo@redhat.com, sam.bobroff@au1.ibm.com,\n\tDavid Gibson <david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Igor Mammedov <imammedo@redhat.com>\n\nCaching there practically doesn't give any benefits\nand that at slow path druring querying supported CPU list.\nBut it introduces non conventional path of where from\ncomes used CPU type name (kvm_ppc_register_host_cpu_type).\n\nTaking in account that kvm_ppc_register_host_cpu_type()\nfixes up models the aliases point to, it's sufficient to\nmake ppc_cpu_class_by_name() translate cpu alias to\ncorrect cpu type name.\nSo drop PowerPCCPUAlias::oc field + ppc_cpu_class_by_alias()\nand let ppc_cpu_class_by_name() do conversion to cpu type name,\nwhich simplifies code a little bit saving ~20LOC and trouble\nwondering why ppc_cpu_class_by_alias() is necessary.\n\nSigned-off-by: Igor Mammedov <imammedo@redhat.com>\nSigned-off-by: David Gibson <david@gibson.dropbear.id.au>\n---\n target/ppc/cpu-models.h | 1 -\n target/ppc/kvm.c | 1 -\n target/ppc/translate_init.c | 26 ++------------------------\n 3 files changed, 2 insertions(+), 26 deletions(-)", "diff": "diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h\nindex 629f112337..df31d7f492 100644\n--- a/target/ppc/cpu-models.h\n+++ b/target/ppc/cpu-models.h\n@@ -31,7 +31,6 @@\n typedef struct PowerPCCPUAlias {\n const char *alias;\n const char *model;\n- ObjectClass *oc;\n } PowerPCCPUAlias;\n \n extern PowerPCCPUAlias ppc_cpu_aliases[];\ndiff --git a/target/ppc/kvm.c b/target/ppc/kvm.c\nindex 6861f2f585..6442dfcb95 100644\n--- a/target/ppc/kvm.c\n+++ b/target/ppc/kvm.c\n@@ -2533,7 +2533,6 @@ static int kvm_ppc_register_host_cpu_type(void)\n if (suffix) {\n *suffix = 0;\n }\n- ppc_cpu_aliases[i].oc = oc;\n break;\n }\n }\ndiff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c\nindex 7c1d83b489..3e24cddb86 100644\n--- a/target/ppc/translate_init.c\n+++ b/target/ppc/translate_init.c\n@@ -10253,28 +10253,6 @@ PowerPCCPUClass *ppc_cpu_class_by_pvr_mask(uint32_t pvr)\n return pcc;\n }\n \n-static ObjectClass *ppc_cpu_class_by_name(const char *name);\n-\n-static ObjectClass *ppc_cpu_class_by_alias(PowerPCCPUAlias *alias)\n-{\n- ObjectClass *invalid_class = (void*)ppc_cpu_class_by_alias;\n-\n- /* Cache target class lookups in the alias table */\n- if (!alias->oc) {\n- alias->oc = ppc_cpu_class_by_name(alias->model);\n- if (!alias->oc) {\n- /* Fast check for non-existing aliases */\n- alias->oc = invalid_class;\n- }\n- }\n-\n- if (alias->oc == invalid_class) {\n- return NULL;\n- } else {\n- return alias->oc;\n- }\n-}\n-\n static ObjectClass *ppc_cpu_class_by_name(const char *name)\n {\n char *cpu_model, *typename;\n@@ -10386,7 +10364,7 @@ static void ppc_cpu_list_entry(gpointer data, gpointer user_data)\n name, pcc->pvr);\n for (i = 0; ppc_cpu_aliases[i].alias != NULL; i++) {\n PowerPCCPUAlias *alias = &ppc_cpu_aliases[i];\n- ObjectClass *alias_oc = ppc_cpu_class_by_alias(alias);\n+ ObjectClass *alias_oc = ppc_cpu_class_by_name(alias->model);\n \n if (alias_oc != oc) {\n continue;\n@@ -10466,7 +10444,7 @@ CpuDefinitionInfoList *arch_query_cpu_definitions(Error **errp)\n CpuDefinitionInfoList *entry;\n CpuDefinitionInfo *info;\n \n- oc = ppc_cpu_class_by_alias(alias);\n+ oc = ppc_cpu_class_by_name(alias->model);\n if (oc == NULL) {\n continue;\n }\n", "prefixes": [ "PULL", "38/40" ] }