Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811504/?format=api
{ "id": 811504, "url": "http://patchwork.ozlabs.org/api/patches/811504/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-15-david@gibson.dropbear.id.au/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908103558.31632-15-david@gibson.dropbear.id.au>", "list_archive_url": null, "date": "2017-09-08T10:35:32", "name": "[PULL,14/40] e500: Use cpu_index instead of vcpu_dt_id", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2234284e80296321f4c75456fd5f488d806882e1", "submitter": { "id": 47, "url": "http://patchwork.ozlabs.org/api/people/47/?format=api", "name": "David Gibson", "email": "david@gibson.dropbear.id.au" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-15-david@gibson.dropbear.id.au/mbox/", "series": [ { "id": 2179, "url": "http://patchwork.ozlabs.org/api/series/2179/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2179", "date": "2017-09-08T10:35:20", "name": "[PULL,01/40] hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2179/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811504/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811504/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"Dh9BYcY3\"; \n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpYqY0NLCz9s82\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 20:44:57 +1000 (AEST)", "from localhost ([::1]:44484 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqGmN-0001RZ-3R\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 06:44:55 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:58651)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1dqGe4-000280-JX\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:27 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1dqGdz-0003De-SI\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:20 -0400", "from ozlabs.org ([103.22.144.67]:57957)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <dgibson@ozlabs.org>)\n\tid 1dqGdz-0003BN-Gi; Fri, 08 Sep 2017 06:36:15 -0400", "by ozlabs.org (Postfix, from userid 1007)\n\tid 3xpYdK3jZcz9t4b; Fri, 8 Sep 2017 20:36:04 +1000 (AEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1504866965;\n\tbh=dEXoKjuj8k7MH4w4ui8rCjPCkzJaQUEnQS04UcEjkvw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Dh9BYcY3gBGcDtgzHy/5JiId8RkNWA2pPsxHiIkcdKi3zrTUNFAlDIxOd1hLMPBZt\n\t/PjuVOo6ll73URNCZFTFRf019vGdttkIskwqmjB/LNR3+VjP+VXOwhkFhZk5rdiZ/P\n\t0DRHMr/hRUqG82AgsUT+Xgq5JtID4eKPvcpNt9L4=", "From": "David Gibson <david@gibson.dropbear.id.au>", "To": "peter.maydell@linaro.org", "Date": "Fri, 8 Sep 2017 20:35:32 +1000", "Message-Id": "<20170908103558.31632-15-david@gibson.dropbear.id.au>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170908103558.31632-1-david@gibson.dropbear.id.au>", "References": "<20170908103558.31632-1-david@gibson.dropbear.id.au>", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "103.22.144.67", "Subject": "[Qemu-devel] [PULL 14/40] e500: Use cpu_index instead of vcpu_dt_id", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de,\n\tmdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org,\n\timammedo@redhat.com, sam.bobroff@au1.ibm.com,\n\tDavid Gibson <david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Sam Bobroff <sam.bobroff@au1.ibm.com>\n\nThe e500 platform code uses the function ppc_get_vcpu_dt_id() to get\nan id to put in its device tree. Which seems like it makes sense, but\nppc_get_vcpu_dt_id() is actually badly named - it only differs from\ncpu_index in cases where you're running on KVM HV and the host's\nnumber of threads differs from the guests. Since KVM HV only supports\nPAPR, not e500, it doesn't make sense to use it here.\n\nSimply use the cpu_index instead (which is 'i' in this context\nbecause qemu_get_cpu(i) returns the cpu with cpu_index == i).\n\nSigned-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>\nReviewed-by: Greg Kurz <groug@kaod.org>\n[dwg: Rewrote commit message]\nSigned-off-by: David Gibson <david@gibson.dropbear.id.au>\n---\n hw/ppc/e500.c | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c\nindex f0596f34ff..55cad780f4 100644\n--- a/hw/ppc/e500.c\n+++ b/hw/ppc/e500.c\n@@ -382,7 +382,6 @@ static int ppce500_load_device_tree(MachineState *machine,\n the first node as boot node and be happy */\n for (i = smp_cpus - 1; i >= 0; i--) {\n CPUState *cpu;\n- PowerPCCPU *pcpu;\n char cpu_name[128];\n uint64_t cpu_release_addr = params->spin_base + (i * 0x20);\n \n@@ -391,16 +390,13 @@ static int ppce500_load_device_tree(MachineState *machine,\n continue;\n }\n env = cpu->env_ptr;\n- pcpu = POWERPC_CPU(cpu);\n \n- snprintf(cpu_name, sizeof(cpu_name), \"/cpus/PowerPC,8544@%x\",\n- ppc_get_vcpu_dt_id(pcpu));\n+ snprintf(cpu_name, sizeof(cpu_name), \"/cpus/PowerPC,8544@%x\", i);\n qemu_fdt_add_subnode(fdt, cpu_name);\n qemu_fdt_setprop_cell(fdt, cpu_name, \"clock-frequency\", clock_freq);\n qemu_fdt_setprop_cell(fdt, cpu_name, \"timebase-frequency\", tb_freq);\n qemu_fdt_setprop_string(fdt, cpu_name, \"device_type\", \"cpu\");\n- qemu_fdt_setprop_cell(fdt, cpu_name, \"reg\",\n- ppc_get_vcpu_dt_id(pcpu));\n+ qemu_fdt_setprop_cell(fdt, cpu_name, \"reg\", i);\n qemu_fdt_setprop_cell(fdt, cpu_name, \"d-cache-line-size\",\n env->dcache_line_size);\n qemu_fdt_setprop_cell(fdt, cpu_name, \"i-cache-line-size\",\n", "prefixes": [ "PULL", "14/40" ] }