Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811499/?format=api
{ "id": 811499, "url": "http://patchwork.ozlabs.org/api/patches/811499/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-2-david@gibson.dropbear.id.au/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908103558.31632-2-david@gibson.dropbear.id.au>", "list_archive_url": null, "date": "2017-09-08T10:35:19", "name": "[PULL,01/40] hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bc7b5ba5990b8b9b0776959042bc83f7b1fe8ca2", "submitter": { "id": 47, "url": "http://patchwork.ozlabs.org/api/people/47/?format=api", "name": "David Gibson", "email": "david@gibson.dropbear.id.au" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-2-david@gibson.dropbear.id.au/mbox/", "series": [ { "id": 2179, "url": "http://patchwork.ozlabs.org/api/series/2179/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2179", "date": "2017-09-08T10:35:20", "name": "[PULL,01/40] hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2179/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811499/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811499/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"dzRSZD70\"; \n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpYl1378rz9s82\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 20:41:01 +1000 (AEST)", "from localhost ([::1]:44468 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqGiZ-00065L-CL\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 06:40:59 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:58639)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1dqGe3-00027P-UL\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:26 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1dqGdu-00037Z-Jo\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:19 -0400", "from ozlabs.org ([2401:3900:2:1::2]:43325)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <dgibson@ozlabs.org>)\n\tid 1dqGdu-00032P-8J; Fri, 08 Sep 2017 06:36:10 -0400", "by ozlabs.org (Postfix, from userid 1007)\n\tid 3xpYdH40kGz9sQl; Fri, 8 Sep 2017 20:36:03 +1000 (AEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1504866963;\n\tbh=cFndPymPzD8hVWCYV9Ff3A9ZCWevw2GVBBkqMkTuJgI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dzRSZD70kmCwH9amyVqrGW4SriPXAGpxYr/CE7J7zxavaOK0LjNU8PlqYvq0jJOV5\n\tWKQr8EtrC1WxSZ78uSZb4xQ5kwlWW3v0ptjZvBLG+5l+3pTgtATa+yHH0tpHAhw1+N\n\tAAnKMD69vvlz4Qr82DWFhoxVQX9hRDk/1++uykqM=", "From": "David Gibson <david@gibson.dropbear.id.au>", "To": "peter.maydell@linaro.org", "Date": "Fri, 8 Sep 2017 20:35:19 +1000", "Message-Id": "<20170908103558.31632-2-david@gibson.dropbear.id.au>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170908103558.31632-1-david@gibson.dropbear.id.au>", "References": "<20170908103558.31632-1-david@gibson.dropbear.id.au>", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2401:3900:2:1::2", "Subject": "[Qemu-devel] [PULL 01/40] hw/ppc/spapr_drc.c: change\n\tspapr_drc_needed to use drc->dev", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de,\n\tmdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org, imammedo@redhat.com, \n\tDaniel Henrique Barboza <danielhb@linux.vnet.ibm.com>,\n\tsam.bobroff@au1.ibm.com, David Gibson <david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>\n\nThis patch makes a small fix in 'spapr_drc_needed' to change how we detect\nif a DRC has a device attached. Previously it used dr_entity_sense for this,\nwhich works for physical DRCs.\n\nHowever, for logical DRCs, it didn't cover the case where a logical DRC has\na drc->dev but the state is LOGICAL_UNUSABLE (e.g. a hotplugged CPU before\nCAS). In this case, the dr_entity_sense of this DRC returns UNUSABLE and the\ncode was considering that there were no dev attached, making spapr_drc_needed\nreturn 'false' when in fact we would like to migrate the DRC.\n\nChanging it to check for drc->dev instead works for all DRC types.\n\nSigned-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>\nSigned-off-by: David Gibson <david@gibson.dropbear.id.au>\n---\n hw/ppc/spapr_drc.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c\nindex 605697d8bd..031ba7c387 100644\n--- a/hw/ppc/spapr_drc.c\n+++ b/hw/ppc/spapr_drc.c\n@@ -464,10 +464,9 @@ static bool spapr_drc_needed(void *opaque)\n {\n sPAPRDRConnector *drc = (sPAPRDRConnector *)opaque;\n sPAPRDRConnectorClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);\n- sPAPRDREntitySense value = drck->dr_entity_sense(drc);\n \n /* If no dev is plugged in there is no need to migrate the DRC state */\n- if (value != SPAPR_DR_ENTITY_SENSE_PRESENT) {\n+ if (!drc->dev) {\n return false;\n }\n \n", "prefixes": [ "PULL", "01/40" ] }