Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811495/?format=api
{ "id": 811495, "url": "http://patchwork.ozlabs.org/api/patches/811495/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-3-david@gibson.dropbear.id.au/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908103558.31632-3-david@gibson.dropbear.id.au>", "list_archive_url": null, "date": "2017-09-08T10:35:20", "name": "[PULL,02/40] hw/ppc: clear pending_events on machine reset", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "591ac4dbc377c04a87cb6eb02afdf61598cd0e96", "submitter": { "id": 47, "url": "http://patchwork.ozlabs.org/api/people/47/?format=api", "name": "David Gibson", "email": "david@gibson.dropbear.id.au" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-3-david@gibson.dropbear.id.au/mbox/", "series": [ { "id": 2179, "url": "http://patchwork.ozlabs.org/api/series/2179/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2179", "date": "2017-09-08T10:35:20", "name": "[PULL,01/40] hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2179/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811495/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811495/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"P+qB8esv\"; \n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpYfj51Xfz9s7h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 20:37:15 +1000 (AEST)", "from localhost ([::1]:44449 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqGev-00029k-B9\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 06:37:13 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:58538)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1dqGdz-00023n-DV\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:20 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1dqGdu-00037r-PS\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:15 -0400", "from ozlabs.org ([2401:3900:2:1::2]:41095)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <dgibson@ozlabs.org>)\n\tid 1dqGdu-00032U-EK; Fri, 08 Sep 2017 06:36:10 -0400", "by ozlabs.org (Postfix, from userid 1007)\n\tid 3xpYdH5zbvz9sDB; Fri, 8 Sep 2017 20:36:03 +1000 (AEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1504866963;\n\tbh=4LczZrC0MKA8gAOHw3qOXkmnI+EKMsDsizkD1S2qerw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=P+qB8esvrTzwimSngxfrdQhE40gd/1balwPR7MWagjG1AHOOWkM0mZPy8YkQt3+GH\n\tu3eoiO3jWa/1m+IJ8sF42cuz05o7BefnhvgKRI0K4Nxl9Oa9s5V62NZ58dUgj9Y47L\n\tmThYzrubEbAUuzvOsQiZ0ekbLITkDXGwKuSlD2Yk=", "From": "David Gibson <david@gibson.dropbear.id.au>", "To": "peter.maydell@linaro.org", "Date": "Fri, 8 Sep 2017 20:35:20 +1000", "Message-Id": "<20170908103558.31632-3-david@gibson.dropbear.id.au>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170908103558.31632-1-david@gibson.dropbear.id.au>", "References": "<20170908103558.31632-1-david@gibson.dropbear.id.au>", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2401:3900:2:1::2", "Subject": "[Qemu-devel] [PULL 02/40] hw/ppc: clear pending_events on machine\n\treset", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de,\n\tmdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org, imammedo@redhat.com, \n\tDaniel Henrique Barboza <danielhb@linux.vnet.ibm.com>,\n\tsam.bobroff@au1.ibm.com, David Gibson <david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>\n\nThe sPAPR machine isn't clearing up the pending events QTAILQ on\nmachine reboot. This allows for unprocessed hotplug/epow events\nto persist in the queue after reset and, when reasserting the IRQs in\ncheck_exception later on, these will be being processed by the OS.\n\nThis patch implements a new function called 'spapr_clear_pending_events'\nthat clears up the pending_events QTAILQ. This helper is then called\ninside ppc_spapr_reset to clear up the events queue, preventing\nold/deprecated events from persisting after a reset.\n\nSigned-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>\nSigned-off-by: David Gibson <david@gibson.dropbear.id.au>\n---\n hw/ppc/spapr.c | 1 +\n hw/ppc/spapr_events.c | 11 +++++++++++\n include/hw/ppc/spapr.h | 1 +\n 3 files changed, 13 insertions(+)", "diff": "diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c\nindex cec441cbf4..0e5f29d348 100644\n--- a/hw/ppc/spapr.c\n+++ b/hw/ppc/spapr.c\n@@ -1392,6 +1392,7 @@ static void ppc_spapr_reset(void)\n }\n \n qemu_devices_reset();\n+ spapr_clear_pending_events(spapr);\n \n /*\n * We place the device tree and RTAS just below either the top of the RMA,\ndiff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c\nindex f952b78237..66b8164f30 100644\n--- a/hw/ppc/spapr_events.c\n+++ b/hw/ppc/spapr_events.c\n@@ -700,6 +700,17 @@ static void event_scan(PowerPCCPU *cpu, sPAPRMachineState *spapr,\n rtas_st(rets, 0, RTAS_OUT_NO_ERRORS_FOUND);\n }\n \n+void spapr_clear_pending_events(sPAPRMachineState *spapr)\n+{\n+ sPAPREventLogEntry *entry = NULL;\n+\n+ QTAILQ_FOREACH(entry, &spapr->pending_events, next) {\n+ QTAILQ_REMOVE(&spapr->pending_events, entry, next);\n+ g_free(entry->extended_log);\n+ g_free(entry);\n+ }\n+}\n+\n void spapr_events_init(sPAPRMachineState *spapr)\n {\n QTAILQ_INIT(&spapr->pending_events);\ndiff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h\nindex 2a303a705c..5d161ec580 100644\n--- a/include/hw/ppc/spapr.h\n+++ b/include/hw/ppc/spapr.h\n@@ -662,6 +662,7 @@ void spapr_cpu_parse_features(sPAPRMachineState *spapr);\n int spapr_hpt_shift_for_ramsize(uint64_t ramsize);\n void spapr_reallocate_hpt(sPAPRMachineState *spapr, int shift,\n Error **errp);\n+void spapr_clear_pending_events(sPAPRMachineState *spapr);\n \n /* CPU and LMB DRC release callbacks. */\n void spapr_core_release(DeviceState *dev);\n", "prefixes": [ "PULL", "02/40" ] }