Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811412/?format=api
{ "id": 811412, "url": "http://patchwork.ozlabs.org/api/patches/811412/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908091700.14867-8-famz@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908091700.14867-8-famz@redhat.com>", "list_archive_url": null, "date": "2017-09-08T09:17:00", "name": "[RFC,7/7] tests: Move i386 tcg tests to check-tcg", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7e6c28280d3f5ff11ea707e88c57bf16fba1be20", "submitter": { "id": 24872, "url": "http://patchwork.ozlabs.org/api/people/24872/?format=api", "name": "Fam Zheng", "email": "famz@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908091700.14867-8-famz@redhat.com/mbox/", "series": [ { "id": 2149, "url": "http://patchwork.ozlabs.org/api/series/2149/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2149", "date": "2017-09-08T09:16:53", "name": "Proof of concept to power up \"make test\" with docker", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2149/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811412/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811412/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpWzC4zZxz9s82\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 19:21:27 +1000 (AEST)", "from localhost ([::1]:44052 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqFTZ-0000JA-Nj\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 05:21:25 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:52711)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <famz@redhat.com>) id 1dqFQ6-0006Rj-SA\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:17:56 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <famz@redhat.com>) id 1dqFQ0-000138-8E\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:17:50 -0400", "from mx1.redhat.com ([209.132.183.28]:57646)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <famz@redhat.com>) id 1dqFPz-00011a-W4\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:17:44 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 19DBF81DE4;\n\tFri, 8 Sep 2017 09:17:43 +0000 (UTC)", "from lemon.redhat.com (ovpn-12-98.pek2.redhat.com [10.72.12.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 67F1E60241;\n\tFri, 8 Sep 2017 09:17:38 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 19DBF81DE4", "From": "Fam Zheng <famz@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 8 Sep 2017 17:17:00 +0800", "Message-Id": "<20170908091700.14867-8-famz@redhat.com>", "In-Reply-To": "<20170908091700.14867-1-famz@redhat.com>", "References": "<20170908091700.14867-1-famz@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 08 Sep 2017 09:17:43 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH RFC 7/7] tests: Move i386 tcg tests to check-tcg", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "peter.maydell@linaro.org, thuth@redhat.com, Fam Zheng <famz@redhat.com>, \n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,\n\tprogrammingkidx@gmail.com, crosa@redhat.com, pbonzini@redhat.com, \n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, rth@twiddle.net", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Only enable the tests if i386-linux-user is a specified target in\nconfigure, and build the test programs with \"docker.py cc\" command.\n\nAlso change the \"diff -u\" to \"cmp -s\" because we have really huge output\nto compare.\n\nSigned-off-by: Fam Zheng <famz@redhat.com>\n---\n tests/tcg/Makefile | 60 -------------------------------------\n tests/tcg/Makefile.include | 74 +++++++++++++++++++++++++++++++++++++++++++++-\n 2 files changed, 73 insertions(+), 61 deletions(-)", "diff": "diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile\nindex 89e3342f3d..4a2b069304 100644\n--- a/tests/tcg/Makefile\n+++ b/tests/tcg/Makefile\n@@ -17,15 +17,6 @@ LDFLAGS=\n # runcom maps page 0, so it requires root privileges\n # also, pi_10.com runs indefinitely\n \n-I386_TESTS=hello-i386 \\\n-\t linux-test \\\n-\t testthread \\\n-\t sha1-i386 \\\n-\t test-i386 \\\n-\t test-i386-fprem \\\n-\t test-mmap \\\n-\t # runcom\n-\n # native i386 compilers sometimes are not biarch. assume cross-compilers are\n ifneq ($(ARCH),i386)\n I386_TESTS+=run-test-x86_64\n@@ -46,35 +37,11 @@ test: all\n run-%: %\n \t-$(QEMU) ./$*\n \n-run-hello-i386: hello-i386\n-run-linux-test: linux-test\n-run-testthread: testthread\n-run-sha1-i386: sha1-i386\n-\n-run-test-i386: test-i386\n-\t./test-i386 > test-i386.ref\n-\t-$(QEMU) test-i386 > test-i386.out\n-\t@if diff -u test-i386.ref test-i386.out ; then echo \"Auto Test OK\"; fi\n-\n-run-test-i386-fprem: test-i386-fprem\n-\t./test-i386-fprem > test-i386-fprem.ref\n-\t-$(QEMU) test-i386-fprem > test-i386-fprem.out\n-\t@if diff -u test-i386-fprem.ref test-i386-fprem.out ; then echo \"Auto Test OK\"; fi\n-\n run-test-x86_64: test-x86_64\n \t./test-x86_64 > test-x86_64.ref\n \t-$(QEMU_X86_64) test-x86_64 > test-x86_64.out\n \t@if diff -u test-x86_64.ref test-x86_64.out ; then echo \"Auto Test OK\"; fi\n \n-run-test-mmap: test-mmap\n-\t-$(QEMU) ./test-mmap\n-\t-$(QEMU) -p 8192 ./test-mmap 8192\n-\t-$(QEMU) -p 16384 ./test-mmap 16384\n-\t-$(QEMU) -p 32768 ./test-mmap 32768\n-\n-run-runcom: runcom\n-\t-$(QEMU) ./runcom $(SRC_PATH)/tests/pi_10.com\n-\n run-test_path: test_path\n \t./test_path\n \n@@ -84,37 +51,10 @@ test_path: test_path.o\n \n test_path.o: test_path.c\n \n-hello-i386: hello-i386.c\n-\t$(CC_I386) -nostdlib $(CFLAGS) -static $(LDFLAGS) -o $@ $<\n-\tstrip $@\n-\n-testthread: testthread.c\n-\t$(CC_I386) $(CFLAGS) $(LDFLAGS) -o $@ $< -lpthread\n-\n-# i386/x86_64 emulation test (test various opcodes) */\n-test-i386: test-i386.c test-i386-code16.S test-i386-vm86.S \\\n- test-i386.h test-i386-shift.h test-i386-muldiv.h\n-\t$(CC_I386) $(QEMU_INCLUDES) $(CFLAGS) $(LDFLAGS) -o $@ \\\n- $(<D)/test-i386.c $(<D)/test-i386-code16.S $(<D)/test-i386-vm86.S -lm\n-\n-test-i386-fprem: test-i386-fprem.c\n-\t$(CC_I386) $(QEMU_INCLUDES) $(CFLAGS) $(LDFLAGS) -o $@ $^\n-\n test-x86_64: test-i386.c \\\n test-i386.h test-i386-shift.h test-i386-muldiv.h\n \t$(CC_X86_64) $(QEMU_INCLUDES) $(CFLAGS) $(LDFLAGS) -o $@ $(<D)/test-i386.c -lm\n \n-# generic Linux and CPU test\n-linux-test: linux-test.c\n-\t$(CC_I386) $(CFLAGS) $(LDFLAGS) -o $@ $< -lm\n-\n-# vm86 test\n-runcom: runcom.c\n-\t$(CC_I386) $(CFLAGS) $(LDFLAGS) -o $@ $<\n-\n-test-mmap: test-mmap.c\n-\t$(CC_I386) -m32 $(CFLAGS) -Wall -O2 $(LDFLAGS) -o $@ $<\n-\n # speed test\n sha1-i386: sha1.c\n \t$(CC_I386) $(CFLAGS) $(LDFLAGS) -o $@ $<\ndiff --git a/tests/tcg/Makefile.include b/tests/tcg/Makefile.include\nindex e5fea1c8c5..64f1a4a003 100644\n--- a/tests/tcg/Makefile.include\n+++ b/tests/tcg/Makefile.include\n@@ -1,3 +1,75 @@\n \n-check-tcg:\n+TCG_I386_TESTS := \\\n+\thello-i386 \\\n+\tlinux-test \\\n+\ttestthread \\\n+\tsha1-i386 \\\n+\ttest-i386 \\\n+\ttest-i386-fprem \\\n+\ttest-mmap \\\n+\t# runcom\n+\n+$(addprefix tests/tcg/, $(TCG_I386_TESTS)): DOCKER_IMAGE := fedora-i386-cross\n+$(addprefix tests/tcg/, $(TCG_I386_TESTS)): CFLAGS := -m32 -I/usr/lib/glib-2.0/include/ -I/usr/include/glib-2.0 -Wall -O2 -g -fno-strict-aliasing $(QEMU_INCLUDES)\n+$(addprefix tests/tcg/, $(TCG_I386_TESTS)): QEMU_CFLAGS :=\n+$(addprefix tests/tcg/, $(TCG_I386_TESTS)): LDFLAGS :=\n+$(addprefix tests/tcg/, $(TCG_I386_TESTS)): QEMU_LDFLAGS :=\n+\n+check-tcg-i386: $(addprefix tcg-run-,$(TCG_I386_TESTS))\n+$(addprefix tcg-run-,$(TCG_I386_TESTS)): QEMU := i386-linux-user/qemu-i386\n+$(addprefix tcg-run-,$(TCG_I386_TESTS)): i386-linux-user/qemu-i386\n+\n+TCG_SIMPLE_TESTS := \\\n+\thello-i386 \\\n+\tlinux-test \\\n+\ttestthread \\\n+\tsha1-i386\n+\n+$(foreach t,$(TCG_SIMPLE_TESTS), \\\n+\t$(eval tcg-run-$t: tcg-runsimple-$t))\n+\n+tcg-runsimple-%: tests/tcg/%$(EXESUF)\n+\t-$(QEMU) $<\n+\n+TCG_CMP_TESTS := \\\n+\ttest-i386 \\\n+\ttest-i386-fprem\n+\n+$(foreach t,$(TCG_CMP_TESTS), \\\n+\t$(eval tcg-run-$t: tcg-runcmp-$t))\n+\n+tcg-runcmp-%: tests/tcg/%$(EXESUF)\n+\t$< > $<.ref\n+\t-$(QEMU) $< > $<.out\n+\t@if cmp -s $<.ref $<.out ; then echo \"Auto Test OK\"; fi\n+\n+tcg-run-test-mmap: tests/tcg/test-mmap\n+\t-$(QEMU) $<\n+\t-$(QEMU) -p 8192 $< 8192\n+\t-$(QEMU) -p 16384 $< 16384\n+\t-$(QEMU) -p 32768 $< 32768\n+\n+tcg-run-runcom: tests/tcg/runcom\n+\t-$(QEMU) $< $(SRC_PATH)/tests/tcg/pi_10.com\n+\n+TCG_TESTS = $(if $(filter i386-linux-user, $(TARGET_LIST)), $(TCG_I386_TESTS))\n+\n+$(addprefix tests/tcg/, $(TCG_TESTS)): CXX :=\n+$(addprefix tests/tcg/, $(TCG_TESTS)): CC := \\\n+\t$(SRC_PATH)/tests/docker/docker.py cc -i qemu:$(DOCKER_IMAGE) -s $(SRC_PATH) --\n+\n+tests/tcg/hello-i386: LDFLAGS := -nostdlib\n+\n+tests/tcg/sha1-i386: tests/tcg/sha1.o\n+\t$(call LINK, $^)\n+\n+tests/tcg/test-i386: $(addprefix $(SRC_PATH)/tests/tcg/, \\\n+\t\t\ttest-i386.c test-i386-code16.S test-i386-vm86.S \\\n+ test-i386.h test-i386-shift.h test-i386-muldiv.h)\n+\t$(CC) $(CFLAGS) $(LDFLAGS) -o $@ \\\n+ $(<D)/test-i386.c $(<D)/test-i386-code16.S $(<D)/test-i386-vm86.S -lm\n+\n+.PHONY: check-tcg $(patsubst %,run-%,$(TCG_TESTS))\n+\n+check-tcg: $(addprefix tcg-run-, $(TCG_TESTS))\n \t$(MAKE) -C tests/tcg test\n", "prefixes": [ "RFC", "7/7" ] }